From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752946AbcHOKPi (ORCPT <rfc822;w@1wt.eu>);
	Mon, 15 Aug 2016 06:15:38 -0400
Received: from mga14.intel.com ([192.55.52.115]:21495 "EHLO mga14.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752423AbcHOKPh (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 15 Aug 2016 06:15:37 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.28,524,1464678000"; 
   d="scan'208";a="1035699491"
Subject: Re: [PATCH 2/2] drm/fence: allow fence waiting to be interrupted by
 userspace
To: Gustavo Padovan <gustavo@padovan.org>, dri-devel@lists.freedesktop.org
References: <1470940785-25870-1-git-send-email-gustavo@padovan.org>
 <1470940785-25870-2-git-send-email-gustavo@padovan.org>
Cc: linux-kernel@vger.kernel.org, Daniel Stone <daniels@collabora.com>,
        Daniel Vetter <daniel.vetter@ffwll.ch>,
        Rob Clark <robdclark@gmail.com>, Greg Hackmann <ghackmann@google.com>,
        John Harrison <John.C.Harrison@Intel.com>,
        laurent.pinchart@ideasonboard.com, seanpaul@google.com,
        marcheu@google.com, m.chehab@samsung.com,
        Sumit Semwal <sumit.semwal@linaro.org>,
        Gustavo Padovan <gustavo.padovan@collabora.co.uk>
From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Message-ID: <9e717fc1-e259-62ce-7e23-269c0db33f9a@linux.intel.com>
Date: Mon, 15 Aug 2016 12:15:32 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.1.1
MIME-Version: 1.0
In-Reply-To: <1470940785-25870-2-git-send-email-gustavo@padovan.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Op 11-08-16 om 20:39 schreef Gustavo Padovan:
> From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
>
> If userspace is running an synchronously atomic commit and interrupts the
> atomic operation during fence_wait() it will hang until the timer expires,
> so here we change the wait to be interruptible so it stop immediately when
> userspace wants to quit.
>
> Also adds the necessary error checking for fence_wait().
>
> v2: Comment by Daniel Vetter
> 	- Add error checking for fence_wait()
>
> v3: Rebase on top of new atomic noblocking support
Meh, I don't like the swapped parameter much, couldn't we infer it from intr? or rename intr to swapped?
If we're not swapped yet, we should always wait interruptibly. When swapped, never..

~Maarten