From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Thorsten Blum <thorsten.blum@linux.dev>,
Mimi Zohar <zohar@linux.ibm.com>,
David Howells <dhowells@redhat.com>,
Jarkko Sakkinen <jarkko@kernel.org>,
Paul Moore <paul@paul-moore.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>
Cc: linux-integrity@vger.kernel.org, keyrings@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KEYS: encrypted: Use designated initializers for match_table_t structs
Date: Thu, 09 Oct 2025 08:44:35 -0400 [thread overview]
Message-ID: <9e7488652ab73d7c5c2f93ea3c68253a9f08cd82.camel@HansenPartnership.com> (raw)
In-Reply-To: <20251009115817.368170-2-thorsten.blum@linux.dev>
On Thu, 2025-10-09 at 13:58 +0200, Thorsten Blum wrote:
> Use designated initializers for 'key_format_tokens' and 'key_tokens'
> to allow struct fields to be reordered more easily
How does it improve that? The key,value pairs are surrounded by braces
so we just cut and paste the lot anyway.
> and to improve readability.
I don't think I agree with this when looking through the code,
especially because this is the way it's done for *every* option in the
entire key subsystem. So firstly I really don't think it's helpful for
only encrypted keys to be different from everything else and secondly
when I read the code (as I often do to figure out what the options
mean), the additional .token and .pattern just get in the way of what
I'm looking for.
Regards,
James
next prev parent reply other threads:[~2025-10-09 12:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-09 11:58 Thorsten Blum
2025-10-09 12:44 ` James Bottomley [this message]
2025-10-09 13:30 ` Thorsten Blum
2025-10-09 13:51 ` James Bottomley
2025-10-23 13:35 ` Roberto Sassu
2025-10-10 3:55 ` Jarkko Sakkinen
2025-10-10 4:01 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e7488652ab73d7c5c2f93ea3c68253a9f08cd82.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=dhowells@redhat.com \
--cc=jarkko@kernel.org \
--cc=jmorris@namei.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=serge@hallyn.com \
--cc=thorsten.blum@linux.dev \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®