From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6FE1346E51 for ; Fri, 21 Nov 2025 13:51:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763733077; cv=none; b=CycKmHrZ++e5NaO6obEQKTbnwt8CGXJY1jQSOQAYBXeDQ2VBb1Y4uv6FR6f4L/hG/AYFxwsgc+QTylfnLhjHlXjWjmeBTpOpDCepmax6FaxWiaGvEIoIudrKsdKo6FRaELAEYFwt9JmjmREFbRixaIs2v9Yh5pw2GPaA2TUpQOg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763733077; c=relaxed/simple; bh=DG2QRcXdozYH0xpev2AzoCwL5uVdcNKbokJJQvFJ2pE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eUkXJXwG133SVHA7Lm7XZxLekYUfLtUCjviY4+x5w7iNK7AqPurFDWPM7TiWIjyxC8U55dqudfH+ebmrLGwK2i5vyZXy0mQV3EVhxVfIm1m7WPAfT9KUOu4U/7/4Mne+AO693MLKnJvSOkXhmI2o9D0Xue/m6Y9Z+bKslz4pRZY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PhRp46Dj; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YbpSs+wG; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PhRp46Dj"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YbpSs+wG" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AL8rVpk3675799 for ; Fri, 21 Nov 2025 13:51:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= JadzdbO/0CtjjJ7eJa56fAh1RdMjyulBy3lN6xryBUI=; b=PhRp46DjMQ8GzPgP V4eKLrYCpI3gP/Jru03RNPDd9NLnPt0tgdJn1o4pnIWR5DiJpx2Bhku7lbsCtiuB 8kk/x5NyPFIEVM3rbnIIc0rXYox0I4dwH47Og2v2TxWU+0Sw9I7t7ChTpNPEyVgJ eKw2VUw9y7B0KQXsqRbSmeSOMpPg3dWaWW7GjyMN6/jeGCf+JxcdAN27VJBdfCbk QGXshSJZu1qFOyxZJthn6kR/6lybp2Klyj3Oshqio34EnAEvFPaV9jYQ25FsSPbZ lXQUKI0UYJdaEM871MupoDz46DyFNHCaoFjThEMeOxyaalc12z7hCZ/r9LNkhO+T 7Sws+Q== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ajmyj8y4y-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 21 Nov 2025 13:51:14 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8b2fdf3a190so26776685a.0 for ; Fri, 21 Nov 2025 05:51:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763733074; x=1764337874; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JadzdbO/0CtjjJ7eJa56fAh1RdMjyulBy3lN6xryBUI=; b=YbpSs+wGfC1UwXJVEnrKAqLmiAubPRvfB1TeVHIV7huxuGMTOdv4651Jc/0RReIdgn /q2TypOIbnBn7cC7O6wQy9vWBZEQH/8LL7N/y7FrPd4lhldvMr8GSftECtXq/S9auoqS fprJEn8VduNwYyRLX+7NrkkHFEYCjHMvPNu/zoN2qqjvjyi+PZkI2QTUqRTcdGAsTS7H 6Nhz6kRdAde52GMzECC40EG6iz/1nvmKHvcIrYHIMm2lgPQ6arrTyWKWECgfnbJJz/qA TTETQp1wHEoRj+0O3YES7s7AzQYbbzJEAwK3EIWDntkq5ilaw2RBJWH7NxdxbQ1Mpmtw OTvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763733074; x=1764337874; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JadzdbO/0CtjjJ7eJa56fAh1RdMjyulBy3lN6xryBUI=; b=gN/BAwAF48IvPXZV+uu6Os5cFK5oFAv2oJVLDcqF0FCjsZ1Th5T6ozg0OBfCXWBgjQ AJfR++TyPFle5UOPk5fd3lMrlO0g6LRxE/6cDejjrZrhvxlZbn5HMKBzhciGBi8sGYw3 clr77dQvGu2Y5O3j/ktj19WcUfUayYpN5Sd2ckmuv5o7LIp6+hDohwtjHQ9Fp0GKaS31 u0UtLLUS0LGRwXHlh3a4cBvGgO+VkYM7zzSYvIS9uWR+XpmKSlPc9mn70a9bZjjXu/qn oNniGX7V4L7rsrUpf3apO4MmgE10RsRcJEj5IlnFE9vCsjKJ+/wgqp+EOZ7ynX3WQzf2 iHvg== X-Forwarded-Encrypted: i=1; AJvYcCXTBN7IJhcjDmQPq+KwU4VApAV/3/4uHu44rWSuRSWzviBwN2tRF5KMzjzPkM5cyHFEHG0YtEFBU+RtoXw=@vger.kernel.org X-Gm-Message-State: AOJu0YwH3DWBVbSBNg8/czoIyDy2Honq7g6HMkWGGAbhyLC98Hb3CMNQ Qzl5c4xXNpqZg7oeMJT8r1Ov9pHwxGtkdAPJSkewPsxODx/KQ4oah5fqv+F/GHBcWEMvapZEMRH 6cEQ4d3tRfKWAcj7ToFKv+OsF675EWb6uI/u2HXz92ZnBc1tUh1S1UNeRT7+rKZnBrpQ= X-Gm-Gg: ASbGncvSd8Wh0F+Y8xbMRooNZnbY2pvtHmb3sc+RBQGhe9o6yjLlkvIuR+EeSV2ujhP b5kvAN4DxSdBMIOSqu/nlHi1K3+Ryy8dSBDiuAQNHj86zHBhKEAgQstkWSej/wA5L6xrZIN2ybR ceVSyNzsW7lLUfDVzzi8Rqx0yHMn0QVCQT6Zj4FCei88lXmZIhvuna8CUxMEsyLCrBCDj85/Mfi 4AyqdTfe2+Y+1r5cGagcsHmOaCiZ7XQd3jQHjrOW/x3/hcRFPUW3cuWWNcsswXi9fs3wiP0AMpq u5ZhiuKJeQpDhxTwf4Qe1wYf0vZcMt8IIEPwVSAj/sr5OB637UXM4KMU2AZpn6JIxhlCYV8eurc msb68BNrqcKT5x38NRqFtMaxXKbwl3bUWQpY269vmkldW2utMKfyYTNrW0PLKcpl+jnU= X-Received: by 2002:a05:620a:1aa1:b0:8a3:9d53:e1e5 with SMTP id af79cd13be357-8b33cfc8758mr183075185a.0.1763733074136; Fri, 21 Nov 2025 05:51:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IHFNjT/4SpHq+Sjnjw1z7I3jUONwJJylkkFpSq/rX6sP1ice8dlwFi+GSew3HUpOYPA54KhwA== X-Received: by 2002:a05:620a:1aa1:b0:8a3:9d53:e1e5 with SMTP id af79cd13be357-8b33cfc8758mr183071885a.0.1763733073456; Fri, 21 Nov 2025 05:51:13 -0800 (PST) Received: from [192.168.119.202] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b7654ff3bbesm459820266b.51.2025.11.21.05.51.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Nov 2025 05:51:13 -0800 (PST) Message-ID: <9e79b63b-82c4-4e20-872e-1dfc1c1139a9@oss.qualcomm.com> Date: Fri, 21 Nov 2025 14:51:11 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] soc: qcom: smem: fix qcom_smem_is_available and check if __smem is valid To: Christian Marangi , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Dan Carpenter References: <20251121091125.6289-1-ansuelsmth@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20251121091125.6289-1-ansuelsmth@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=ELgLElZC c=1 sm=1 tr=0 ts=69206e52 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=gJ8fBl20O5mqia6x0qsA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTIxMDEwMSBTYWx0ZWRfX9mYsyV3CCkMB oJpdc8pu1p21K2tmwBcgqnQN+tiWXOiUcjLg69mL5XYsgsE3+wpTt5AT0+kEPHJcQLs35sNG+J1 PEmcwM8avd50HXgRnn8xLg4eQe+pVu63mtPHLO0q/HpZr224/Pw0hacs8nJwtsZt8T8vLjExK7O +z4tyeeApOJjwyegVufEfS4F45SyIK/++WQ4hrZGOxQOknp7+6MmONJaxMhPjqu4nOG5JFI+EDY Nk0TPlJpUnsL16W1Bn0DkJW0JXmJsVocvXrIs1lQ9wdJLdtIQopcJzJ8CyvrPLz9yDhhcU4u23a umUMNoqDafjV6cBsx/ezn2X+iyS0ee8t/KdY8lof3Vz2jdK8ctAp7sgqdTBiXrV7Rv/13NxZeBA tZD4I4rbtX2vgwqWiY0q3q0OAIERpQ== X-Proofpoint-GUID: o_v_EqyO310c8yQsFvBXK2zypf9eSfMj X-Proofpoint-ORIG-GUID: o_v_EqyO310c8yQsFvBXK2zypf9eSfMj X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-21_03,2025-11-21_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 malwarescore=0 clxscore=1015 priorityscore=1501 bulkscore=0 phishscore=0 spamscore=0 impostorscore=0 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511210101 On 11/21/25 10:11 AM, Christian Marangi wrote: > Commit 7a94d5f31b54 ("soc: qcom: smem: better track SMEM uninitialized > state") changed the usage of __smem and init now as an error pointer > instead of NULL. > > qcom_smem_is_available() wasn't updated to reflect this change and also > .qcom_smem_remove doesn't reset it on module exit. > > While at it also proced other expoert symbol if __smem is not set to a > correct pointer. I think that's a separate issue where we should inspect the impact (or just mention "please call qcom_smem_is_available() first, probably) Konrad