From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 675A426ED25 for ; Thu, 21 May 2026 14:25:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779373541; cv=none; b=EhPmfZ8uX3yOlJ1b/b3SeFzVJLdCqt+vDWKfEy2mvUcL37nDZx7P6fLOx1JD3zGr6llOq+MCKEyDbnD4bcWwnjUGktQeYlGrT9MomXltHdrOIndjB1JAxbhxTM/+tZz4/7vVhfgdRhCDQDeaThlI1R2m74P/5Q9VKTMUDtXSkYM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779373541; c=relaxed/simple; bh=+C3fO9EHQqC8yb9Ea8YRyF+2U4PtwzeiyV4Jx0pc3HA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mH4HE0eCBkhKd6oKne9GJwK99T+p6AahDOynypzxHgl82HI8kbkNFkolaykYC7EU92sXYLV8VCXQMnnQRIDy9ixAnNmfogXUJvGf0DiMHTmdwoUbCHOSmSUdkZKhsy3NQS14I+yRG0+WDupFlH2H5uJhTbHNHUcSkzwrxXRQ2Pg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=6wind.com; spf=pass smtp.mailfrom=6wind.com; dkim=pass (2048-bit key) header.d=6wind.com header.i=@6wind.com header.b=IyXo3MfR; arc=none smtp.client-ip=209.85.218.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=6wind.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=6wind.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=6wind.com header.i=@6wind.com header.b="IyXo3MfR" Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-bce3350fe3eso86159866b.0 for ; Thu, 21 May 2026 07:25:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; t=1779373539; x=1779978339; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:content-language :from:references:cc:to:subject:reply-to:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=8fIErPlRSj4fk2dY+zUS744qFronKsaelvf6iKyKFKQ=; b=IyXo3MfRPtLzvEM7I5Bch8BNUC1qogTTnjTAL64Ar7313l6eEXzn35z8h7uvybRlrA mb1bXOkqNru2qu49NvwAzN+W3JC+4RsZ2JSgEBqZ9gbXrBg4ya2lr5/0tr/DcSgEL6/a Z1FdAMlqSCbksJMSweiV7CJ/H+47wPPtbNjU2fBX7sAd63dLbmBxuZqBU+NV+0hGpI6p IdcbA36EUy5O3sotzGGKohA0jcGT/O92j1Iuz8BjCBNC4ls6DVVHUFSZRNUK6ncQKsw8 r8cEtqMRkVcKYlcZGmZTlB2qFQXjK1yZbB2Mtx0c6N9FqMLoSLeOujuhCEJJPQ3OCSCN byxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779373539; x=1779978339; h=content-transfer-encoding:in-reply-to:organization:content-language :from:references:cc:to:subject:reply-to:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8fIErPlRSj4fk2dY+zUS744qFronKsaelvf6iKyKFKQ=; b=XVoX/Zo9IIV2sKq/5T0nkOlRids8L8Vuw5Ttt4okcQam1Tg6VkJbm81xTkn3jMc1TX ovarcVfr+f6kH5JV3oSLAV0eP3kXutL7wk8a5gOHsMyIwV96zYBzKpQm6odrZ73S/P7f mttwKvkiw0PJa54BXlIC3TnwQEGJmxr3rcWLnZV3Mxlm1iQFRIFJXBYu9Pzx8dQmTQ+D hud/jw4PzIVaqCjoVHMt2SdqtAOm07RnYH8fzm8GZBIMFeP0U8HZuHn/hvQEEzkE11Aw U2z/iZA1qMBvWVCtIyCL4v3cImYPjHz64NyzpmTzW37NL0nHMEJrnHFTY/JetNsIr5Cn 8Ogw== X-Forwarded-Encrypted: i=1; AFNElJ/6IQ5TTUdk5nTWbBvl2a/OfH7W1UsJkwcyajorKVccrtgauJvDtp9IJcArP7PPYAORjFg/XeQiaAILYyg=@vger.kernel.org X-Gm-Message-State: AOJu0Yzd/9ZcB9vhnFXxOJfE3jgCd6PVseOPhF0D5pFFkhpmtQ9BWIlB zrmySzj2BGNI69whcmwrzwZZPeBVzUyWOL75p7RUCs+4q/faxL6FsudRs0oQgMaDVEw= X-Gm-Gg: Acq92OFBuM4SU0Spv0scrGaN1xlglfodc+gn2YTb49YW0BLYM40IWJroI+3Ed7p3JNB /0ypXLnBbQKhu9bxLoHAn2D2+reSQlX8SGWkp5C+fR+z7NJAuseA2B/euvnMqu8rYEUEgN2MrBL Y9sTKmseJgGdpMkesDCCp3HmNBZsz6Im9pX33gKVpeg8lHwjnGqF3vesn0tAjUrrIP3tztVNSMI TrBnQuNcxaHGm8SKNFAgxqC4dNbZkUTfTtNl9Sy8hOZyv6fF/jVeR0qkXsQh0Rdcl+JLyY3t0I9 /giuBUKyQqVQ6uvDkTzysRyreS63SLdK62bPoSYlIxPUUVAlxG3ryKIVCd4apjaG/I5sl1ShUh3 qww3J+JrRPg3HtSU47A0/OzZ+edCddwUkeQNPGQ3U0sdXGSg5NGoePANk+4gaGT3C4+x2VkFIKT wtdX3aCwUnO/2l9tblN0VMIxTxoPyodfGP1RM3TxYqfuLZ6ngyNuKsAvcGbMjs/DoxrBbzO6lUp EHspywJKK+nVlY= X-Received: by 2002:a17:907:961c:b0:bd2:a2a4:fd3a with SMTP id a640c23a62f3a-bdc1437aeddmr66262566b.7.1779373538588; Thu, 21 May 2026 07:25:38 -0700 (PDT) Received: from ?IPV6:2a01:e0a:ab7:2110:6a1d:efff:fe52:1959? ([2a01:e0a:ab7:2110:6a1d:efff:fe52:1959]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bdc8aa03d4asm57107166b.47.2026.05.21.07.25.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 May 2026 07:25:38 -0700 (PDT) Message-ID: <9e7b7aab-dad4-4b72-87cd-822e67b27afe@6wind.com> Date: Thu, 21 May 2026 16:25:37 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: nicolas.dichtel@6wind.com Subject: Re: [PATCH net v2 2/4] net: netlink: don't set nsid on local notifications To: Jiri Benc Cc: Ilya Maximets , netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Donald Hunter , Shuah Khan , Kuniyuki Iwashima , Kees Cook , Adrian Moreno , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Matteo Perin References: <20260520172317.175168-1-i.maximets@ovn.org> <20260520172317.175168-3-i.maximets@ovn.org> <20260521160036.413771e9@griffin> From: Nicolas Dichtel Content-Language: en-US Organization: 6WIND In-Reply-To: <20260521160036.413771e9@griffin> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Le 21/05/2026 à 16:00, Jiri Benc a écrit : > On Thu, 21 May 2026 14:36:12 +0200, Nicolas Dichtel wrote: >> I still don't think that this is the right "fix". The app is broken. Even after >> this patch, the bug could be easily triggered again by a third party. >> There is nothing wrong with assigning a self-nsid. It would be a lot more robust >> for the app to assign itself a self-nsid when it starts. > > On the other hand, does the patch break anything in practice (as > opposed to in theory)? It makes live of several apps simpler, which is > not a bad goal. I'm not against the patch, it just look like a workaround. I'm trying to understand how NETLINK_LISTEN_ALL_NSID is used (in fact, why it is used if the app doesn't "understand" NSIDs). > > The only scenario where this would introduce incompatible behavior is > an app that self-assigns a self-nsid and expects to see it. That looks Yes, I thought about this. > quite stretched, doesn't it? It does. Regards, Nicolas. > > Not that I have a strong opinion about this, though. > > Jiri >