From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E19F0C3F2D1 for ; Thu, 5 Mar 2020 04:52:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B37A1208C3 for ; Thu, 5 Mar 2020 04:52:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="dtuLObxK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725924AbgCEEw6 (ORCPT ); Wed, 4 Mar 2020 23:52:58 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:43296 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725852AbgCEEw6 (ORCPT ); Wed, 4 Mar 2020 23:52:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=quiCwQBCyAugJnvjFRablOlpidN+CuyDEr3sWx1hRsA=; b=dtuLObxKV1zy/7AnsqlI9jcBw0 bIMJVy8I453xWPrWtH+FfkPfDRQ0NIsabfMaF+6crk51JcqIdkdLoz3a7KSBlGclX+zW9zyOuTkXH +pC4dSmXzCsQ14e0d2DEBLElgqp8MlorQP1+aw8fROWWfqELSqOA2F+//VNrFATOdfVaxjR1O2k3U cY+MLLRrgAjNsEPuAQ/MPd6klehu4R5+nvLf6Wq0kG+J+ay7vPfpJz4aCXkshn5fWnRokfHK9NPWG 0J9o+qaWzBFoEvjPotZkSaylWvYnrNoLe/mIY7o4Bi8TRGy0HOElND9AxtkBSTaaRYOjVUGQLMTS0 oN6zhSZg==; Received: from [2601:1c0:6280:3f0:897c:6038:c71d:ecac] by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1j9iVE-0001Sp-2H; Thu, 05 Mar 2020 04:52:56 +0000 Subject: Re: [PATCH 1/2] bootconfig: Support O= option To: Steven Rostedt Cc: Masami Hiramatsu , Geert Uytterhoeven , Borislav Petkov , LKML , Ingo Molnar , Andrew Morton , Peter Zijlstra References: <158323467008.10560.4307464503748340855.stgit@devnote2> <158323468033.10560.14661631369326294355.stgit@devnote2> <27ae25f5-29c6-62f3-5531-78fcc28b7d3c@infradead.org> <20200304221716.007587c7@oasis.local.home> From: Randy Dunlap Message-ID: <9e7beb31-b41f-9e95-c92b-1829e420af77@infradead.org> Date: Wed, 4 Mar 2020 20:52:54 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200304221716.007587c7@oasis.local.home> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/4/20 7:17 PM, Steven Rostedt wrote: > On Wed, 4 Mar 2020 15:04:43 -0800 > Randy Dunlap wrote: > >> On 3/3/20 3:24 AM, Masami Hiramatsu wrote: >>> Support O= option to build bootconfig tool in >>> the other directory. As same as other tools, if you specify >>> O=, bootconfig command is build under . >> >> Hm. If I use >> $ make O=~/tmp -C tools/bootconfig >> >> that works: it builds bootconfig in ~/tmp. >> >> OTOH, if I sit at the top of the kernel source tree >> and I enter >> $ mkdir builddir >> $ make O=builddir -C tools/bootconfig >> >> I get this: >> make: Entering directory '/home/rdunlap/lnx/next/linux-next-20200304/tools/bootconfig' >> ../scripts/Makefile.include:4: *** O=builddir does not exist. Stop. >> make: Leaving directory '/home/rdunlap/lnx/next/linux-next-20200304/tools/bootconfig' >> >> so it looks like tools/scripts/Makefile.include doesn't handle this case correctly >> (which is how I do all of my builds). >> > > Do you build perf that way? No. It should also be fixed. > $ mkdir buildir > $ make O=buildir -C tools/perf/ > make: Entering directory '/work/git/linux-test.git/tools/perf' > BUILD: Doing 'make -j24' parallel build > ../scripts/Makefile.include:4: *** O=/work/git/linux-test.git/tools/perf/buildir does not exist. Stop. > make: *** [Makefile:70: all] Error 2 > make: Leaving directory '/work/git/linux-test.git/tools/perf' > > -- Steve Thanks. -- ~Randy