From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751257AbdAMUgU (ORCPT ); Fri, 13 Jan 2017 15:36:20 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:38189 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750969AbdAMUgM (ORCPT ); Fri, 13 Jan 2017 15:36:12 -0500 Subject: Re: [tpmdd-devel] [PATCH v8 2/2] tpm: add securityfs support for TPM 2.0 firmware event log To: Nayna Jain , tpmdd-devel@lists.sourceforge.net References: <1484121262-25732-1-git-send-email-nayna@linux.vnet.ibm.com> <1484121262-25732-3-git-send-email-nayna@linux.vnet.ibm.com> <9c605b61-bd5f-eb74-8fc0-ac3587852808@linux.vnet.ibm.com> Cc: linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org From: Stefan Berger Date: Fri, 13 Jan 2017 15:35:40 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <9c605b61-bd5f-eb74-8fc0-ac3587852808@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 17011320-0004-0000-0000-000011498B43 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00006427; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000199; SDB=6.00807249; UDB=6.00392929; IPR=6.00584580; BA=6.00005053; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00013913; XFM=3.00000011; UTC=2017-01-13 20:35:42 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17011320-0005-0000-0000-00007C27A60F Message-Id: <9e823fb6-dcc7-a097-1cba-948aeffe2eb6@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-01-13_13:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1612050000 definitions=main-1701130271 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/13/2017 01:09 PM, Stefan Berger wrote: > On 01/11/2017 02:54 AM, Nayna Jain wrote: >> Unlike the device driver support for TPM 1.2, the TPM 2.0 does >> not support the securityfs pseudo files for displaying the >> firmware event log. >> >> This patch enables support for providing the TPM 2.0 event log in >> binary form. TPM 2.0 event log supports a crypto agile format that >> records multiple digests, which is different from TPM 1.2. This >> patch enables the tpm_bios_log_setup for TPM 2.0 and adds the >> event log parser which understand the TPM 2.0 crypto agile format. >> >> Signed-off-by: Nayna Jain >> --- >> drivers/char/tpm/Makefile | 2 +- >> .../char/tpm/{tpm_eventlog.c => tpm1_eventlog.c} | 35 ++-- >> drivers/char/tpm/tpm2_eventlog.c | 203 >> +++++++++++++++++++++ >> drivers/char/tpm/tpm_acpi.c | 3 + >> drivers/char/tpm/tpm_eventlog.h | 63 +++++++ >> 5 files changed, 291 insertions(+), 15 deletions(-) >> rename drivers/char/tpm/{tpm_eventlog.c => tpm1_eventlog.c} (95%) >> create mode 100644 drivers/char/tpm/tpm2_eventlog.c >> >> >> diff --git a/drivers/char/tpm/tpm_acpi.c b/drivers/char/tpm/tpm_acpi.c >> index b7718c9..169edf3 100644 >> --- a/drivers/char/tpm/tpm_acpi.c >> +++ b/drivers/char/tpm/tpm_acpi.c >> @@ -54,6 +54,9 @@ int tpm_read_log_acpi(struct tpm_chip *chip) >> u64 len, start; >> struct tpm_bios_log *log; >> >> + if (chip->flags & TPM_CHIP_FLAG_TPM2) >> + return -ENODEV; >> + > > > Works with SeaBIOS when this check is disabled. > -> Tested-by: Stefan Berger