mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Logan Gunthorpe <logang@deltatee.com>
To: "Leon Romanovsky" <leon@kernel.org>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Chaitanya Kulkarni" <kch@nvidia.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Jens Axboe" <axboe@kernel.dk>,
	"Alex Williamson" <alex@shazbot.org>,
	"Ankit Agrawal" <ankita@nvidia.com>,
	"Jason Gunthorpe" <jgg@ziepe.ca>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Shuah Khan" <skhan@linuxfoundation.org>,
	"Joerg Roedel (AMD)" <joro@8bytes.org>,
	"Will Deacon" <will@kernel.org>,
	"Robin Murphy" <robin.murphy@arm.com>,
	"Randy Dunlap" <rdunlap@infradead.org>,
	"Sumit Semwal" <sumit.semwal@linaro.org>,
	"Christian König" <christian.koenig@amd.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-doc@vger.kernel.org, iommu@lists.linux.dev,
	Tushar Dave <tdave@nvidia.com>,
	linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linaro-mm-sig@lists.linaro.org, linux-rdma@vger.kernel.org,
	kvm@vger.kernel.org
Subject: Re: [PATCH v7 11/19] PCI/P2PDMA: Log detailed ACS routing diagnostics
Date: Mon, 21 Sep 2026 15:19:40 -0600	[thread overview]
Message-ID: <9e868c06-be53-436c-a78d-790ed2b91c3e@deltatee.com> (raw)
In-Reply-To: <20260920-fix-p2p-acs-v4-0-v7-11-ca0828ab697c@nvidia.com>



On 2026-09-20 05:41, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@nvidia.com>
> 
> When P2PDMA rejects a mapping, existing warnings identify only the final
> ACS or host-bridge result. They omit topology, live controls, divergence
> ports, cache state, and intermediate routing decisions.
> 
> Emit debug-level messages for verbose calculations and cache lookups.
> Report both paths, decoded ACS controls, directional decisions, host
> fallback, and the final mapping. This keeps incidental unsupported probes
> quiet while allowing the diagnostics to be enabled when needed.
> 
> Tested-by: Tushar Dave <tdave@nvidia.com>
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>

Looks good to me:

Reviewed-by: Logan Gunthorpe <logang@deltatee.com>

  reply	other threads:[~2026-09-21 21:19 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-20 11:41 [PATCH v7 00/19] PCI/P2PDMA: Route peer-to-peer DMA by TLP class Leon Romanovsky
2026-09-20 11:41 ` [PATCH v7 01/19] PCI/P2PDMA: Document the TLP attribute assumptions Leon Romanovsky
2026-09-20 11:41 ` [PATCH v7 02/19] PCI/P2PDMA: Derive routing from directional ACS controls Leon Romanovsky
2026-09-21 20:05   ` Logan Gunthorpe
2026-09-20 11:41 ` [PATCH v7 03/19] PCI: Reject unreadable ACS controls in isolation checks Leon Romanovsky
2026-09-20 11:41 ` [PATCH v7 04/19] PCI/P2PDMA: Evaluate ACS controls at the path divergence Leon Romanovsky
2026-09-20 11:41 ` [PATCH v7 05/19] PCI/P2PDMA: Document directional ACS routing Leon Romanovsky
2026-09-20 11:41 ` [PATCH v7 06/19] PCI/P2PDMA: Collect the path's ACS controls before deciding Leon Romanovsky
2026-09-20 11:41 ` [PATCH v7 07/19] PCI/P2PDMA: Answer routing per TLP class Leon Romanovsky
2026-09-21 20:20   ` Logan Gunthorpe
2026-09-20 11:41 ` [PATCH v7 08/19] PCI/P2PDMA: Route Relaxed Ordering Completions directly Leon Romanovsky
2026-09-20 11:41 ` [PATCH v7 09/19] PCI/P2PDMA: Reject Translated Requests blocked by Translation Blocking Leon Romanovsky
2026-09-21 20:38   ` Logan Gunthorpe
2026-09-20 11:41 ` [PATCH v7 10/19] PCI/P2PDMA: Route Translated Requests under Direct Translated P2P Leon Romanovsky
2026-09-21 20:51   ` Logan Gunthorpe
2026-09-20 11:41 ` [PATCH v7 11/19] PCI/P2PDMA: Log detailed ACS routing diagnostics Leon Romanovsky
2026-09-21 21:19   ` Logan Gunthorpe [this message]
2026-09-20 11:41 ` [PATCH v7 12/19] PCI/P2PDMA: Add KUnit tests for the ACS routing decisions Leon Romanovsky
2026-09-20 11:41 ` [PATCH v7 13/19] PCI/P2PDMA: Test the ACS P2P routing walk Leon Romanovsky
2026-09-20 11:41 ` [PATCH v7 14/19] PCI: Add KUnit coverage for ACS isolation checks Leon Romanovsky
2026-09-20 11:41 ` [PATCH v7 15/19] PCI/P2PDMA: Document TLP-class routing Leon Romanovsky
2026-09-21 22:16   ` Logan Gunthorpe
2026-09-22  9:27     ` Leon Romanovsky
2026-09-22 15:43       ` Logan Gunthorpe
2026-09-20 11:41 ` [PATCH v7 16/19] dma-buf: Let importers ask how peer-to-peer traffic is routed Leon Romanovsky
2026-09-20 11:41 ` [PATCH v7 17/19] vfio/pci: Hand out the P2PDMA provider behind a dma-buf Leon Romanovsky
2026-09-20 11:41 ` [PATCH v7 18/19] RDMA/uverbs: " Leon Romanovsky
2026-09-20 11:41 ` [PATCH v7 19/19] RDMA/mlx5: Ask P2PDMA whether ATS takes a direct peer-to-peer route Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9e868c06-be53-436c-a78d-790ed2b91c3e@deltatee.com \
    --to=logang@deltatee.com \
    --cc=alex@shazbot.org \
    --cc=ankita@nvidia.com \
    --cc=axboe@kernel.dk \
    --cc=bhelgaas@google.com \
    --cc=christian.koenig@amd.com \
    --cc=corbet@lwn.net \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=iommu@lists.linux.dev \
    --cc=jgg@ziepe.ca \
    --cc=joro@8bytes.org \
    --cc=kch@nvidia.com \
    --cc=kvm@vger.kernel.org \
    --cc=leon@kernel.org \
    --cc=linaro-mm-sig@lists.linaro.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=robin.murphy@arm.com \
    --cc=skhan@linuxfoundation.org \
    --cc=sumit.semwal@linaro.org \
    --cc=tdave@nvidia.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®