From: Ilya Maximets <i.maximets@ovn.org>
To: Eric Dumazet <edumazet@kernel.org>,
Zhengchuan Liang <zcliangcn@gmail.com>
Cc: Aaron Conole <aconole@redhat.com>,
Eelco Chaudron <echaudro@redhat.com>,
Ilya Maximets <i.maximets@ovn.org>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, dev@openvswitch.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: openvswitch: avoid hashing the network namespace pointer
Date: Wed, 18 Nov 2026 12:02:05 +0100 [thread overview]
Message-ID: <9e9396a8-e692-4438-a43e-7803ee2fcfc4@ovn.org> (raw)
In-Reply-To: <CAL4WiirYP1mDaZmyjfqoRJWJLd8PnfW3GFey7tnqYtNNqSn-kw@mail.gmail.com>
On 11/18/26 9:49 AM, Eric Dumazet wrote:
> Le mer. 18 nov. 2026 à 09:40, Zhengchuan Liang <zcliangcn@gmail.com> a écrit :
>>
>> The Open vSwitch vport name table uses the network namespace pointer as
>> the Jenkins hash seed. When an Open vSwitch vport already exists in the
>> attacker's network namespace, unprivileged OVS_VPORT_CMD_GET requests can
>> look up attacker-chosen missing names and time whether those lookups
>> traverse an occupied bucket. Ranking the resulting collision pattern
>> across possible KASLR slides recovers the init_net pointer and thus the
>> kernel text base.
>>
>> Use the namespace cookie instead. It is a stable, unique, non-address
>> identifier that is deliberately exposed to userspace. setup_net() assigns
>> it before per-net initializers run, and it remains unchanged for the
>> namespace lifetime. Fold both halves into the seed so vports in different
>> namespaces retain namespace-dependent bucket placement.
>>
>> Found by AI-assisted code review and reproduced on an unmodified kernel
>> without fault injection. After privileged setup created the resident
>> vport, the timing measurements ran as an unprivileged user with no
>> effective capabilities. With this change, the pointer-derived prediction
>> fails. Existing and missing vport lookups behave as expected. Identically
>> named vports in separate network namespaces remain independent.
>>
>> Fixes: 46df7b814548 ("openvswitch: Add support for network namespaces.")
>> Cc: stable@vger.kernel.org
>
> Same remark as for your dev_name_hash() patch: local KASLR attacks are
> not a serious concern, a "Cc: stable" tag does not belong in a
> net-next patch.
>
>> Assisted-by: LLM
>> Signed-off-by: Zhengchuan Liang <zcliangcn@gmail.com>
>> ---
>> net/openvswitch/vport.c | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/net/openvswitch/vport.c b/net/openvswitch/vport.c
>> index 083f7a8d9d4e..6689c8370ec1 100644
>> --- a/net/openvswitch/vport.c
>> +++ b/net/openvswitch/vport.c
>> @@ -53,7 +53,10 @@ void ovs_vport_exit(void)
>>
>> static struct hlist_head *hash_bucket(const struct net *net, const char *name)
>> {
>> - unsigned int hash = jhash(name, strlen(name), (unsigned long) net);
>> + u32 seed = jhash_2words(lower_32_bits(net->net_cookie),
>> + upper_32_bits(net->net_cookie), 0);
>
> Nit: hash_64(net->net_cookie, 32) would be simpler.
I agree. Also, both jhash* and hash_64 actually return u32, so we should
probably swap the type of the local 'hash' variable here as well. Having
a mix of u32 and unsigned int for the values of the same nature within the
same function is not the greatest.
Otherwise, the change looks fine to me.
Best regards, Ilya Maximets.
prev parent reply other threads:[~2026-11-18 11:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 8:37 Zhengchuan Liang
2026-11-18 8:49 ` Eric Dumazet
2026-11-18 11:02 ` Ilya Maximets [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e9396a8-e692-4438-a43e-7803ee2fcfc4@ovn.org \
--to=i.maximets@ovn.org \
--cc=aconole@redhat.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=echaudro@redhat.com \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=zcliangcn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®