From: Hans de Goede <hdegoede@redhat.com>
To: Ping Bao <pingbao@gmail.com>, Alex Hung <alex.hung@canonical.com>
Cc: Ping Bao <ping.a.bao@intel.com>,
Mark Gross <mgross@linux.intel.com>,
"open list:INTEL HID EVENT DRIVER"
<platform-driver-x86@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] platform/x86: intel-hid: add Alder Lake ACPI device ID
Date: Wed, 28 Jul 2021 12:03:31 +0200 [thread overview]
Message-ID: <9e95f7df-f12c-7a04-2234-279da65145f8@redhat.com> (raw)
In-Reply-To: <20210721225615.20575-1-ping.a.bao@intel.com>
Hi,
On 7/22/21 12:56 AM, Ping Bao wrote:
> Alder Lake has a new ACPI ID for Intel HID event filter device.
>
> Signed-off-by: Ping Bao <ping.a.bao@intel.com>
[hans@x1 platform-drivers-x86]$ scripts/checkpatch.pl 00*
---------------------------------------------------------------
0001-platform-x86-intel-hid-add-Alder-Lake-ACPI-device-ID.patch
---------------------------------------------------------------
WARNING: From:/Signed-off-by: email address mismatch: 'From: Ping Bao <pingbao@gmail.com>' != 'Signed-off-by: Ping Bao <ping.a.bao@intel.com>'
total: 0 errors, 1 warnings, 7 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
0001-platform-x86-intel-hid-add-Alder-Lake-ACPI-device-ID.patch has style problems, please review.
I'll fix this up locally now, but please fix your email setup
so that the Author field of the patch gets set to
"Ping Bao <ping.a.bao@intel.com>"
Regards,
Hans
> ---
> drivers/platform/x86/intel-hid.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/intel-hid.c b/drivers/platform/x86/intel-hid.c
> index 078648a9201b..e5fbe017f8e1 100644
> --- a/drivers/platform/x86/intel-hid.c
> +++ b/drivers/platform/x86/intel-hid.c
> @@ -25,6 +25,7 @@ static const struct acpi_device_id intel_hid_ids[] = {
> {"INT33D5", 0},
> {"INTC1051", 0},
> {"INTC1054", 0},
> + {"INTC1070", 0},
> {"", 0},
> };
> MODULE_DEVICE_TABLE(acpi, intel_hid_ids);
>
prev parent reply other threads:[~2021-07-28 10:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 22:56 Ping Bao
2021-07-28 9:59 ` Hans de Goede
2021-07-28 10:03 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e95f7df-f12c-7a04-2234-279da65145f8@redhat.com \
--to=hdegoede@redhat.com \
--cc=alex.hung@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=ping.a.bao@intel.com \
--cc=pingbao@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®