From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933456AbdHYPAf (ORCPT ); Fri, 25 Aug 2017 11:00:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51850 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932326AbdHYPAe (ORCPT ); Fri, 25 Aug 2017 11:00:34 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 4ADB280C0D Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=hdegoede@redhat.com Subject: Re: [RFC v2 1/2] virt: Add vboxguest driver for Virtual Box Guest integration To: Christoph Hellwig Cc: Arnd Bergmann , Greg Kroah-Hartman , Michael Thayer , "Knut St . Osmundsen" , Larry Finger , linux-kernel@vger.kernel.org References: <20170825143732.10836-1-hdegoede@redhat.com> <20170825143732.10836-2-hdegoede@redhat.com> <20170825145806.GA6706@infradead.org> From: Hans de Goede Message-ID: <9e9b6c22-50dd-4935-9dfd-7c8a885f75e9@redhat.com> Date: Fri, 25 Aug 2017 17:00:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170825145806.GA6706@infradead.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Fri, 25 Aug 2017 15:00:34 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 25-08-17 16:58, Christoph Hellwig wrote: > Please kill all the weird typedefs and camel case first, and then > we can do a real review. I've already removed all the typedefs and camel-case outside of include/uapi/linux The ones in include/uapi/linux are preserved to preserve API compatibility with the existing VirtualBox userspace tools. I was planning to mention this in the coverletter, but I forgot, sorry. Regards, Hans