From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12D86C07E9D for ; Tue, 27 Sep 2022 08:34:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231389AbiI0Iei (ORCPT ); Tue, 27 Sep 2022 04:34:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230149AbiI0IeF (ORCPT ); Tue, 27 Sep 2022 04:34:05 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4ED6AB4EA5; Tue, 27 Sep 2022 01:34:03 -0700 (PDT) Received: from fraeml701-chm.china.huawei.com (unknown [172.18.147.201]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4McCXZ2X8gz685Tw; Tue, 27 Sep 2022 16:31:58 +0800 (CST) Received: from lhrpeml500003.china.huawei.com (7.191.162.67) by fraeml701-chm.china.huawei.com (10.206.15.50) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2375.31; Tue, 27 Sep 2022 10:34:00 +0200 Received: from [10.48.156.245] (10.48.156.245) by lhrpeml500003.china.huawei.com (7.191.162.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 27 Sep 2022 09:33:59 +0100 Message-ID: <9e9f8384-0662-73ef-ab17-8420c94762fb@huawei.com> Date: Tue, 27 Sep 2022 09:34:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v4 3/8] scsi: pm8001: use sas_find_attached_phy() instead of open coded To: Jason Yan , , CC: , , , , , , , Jack Wang References: <20220927032605.78103-1-yanaijie@huawei.com> <20220927032605.78103-4-yanaijie@huawei.com> From: John Garry In-Reply-To: <20220927032605.78103-4-yanaijie@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.48.156.245] X-ClientProxiedBy: lhrpeml100002.china.huawei.com (7.191.160.241) To lhrpeml500003.china.huawei.com (7.191.162.67) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/09/2022 04:26, Jason Yan wrote: > +++ b/drivers/scsi/pm8001/pm8001_sas.c > @@ -645,22 +645,16 @@ static int pm8001_dev_found_notify(struct domain_device *dev) > pm8001_device->dcompletion = &completion; > if (parent_dev && dev_is_expander(parent_dev->dev_type)) { > int phy_id; > - struct ex_phy *phy; > - for (phy_id = 0; phy_id < parent_dev->ex_dev.num_phys; > - phy_id++) { > - phy = &parent_dev->ex_dev.ex_phy[phy_id]; > - if (SAS_ADDR(phy->attached_sas_addr) > - == SAS_ADDR(dev->sas_addr)) { > - pm8001_device->attached_phy = phy_id; > - break; > - } > - } > - if (phy_id == parent_dev->ex_dev.num_phys) { > + > + phy_id = sas_find_attached_phy(&parent_dev->ex_dev, dev); > + if (phy_id == -ENODEV) { > pm8001_dbg(pm8001_ha, FAIL, > "Error: no attached dev:%016llx at ex:%016llx.\n", > SAS_ADDR(dev->sas_addr), > SAS_ADDR(parent_dev->sas_addr)); > res = -1; I think that you can just pass the linux error code (-ENODEV) back here. And for hisi_sas we change to -EINVAL for this code. I don't think it's required, so I think that we can pass -ENODEV back there also. Using -EINVAL seems to come from when the code was originally added in abda97c2fe874 and from a quick glance libsas does not seem to have special processing for -EINVAL. Thanks, John > + } else { > + pm8001_device->attached_phy = phy_id; > } > } else { > if (dev->dev_type == SAS_SATA