From: "Borislav Petkov" <petkovbb@googlemail.com>
To: "Tejun Heo" <tj@kernel.org>
Cc: axboe@kernel.dk, bzolnier@gmail.com, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] ide-floppy partitions
Date: Mon, 3 Nov 2008 18:56:01 +0100 [thread overview]
Message-ID: <9ea470500811030956k209b2f2ci10bcde1ea4ac7334@mail.gmail.com> (raw)
In-Reply-To: <490F1AC6.8000109@kernel.org>
Hi
On Mon, Nov 3, 2008 at 4:37 PM, Tejun Heo <tj@kernel.org> wrote:
> Borislav Petkov wrote:
>> can you guys please ACK/NACK this so that we can have an agreed upon solution
>> and so that I can stop applying it ontop of current git before testing any
>> further.
>
> Ah... right. I missed removable devices. I think it would be better to
> just expand the table rather than recursing into __blkdev_get() again.
> I'll try to come up with cleaner solution.
Sounds good. It should simply rescan partitions upon media change before it does
disk_get_part so that the ptbl is updated.
> Also, I don't think the
> discontinuous partition would be a problem. ptbl is expanded to the
> highest numbered partition not the number of partitions. I'll test that
> too. Thanks.
You don't have to. I already did that with a harddrive in a external case over
usb and it works since upon connection the usb core rescans partitions and ptbl
is valid then.
Thanks.
--
Regards/Gruss,
Boris
next prev parent reply other threads:[~2008-11-03 17:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20081029071319.GA9205@gollum.tnic>
2008-11-01 20:14 ` Borislav Petkov
2008-11-03 15:37 ` Tejun Heo
2008-11-03 17:56 ` Borislav Petkov [this message]
2008-11-04 4:16 ` Subject: [PATCH] block: fix __blkdev_get() for removable devices Tejun Heo
2008-11-05 9:04 ` Borislav Petkov
2008-11-05 9:19 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ea470500811030956k209b2f2ci10bcde1ea4ac7334@mail.gmail.com \
--to=petkovbb@googlemail.com \
--cc=axboe@kernel.dk \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=petkovbb@gmail.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®