From: Borislav Petkov <petkovbb@googlemail.com>
To: Peter Feuerer <peter@piie.net>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
lenb@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] acerhdf: convert to dev_pm_ops
Date: Tue, 28 Jul 2009 15:59:58 +0200 [thread overview]
Message-ID: <9ea470500907280659m5a65ac2et67651247bf6925c7@mail.gmail.com> (raw)
In-Reply-To: <cone.1248787508.386883.15136.1000@arca>
On Tue, Jul 28, 2009 at 3:25 PM, Peter Feuerer<peter@piie.net> wrote:
[..]
>> That's not a reason for keeping code in the kernel and raising bloat
>> levels unnecessarily. If the driver doesn't need to do anything on
>> resume, then no function is needed.
>
> I don't think the verbose message is useless. If an user has a problem
> with suspend / hibernate I can just ask him to load the module with
> verbose=1 and dmesg tells whether the module is waking up or not.
Since the driver doesn't do anything upon resume, it _is_ _going_ to
resume just fine. If not, then the problem is located somewhere else,
i.e. you can safely assume that you are resuming ok. Also, it's not like
this is the only verbose printk you have in the driver to not be able to
follow what's going on...
--
Regards/Gruss,
Boris
next prev parent reply other threads:[~2009-07-28 13:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-15 15:48 Borislav Petkov
2009-07-15 18:36 ` Peter Feuerer
2009-07-23 8:29 ` Dmitry Torokhov
2009-07-23 8:52 ` Peter Feuerer
2009-07-23 9:21 ` Borislav Petkov
2009-07-23 12:53 ` Borislav Petkov
2009-07-27 9:07 ` Peter Feuerer
2009-07-27 15:55 ` Dmitry Torokhov
2009-07-27 18:37 ` Borislav Petkov
2009-07-28 7:25 ` Peter Feuerer
2009-07-28 9:08 ` Borislav Petkov
2009-07-28 13:25 ` Peter Feuerer
2009-07-28 13:59 ` Borislav Petkov [this message]
2009-07-29 7:25 ` Peter Feuerer
2009-07-29 11:55 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ea470500907280659m5a65ac2et67651247bf6925c7@mail.gmail.com \
--to=petkovbb@googlemail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter@piie.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®