From: Michael Straube <straube.linux@gmail.com>
To: Martin Kaiser <martin@kaiser.cx>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: r8188eu: remove the HW_VAR_CHECK_TXBUF "hal variable"
Date: Sat, 18 Sep 2021 17:20:47 +0200 [thread overview]
Message-ID: <9eb9d781-8603-4e0d-ecc3-4bd7e4808c0b@gmail.com> (raw)
In-Reply-To: <20210918141034.28481-1-martin@kaiser.cx>
On 9/18/21 16:10, Martin Kaiser wrote:
> Setting HW_VAR_CHECK_TXBUF is an empty operation.
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
> drivers/staging/r8188eu/core/rtw_mlme_ext.c | 1 -
> drivers/staging/r8188eu/hal/usb_halinit.c | 2 --
> drivers/staging/r8188eu/include/hal_intf.h | 1 -
> 3 files changed, 4 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
> index 26e14e91a42c..38ab1ab18872 100644
> --- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c
> +++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
> @@ -7785,7 +7785,6 @@ u8 sitesurvey_cmd_hdl(struct adapter *padapter, u8 *pbuf)
>
> if (pmlmeext->sitesurvey_res.state == SCAN_DISABLE) {
> /* for first time sitesurvey_cmd */
> - rtw_hal_set_hwreg(padapter, HW_VAR_CHECK_TXBUF, NULL);
>
> pmlmeext->sitesurvey_res.state = SCAN_START;
> pmlmeext->sitesurvey_res.bss_cnt = 0;
> diff --git a/drivers/staging/r8188eu/hal/usb_halinit.c b/drivers/staging/r8188eu/hal/usb_halinit.c
> index 5133d533674f..8bb2466d71a2 100644
> --- a/drivers/staging/r8188eu/hal/usb_halinit.c
> +++ b/drivers/staging/r8188eu/hal/usb_halinit.c
> @@ -1813,8 +1813,6 @@ static void SetHwReg8188EU(struct adapter *Adapter, u8 variable, u8 *val)
> }
> }
> break;
> - case HW_VAR_CHECK_TXBUF:
> - break;
> case HW_VAR_APFM_ON_MAC:
> haldata->bMacPwrCtrlOn = *val;
> DBG_88E("%s: bMacPwrCtrlOn=%d\n", __func__, haldata->bMacPwrCtrlOn);
> diff --git a/drivers/staging/r8188eu/include/hal_intf.h b/drivers/staging/r8188eu/include/hal_intf.h
> index cc8db98cd200..f1ebb6a2395d 100644
> --- a/drivers/staging/r8188eu/include/hal_intf.h
> +++ b/drivers/staging/r8188eu/include/hal_intf.h
> @@ -84,7 +84,6 @@ enum hw_variables {
> HW_VAR_EFUSE_BT_USAGE,
> HW_VAR_EFUSE_BT_BYTES,
> HW_VAR_FIFO_CLEARN_UP,
> - HW_VAR_CHECK_TXBUF,
> HW_VAR_APFM_ON_MAC, /* Auto FSM to Turn On, include clock, isolation,
> * power control for MAC only */
> /* The valid upper nav range for the HW updating, if the true value is
>
Looks good to me.
Acked-by: Michael Straube <straube.linux@gmail.com>
Thanks,
Michael
prev parent reply other threads:[~2021-09-18 15:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-18 14:10 Martin Kaiser
2021-09-18 15:20 ` Michael Straube [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9eb9d781-8603-4e0d-ecc3-4bd7e4808c0b@gmail.com \
--to=straube.linux@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=martin@kaiser.cx \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome