From: Bart Van Assche <bvanassche@acm.org>
To: Avri Altman <avri.altman@wdc.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] scsi: ufs: critical health condition
Date: Wed, 5 Feb 2025 10:00:54 -0800 [thread overview]
Message-ID: <9ebbd6d9-149f-43cb-b188-bd3a6125654f@acm.org> (raw)
In-Reply-To: <20250204143124.1252912-1-avri.altman@wdc.com>
On 2/4/25 6:31 AM, Avri Altman wrote:
> +static ssize_t critical_health_show(struct device *dev,
> + struct device_attribute *attr, char *buf)
> +{
> + struct ufs_hba *hba = dev_get_drvdata(dev);
> +
> + return sysfs_emit(buf, "%d\n", hba->dev_info.critical_health);
> +}
Hi Avri,
My understanding is that the UFS 4.1 standard supports reporting a
critical health event repeatedly while this patch does not allow users
to figure out whether a critical event has been reported once or
repeatedly. Has it been considered to report the number of times a
critical health event has been reported by a UFS device instead of only
one bit of information?
Thanks,
Bart.
next prev parent reply other threads:[~2025-02-05 18:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-04 14:31 Avri Altman
2025-02-05 18:00 ` Bart Van Assche [this message]
2025-02-05 18:04 ` Avri Altman
2025-02-05 19:07 ` Avri Altman
2025-02-06 8:54 ` Avri Altman
2025-02-06 15:54 ` Bart Van Assche
2025-02-06 17:47 ` Avri Altman
2025-02-06 18:08 ` Bart Van Assche
2025-02-06 18:25 ` Avri Altman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ebbd6d9-149f-43cb-b188-bd3a6125654f@acm.org \
--to=bvanassche@acm.org \
--cc=avri.altman@wdc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®