From: Carlo Caione <ccaione@baylibre.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
neil.armstrong@linaro.org, Daniel Vetter <daniel@ffwll.ch>,
Jerome Brunet <jbrunet@baylibre.com>,
David Airlie <airlied@gmail.com>,
Kamlesh Gurudasani <kamlesh.gurudasani@gmail.com>,
Mark Brown <broonie@kernel.org>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Kevin Hilman <khilman@baylibre.com>
Cc: linux-amlogic@lists.infradead.org,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] drm/tiny: ili9486: remove conflicting framebuffers
Date: Tue, 6 Dec 2022 14:00:51 +0100 [thread overview]
Message-ID: <9ec0204d-ca4c-afd9-33d6-1ebaaaf6b144@baylibre.com> (raw)
In-Reply-To: <c460bbda-6e9d-24e8-eb73-2e7207958deb@suse.de>
On 06/12/2022 10:52, Thomas Zimmermann wrote:
>> Conflicting framebuffer on the SPI display ? How is that possible ?
>
> Calling drm_aperture_remove_framebuffers() is only required if the
> graphics card may have been pre-initialized by the system, such as a
> VGA-compatible card on a PC.
>
> Could the SPI display have been initialized by the firmware? If not, the
> call should be left out.
What's happening on this board is that the builtin simpledrm driver is
creating fb0 backed by the framebuffer prepared by u-boot / grub, and
this the framebuffer being used by fbcon at early boot.
When the ILI9486 DRM driver is probed later during boot a second
framebuffer is created (fb1) and when fb0 is destroyed, fbcon still
remains attached to a non-existent framebuffer, so the user is left in
the dark.
What this patch is doing is that when the ILI driver is probed, fb0 is
destroyed and a new DRM-backed fb0 is created by the ILI DRM driver that
can be used by fbcon, so the user can correctly see the console on the
SPI display.
Cheers,
--
Carlo Caione
next prev parent reply other threads:[~2022-12-06 13:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 8:34 [PATCH v3 0/3] Make ILI9486 driver working with 16-bits SPI controllers Carlo Caione
2022-12-06 8:34 ` [PATCH v3 1/3] drm/tiny: ili9486: Enable driver module autoloading Carlo Caione
2022-12-06 8:34 ` [PATCH v3 2/3] drm/tiny: ili9486: Do not assume 8-bit only SPI controllers Carlo Caione
2022-12-06 8:34 ` [PATCH v3 3/3] drm/tiny: ili9486: remove conflicting framebuffers Carlo Caione
2022-12-06 9:41 ` Neil Armstrong
2022-12-06 9:52 ` Thomas Zimmermann
2022-12-06 13:00 ` Carlo Caione [this message]
2022-12-06 14:14 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ec0204d-ca4c-afd9-33d6-1ebaaaf6b144@baylibre.com \
--to=ccaione@baylibre.com \
--cc=airlied@gmail.com \
--cc=broonie@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jbrunet@baylibre.com \
--cc=kamlesh.gurudasani@gmail.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®