From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941745AbdAGTy1 (ORCPT ); Sat, 7 Jan 2017 14:54:27 -0500 Received: from mout.web.de ([212.227.15.4]:64041 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751998AbdAGTyS (ORCPT ); Sat, 7 Jan 2017 14:54:18 -0500 Subject: [PATCH 2/9] memstick: Use kmalloc_array() in msb_ftl_initialize() To: Maxim Levitsky , kernel-janitors@vger.kernel.org References: <64dfa775-4e4a-bdb0-7b55-41f43ccdf11a@users.sourceforge.net> Cc: LKML From: SF Markus Elfring Message-ID: <9ec869d3-00f2-494f-850a-d22f344e8abb@users.sourceforge.net> Date: Sat, 7 Jan 2017 20:54:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <64dfa775-4e4a-bdb0-7b55-41f43ccdf11a@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:UqkDerXCGkj2eN2rWo9otQ53HILdDIugd4xMYR6WjNHEszWvVvd PYJOLPi1b9bxhjH7D8pgWZDb9AQLEtfKfRXm2x+5PZArTg05uYDxT+DCCkgqf25bgkpFCMn WkYP7J8+R40Fs9IdUYp05EIbH2oUfHoRDKPqH0noDXMXtiDoUvdoW33aUxfOhCwkxrPtOlI 4NWvKAvXYaRSD9+7XUVEQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:oIQCSv1ai/Q=:fiEaz0zQ4DmiLBDcVM+2aZ LpgAuTDsOxpI8/HxU6r+l1mBV9O4dy2aEzEJmkxVR5XHNWHXm9Iw/SUnpfvZFPv4iN4AVxcW3 YmEPT6/BQZXP4Xu5voDinJiaVEIZtGMs9BHcoqPEHqK+hGBT3DhBCtxMxM1GLQAmuwYLht0mv WUNP1zyMi3JDc0esxB9uOZ5CN/e/zDr4w7upqf/HDnvT2ITKY+NfL0DdLqIsr9pdh3aRFCF2k QJ5E0R9BNQ8qdGKsvmVeCWoTiVSIf9RzrsV+7rub0M3KZAh9/agVKdoBOQwsc+1Jouvt1XM54 ZQlrSCCxZV5HCcN9w1mHIMrYMIrMPgHd8XkTa4kTZZSxNCyjxoh+OfRiyp+CszbkqXZ5trfAK ZlHjhKKlsXawiCjvNFhODWcalVVM079pLJC/r/TJl4ZSR+an+e2XgiddmdFoyJMKqM19qrErC SdU1lSU6aTA0J4uciBXiZzSHDDeFpLKLRuXB7ALKaEfrdjcoHqL66B+03zcaTlWv0uHo/hvyd aZTcAYRuV3X6DSpfKN9rdWDOO9s2dWxjTgK2toAYkqRVld2BkFyxLu7uxxIavqbegUMygwr1/ Ank+KNHqSyPC4J1UrKYjZO1xda/B+stlbgMYBXfF5EjZGtnuCAHPozbDqaBVhmWTS3XyrP6Gw wGDYm4xHytktnGe3zgRoedms+f50fZxFt2Wiz7ZWFQxa055BrFmjOGuiO5Wp8hnTv/M7/2CIB CbF9q0V5iXKVCP4ARQQ+NvlSe+tiWUa9BB/oTvUzUiuk4nU6FiMVc+ovnTS+kWZMWDPsQai4n uaHpUSV Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 7 Jan 2017 09:15:27 +0100 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. * Replace the specification of a data type by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/memstick/core/ms_block.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/memstick/core/ms_block.c b/drivers/memstick/core/ms_block.c index fd8b1697a5a2..ec17885a5956 100644 --- a/drivers/memstick/core/ms_block.c +++ b/drivers/memstick/core/ms_block.c @@ -1346,8 +1346,9 @@ static int msb_ftl_initialize(struct msb_data *msb) if (!msb->erased_blocks_bitmap) goto free_used_bitmap; - msb->lba_to_pba_table = - kmalloc(msb->logical_block_count * sizeof(u16), GFP_KERNEL); + msb->lba_to_pba_table = kmalloc_array(msb->logical_block_count, + sizeof(*msb->lba_to_pba_table), + GFP_KERNEL); if (!msb->lba_to_pba_table) goto free_erased_bitmap; -- 2.11.0