From: Andrew Lunn <andrew@lunn.ch>
To: Justin Chen <justin.chen@broadcom.com>
Cc: netdev@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Daniil Tatianin <d-tatianin@yandex-team.ru>,
Marco Bonelli <marco@mebeim.net>,
Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
Maxim Korotkov <korotkov.maxim.s@gmail.com>,
Gal Pressman <gal@nvidia.com>, Jiri Pirko <jiri@resnulli.us>,
Kuniyuki Iwashima <kuniyu@amazon.com>,
Simon Horman <simon.horman@corigine.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] ethtool: ioctl: account for sopass diff in set_wol
Date: Tue, 13 Jun 2023 00:28:51 +0200 [thread overview]
Message-ID: <9ec8eac3-6b2f-4455-89ef-2d5768b4cee9@lunn.ch> (raw)
In-Reply-To: <1686605822-34544-1-git-send-email-justin.chen@broadcom.com>
On Mon, Jun 12, 2023 at 02:37:00PM -0700, Justin Chen wrote:
> sopass won't be set if wolopt doesn't change. This means the following
> will fail to set the correct sopass.
> ethtool -s eth0 wol s sopass 11:22:33:44:55:66
> ethtool -s eth0 wol s sopass 22:44:55:66:77:88
>
> Make sure we call into the driver layer set_wol if sopass is different.
>
> Fixes: 55b24334c0f2 ("ethtool: ioctl: improve error checking for set_wol")
> Signed-off-by: Justin Chen <justin.chen@broadcom.com>
> ---
>
> Note: Tagged "Fixes" patch has not hit rc yet.
>
> net/ethtool/ioctl.c | 3 ++-
Hi Justin
Does the netlink version get this correct?
And just for my own curiosity, why are you so interested in the ioctl
version, which is deprecated and not used by modern versions of
ethtool?
Andrew
next prev parent reply other threads:[~2023-06-12 22:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-12 21:37 Justin Chen
2023-06-12 22:28 ` Andrew Lunn [this message]
2023-06-12 23:00 ` Justin Chen
2023-06-14 5:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ec8eac3-6b2f-4455-89ef-2d5768b4cee9@lunn.ch \
--to=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=d-tatianin@yandex-team.ru \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=gal@nvidia.com \
--cc=jiri@resnulli.us \
--cc=justin.chen@broadcom.com \
--cc=korotkov.maxim.s@gmail.com \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=marco@mebeim.net \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®