From: Jaehoon Chung <jh80.chung@samsung.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, kgene@kernel.org,
cw00.choi@samsung.com, robh+dt@kernel.org, mark.rutland@arm.com,
catalin.marinas@arm.com, will.deacon@arm.com,
m.szyprowski@samsung.com, a.hajda@samsung.com,
jy0922.shim@samsung.com
Subject: Re: [PATCH] ARM: dts: exynos: remove the cd-gpios property for eMMC of odroid-xu3/4
Date: Tue, 22 Nov 2016 10:24:21 +0900 [thread overview]
Message-ID: <9ecce088-b91d-d51a-5a19-33476961d2ea@samsung.com> (raw)
In-Reply-To: <20161121170605.GA8181@kozik-lap>
On 11/22/2016 02:06 AM, Krzysztof Kozlowski wrote:
> On Mon, Nov 21, 2016 at 04:10:32PM +0900, Jaehoon Chung wrote:
>> Odroid-xu3/4 didn't need to use the cd-gpios for detecting card.
>> Because Host controller has the CDETECT register through SDx_CDN line.
>> Host controller can know whether card is inserted or not with this
>> register.
>>
>> When i have checked the Odroid-xu3/4, they are using CDETECT register.
>> (Not using exteranl cd-gpio.)
>
> Makes sense. Just one question: the sd0_cd pinctrl setting should stay,
> right?
Right, It needs to use SD0_CD function.
I have tested on Odroid-XU3/XU4.
Tested with the below cases.
1) On boot with SD-card (without eMMC)
- Inserted eMMC : Detected
- Removed eMMC : Detected
2) On boot with Sd-card (with eMMC)
- Detected
3) On boot with eMMC
- Detected
Best Regards,
Jaehoon Chung
>
> Best regards,
> Krzysztof
>
>> Fixes: fb1aeedb61ad ("ARM: dts: add mmc detect gpio for exynos5422-odroidxu3")
>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>> ---
>> arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
>> index 9e63328..05b9afdd 100644
>> --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
>> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
>> @@ -510,7 +510,6 @@
>> &mmc_0 {
>> status = "okay";
>> mmc-pwrseq = <&emmc_pwrseq>;
>> - cd-gpios = <&gpc0 2 GPIO_ACTIVE_LOW>;
>> card-detect-delay = <200>;
>> samsung,dw-mshc-ciu-div = <3>;
>> samsung,dw-mshc-sdr-timing = <0 4>;
>> --
>> 2.10.1
>>
>
>
>
next prev parent reply other threads:[~2016-11-22 1:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-21 7:10 Jaehoon Chung
2016-11-21 17:06 ` Krzysztof Kozlowski
2016-11-22 1:24 ` Jaehoon Chung [this message]
2016-11-22 7:51 ` Andrzej Hajda
2016-11-22 8:19 ` Jaehoon Chung
2016-11-23 17:20 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ecce088-b91d-d51a-5a19-33476961d2ea@samsung.com \
--to=jh80.chung@samsung.com \
--cc=a.hajda@samsung.com \
--cc=catalin.marinas@arm.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=jy0922.shim@samsung.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®