From: Joe Perches <coupons@perches.com>
To: Nicolai Fischer <nicolai.fischer@fau.de>, linux-kernel@vger.kernel.org
Cc: apw@canonical.com, johannes.czekay@fau.de,
linux-kernel@i4.cs.fau.de, akpm@linux-foundation.org
Subject: Re: [PATCH 2/2] checkpatch: kconfig: add missing types to regex
Date: Fri, 25 Dec 2020 09:42:12 -0800 [thread overview]
Message-ID: <9ece49fa7b0025d1d639859082f0408bbe5f4f49.camel@perches.com> (raw)
In-Reply-To: <4899798f-46b9-32ee-4d1e-ab2b5833da08@fau.de>
On Fri, 2020-12-25 at 18:27 +0100, Nicolai Fischer wrote:
> On 12/21/20 6:17 PM, Joe Perches wrote:
[]
> > The message you used:
> > + WARN("CONFIG_DESCRIPTION",
> > + "help text is not indented 2 spaces more than the help keyword\n" . $herecurr);
> >
> > is IMO a bit oddly phrased and could/should test only
> > the first line after the help keyword and show the help
> > line using $hereprev.
> >
> > The problem with $herecurr is, that it always contains the first line of the Kconfig option.
> The loop which actually determines if the warning is to be displayed, leaves $herecurr and likewise $hereprev unaffected.
>
> So printing $hereprev would unfortunately not be any more helpful than $herecurr.
> Because $herecurr and $hereprev also contain the line number, among other things, I am not sure what would be the best way
> to address this.
There is a mechanism to create an output message block: get_stat_real
that could be used.
prev parent reply other threads:[~2020-12-25 17:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 10:24 Nicolai Fischer
2020-12-20 19:12 ` Joe Perches
2020-12-20 19:16 ` Joe Perches
2020-12-21 15:08 ` Nicolai Fischer
2020-12-21 17:17 ` Joe Perches
2020-12-25 17:27 ` Nicolai Fischer
2020-12-25 17:42 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ece49fa7b0025d1d639859082f0408bbe5f4f49.camel@perches.com \
--to=coupons@perches.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=johannes.czekay@fau.de \
--cc=linux-kernel@i4.cs.fau.de \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolai.fischer@fau.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®