From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A5733F58EB for ; Tue, 26 May 2026 12:25:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779798314; cv=none; b=NBLVntvFgKHivfOjqtethcE4Wikr/7zTzAFexM0Bggc8b4dmGKLGWXd3P6l62duWTaB1/GseptbXb7RgNgX74D0vK/zLRx8qYjjwvyyvI6DGZVsq7iFZwRZ3MrrsGY2feRtXNY5iyE2ahf58Ui4LiV3MUzZr909TzMLGbUu6hDQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779798314; c=relaxed/simple; bh=OBdNDmdFyX3Btzx0luHZFVbkPIZYv5WwtCm4c5mXnnk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BYou7XJXV6ufbRZuKe/krNDWbYEvSwGrHCoY2ChEHEQNOdj4mPt4bcpgXTIN8GMI6d8fp1khaFWsF9Gwe1NtAlbDUMOJyPAaEwcRZmSjmgKGDAd+ehBfMZeZSYj9Swdb4er1v7gyxjZoRIDrMEBQFFB3hWAkcCQrJjCuMYUSJYA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=vLWZ+Thk; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vLWZ+Thk" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-459bf19e87bso6203394f8f.1 for ; Tue, 26 May 2026 05:25:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1779798311; x=1780403111; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jgI53DJMq4E1/u2WXvBPkXuolOc+9wuhSnRSjksHASg=; b=vLWZ+ThkhFXsC8LKnSTk2ErfnJnZyY6y9PnwFfvGAO7w9sU9mJIqgXeSeV1TnIDUTE TNLsVyv01kkVJmeLml9elRJgJxRnCZgAFN/EbuO89QXYoLuLclXk1MxiueOnBvUeJ4cV jzgyrCxj529GO7l6U6qtrqHjBJ40RRkyLaOmzodRZRYN9YryNIDE5EB8rxQFSRccAID4 22y78XIgzVNP/Px1ORKXRZC12ekjTxSLMfMU7GPEG/EGP7xZPJlb106IPbJOAmjmOnzG ISpsvhVohX+sp5gWfF+PqjQwGzNRNGc0NLY0jg7xdQFW9yVFxjHhK6LDqZVq8661pFYv KicA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779798311; x=1780403111; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jgI53DJMq4E1/u2WXvBPkXuolOc+9wuhSnRSjksHASg=; b=lhRAsiV7OLHg3R7LuFUkXQvvGz52MpP8m5Y3lMB16Kg2d1LvQp1CWCXvaVafqSj3PV 8jd8nikf3+/UoIh/qHzow5/i6t41dg8r+7feknYYciGv6d2q830ZHxYGm+KRsIpyBSM/ 6/rSV3P6vulzHJfma68+AFqKihGrCPqSDNmv6QCh/M4DWuP1TON4Af8Mxd2ZNq4PECf3 oONVNY1xRwqJcvrUugPKFpJnf+n3kykTgThTtMPOUFVV9ga3fpTPeeshzJVJRhLWmHeS /aY0iyG0GMwEmM0FopycCBp9bngawo6SEO/4u7xvw5ipRJzN/UuvJPNqLN9oQJRS3AkK 3ioA== X-Forwarded-Encrypted: i=1; AFNElJ/3RjAllzEPn2HjJRpK5x+vDLw4VjayDSpt9KS0WYYzSF9QSQehP3xR1cVr3Um8bHq79Ch628NcePBsrEc=@vger.kernel.org X-Gm-Message-State: AOJu0YzScyz9Od3uXYOAbjgxPwm42dyHZ+89dnAV8dJC936XnTlm+mzd EzlGx+EJ16IFNjjXI+0RH2ChEopVrfx+KwN1CuxdDYic1VPm4RcnbGNSXgvjkh0n4mc= X-Gm-Gg: Acq92OGiXfVG4JbnIVi2I+4x1G4RtzdYj/BAS+5qy6bPXDgnl7+KuSlnhnmFNAR03dl VGGuFKoOKRB18ld2Fq1xorkhP0KZjzrjpzlC/danERqhH/cIU+xj5K+YTABuWrX3uauQNhZ8KsU aX7BTL+RKm0SnyI79BIeWFSUjGig8DgIia4c+Q8Hns4KNBQZRhdyLgIQSmgeRZcGv7M3kCxBRAE 2cMXcU11PtX2zpJO8CNn6PzYoaPQslObJh398iYQJMDx56a5nwHkqkmNA5zlLrSNU5kWMojUR5X IrWf2dyvBmUHCgxeRnbUxU1Mg4bsRQGeH2c7sghyKiATj/z1A8jRyscpWAaJ+Hk9pNcKrPJmKtT Ww61nLypBfDGhz5TBD9XYVQpHQor4FIhe/UgtQtwrP5re5uYmTFAOKXkc1KdqnsVJIK2J4CjqAa 5QEWLKa3s7FerKx7C6vKl+YHkLGOWN+HIj+JDGfXTrXPg= X-Received: by 2002:a05:6000:2412:b0:44f:9b70:2996 with SMTP id ffacd0b85a97d-45eb38c53bamr33323679f8f.21.1779798311332; Tue, 26 May 2026 05:25:11 -0700 (PDT) Received: from [10.149.200.45] ([89.101.53.6]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45ed1939c6asm14041928f8f.2.2026.05.26.05.25.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 May 2026 05:25:10 -0700 (PDT) Message-ID: <9ececc65-d2d4-4310-9218-beaeb5496dca@linaro.org> Date: Tue, 26 May 2026 13:25:03 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] arm64: dts: qcom: x1e80100-lenovo-yoga-slim7x: Add Embedded Controller node To: Daniel J Blueman , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Sibi Sankar , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans de Goede , Randy Dunlap , Bjorn Andersson , linux-kernel@vger.kernel.org, Anvesh Jain P , Maya Matuszczyk , Krzysztof Kozlowski , Dmitry Baryshkov , Akhil P Oommen , Abel Vesa , Gaurav Kohli References: <20260526112409.66325-1-daniel@quora.org> <20260526112409.66325-2-daniel@quora.org> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20260526112409.66325-2-daniel@quora.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 26/05/2026 12:24, Daniel J Blueman wrote: > The Lenovo Slim7x uses the same Embedded Controller as the Qualcomm Hamoa > X1 Customer Reference Device. Use the lenovo,yoga-slim7x-ec compatible > introduced by patch 1 for fan control, thermal sensor and suspend > behaviour. > > Signed-off-by: Daniel J Blueman > --- > Changes in v3: > - use lenovo,yoga-slim7x-ec compatible (introduced by patch 1) > - v2 link: https://lore.kernel.org/lkml/20260502063518.15153-1-daniel@quora.org/ > Changes in v2: > - corrected DT compatible node > - v1 link: https://lore.kernel.org/all/20260429103301.17449-1-daniel@quora.org/ > > .../dts/qcom/x1e80100-lenovo-yoga-slim7x.dts | 22 +++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts > index beb1475d7fa0..1ee2a2296129 100644 > --- a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts > +++ b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts > @@ -951,6 +951,22 @@ retimer_ss0_con_sbu_out: endpoint { > }; > }; > > +&i2c5 { > + clock-frequency = <400000>; > + > + status = "okay"; > + > + embedded-controller@76 { > + compatible = "lenovo,yoga-slim7x-ec", "qcom,hamoa-crd-ec"; > + reg = <0x76>; > + > + interrupts-extended = <&tlmm 66 IRQ_TYPE_EDGE_FALLING>; > + > + pinctrl-0 = <&ec_int_n_default>; > + pinctrl-names = "default"; > + }; > +}; > + > &i2c7 { > clock-frequency = <400000>; > > @@ -1352,6 +1368,12 @@ &tlmm { > <44 4>, /* SPI (TPM) */ > <238 1>; /* UFS Reset */ > > + ec_int_n_default: ec-int-n-state { > + pins = "gpio66"; > + function = "gpio"; > + bias-disable; > + }; > + > edp_reg_en: edp-reg-en-state { > pins = "gpio70"; > function = "gpio"; Reviewed-by: Bryan O'Donoghue --- bod