From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C8EBC001DC for ; Wed, 12 Jul 2023 01:26:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231359AbjGLB0V (ORCPT ); Tue, 11 Jul 2023 21:26:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52940 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229531AbjGLB0T (ORCPT ); Tue, 11 Jul 2023 21:26:19 -0400 Received: from mail.nfschina.com (unknown [42.101.60.195]) by lindbergh.monkeyblade.net (Postfix) with SMTP id 210CF95; Tue, 11 Jul 2023 18:26:17 -0700 (PDT) Received: from [172.30.11.106] (unknown [180.167.10.98]) by mail.nfschina.com (Maildata Gateway V2.8.8) with ESMTPSA id 90915605D3D97; Wed, 12 Jul 2023 09:26:13 +0800 (CST) Message-ID: <9ecfc762-9860-c880-b3f3-5652e4dc58f5@nfschina.com> Date: Wed, 12 Jul 2023 09:26:13 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH] drm/virtio: remove some redundant code Content-Language: en-US To: Markus Elfring Cc: LKML , dri-devel@lists.freedesktop.org, Gerd Hoffmann , Dave Airlie , virtualization@lists.linux-foundation.org, Gurchetan Singh , Daniel Vetter , kernel-janitors@vger.kernel.org, Chia-I Wu X-MD-Sfrom: suhui@nfschina.com X-MD-SrcIP: 180.167.10.98 From: Su Hui In-Reply-To: <6baf8384-af7a-06e1-6f91-8c4e8aa65197@web.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/7/11 17:33, Markus Elfring wrote: >> virtio_gpu_get_vbuf always be successful, >> so remove the error judgment. > How do you think about to improve this change description any more? Hi, virtio_gpu_get_vbuf use "__GFP_NOFAIL" flag to allocate memory, this make sure it won't fail, and virtio_gpu_get_vbuf never return error code, so remove the error judgment. How about this one? Thanks for your advice. Su Hui > Regards, > Markus