From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7B34C2BA12 for ; Thu, 2 Apr 2020 14:43:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9876E2073B for ; Thu, 2 Apr 2020 14:43:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388627AbgDBOnJ (ORCPT ); Thu, 2 Apr 2020 10:43:09 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:43896 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726927AbgDBOnJ (ORCPT ); Thu, 2 Apr 2020 10:43:09 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: koike) with ESMTPSA id AB09328CF7C Subject: Re: [PATCH 1/4] dt-bindings: phy: phy-rockchip-dphy-rx0: move rockchip dphy rx0 bindings out of staging To: Johan Jonker Cc: dafna.hirschfeld@collabora.com, devel@driverdev.osuosl.org, devicetree@vger.kernel.org, ezequiel@collabora.com, heiko@sntech.de, hverkuil-cisco@xs4all.nl, karthik.poduval@gmail.com, kernel@collabora.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, mark.rutland@arm.com, robh+dt@kernel.org References: <20200402000234.226466-2-helen.koike@collabora.com> From: Helen Koike Message-ID: <9ed2142a-bd22-fbb6-cd65-7d727751400e@collabora.com> Date: Thu, 2 Apr 2020 11:42:57 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Johan, On 4/2/20 9:16 AM, Johan Jonker wrote: > Hi Helen, > >> # SPDX-License-Identifier: (GPL-2.0+ OR MIT) >> %YAML 1.2 >> --- >> $id: http://devicetree.org/schemas/phy/rockchip-mipi-dphy-rx0.yaml# >> $schema: http://devicetree.org/meta-schemas/core.yaml# >> >> title: Rockchip SoC MIPI RX0 D-PHY Device Tree Bindings >> >> maintainers: >> - Helen Koike >> - Ezequiel Garcia >> >> description: | >> The Rockchip SoC has a MIPI D-PHY bus with an RX0 entry which connects to >> the ISP1 (Image Signal Processing unit v1.0) for CSI cameras. >> >> properties: >> compatible: >> const: rockchip,rk3399-mipi-dphy-rx0 >> > >> reg: >> maxItems: 1 > > If 'reg' is not used => remove it. ok, I'll add a patch removing it. Thanks, Helen > >> >> clocks: >> items: >> - description: MIPI D-PHY ref clock >> - description: MIPI D-PHY RX0 cfg clock >> - description: Video in/out general register file clock >> >> clock-names: >> items: >> - const: dphy-ref >> - const: dphy-cfg >> - const: grf >> >> '#phy-cells': >> const: 0 >> >> power-domains: >> description: Video in/out power domain. >> maxItems: 1 >> >> required: >> - compatible >> - clocks >> - clock-names >> - '#phy-cells' >> - power-domains >> >> additionalProperties: false >> >> examples: >> - | >> >> /* >> * MIPI D-PHY RX0 use registers in "general register files", it >> * should be a child of the GRF. >> * >> * grf: syscon@ff770000 { >> * compatible = "rockchip,rk3399-grf", "syscon", "simple-mfd"; >> * ... >> * }; >> */ >> >> #include >> #include >> >> mipi_dphy_rx0: mipi-dphy-rx0 { >> compatible = "rockchip,rk3399-mipi-dphy-rx0"; >> clocks = <&cru SCLK_MIPIDPHY_REF>, >> <&cru SCLK_DPHY_RX0_CFG>, >> <&cru PCLK_VIO_GRF>; >> clock-names = "dphy-ref", "dphy-cfg", "grf"; >> power-domains = <&power RK3399_PD_VIO>; >> #phy-cells = <0>; >> };