From: "yukuai (C)" <yukuai3@huawei.com>
To: Jens Axboe <axboe@kernel.dk>, <paolo.valente@linaro.org>, <jack@suse.cz>
Cc: <linux-block@vger.kernel.org>, <cgroups@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <yi.zhang@huawei.com>
Subject: Re: [PATCH v3 0/3] block, bfq: minor cleanup and fix
Date: Sat, 29 Jan 2022 10:05:26 +0800 [thread overview]
Message-ID: <9ed6bf05-4c31-eef1-1736-65915e55eb8e@huawei.com> (raw)
In-Reply-To: <7cb40388-02e9-712a-6a40-ccabd5605880@kernel.dk>
在 2022/01/29 9:51, Jens Axboe 写道:
> On 1/28/22 6:59 PM, Yu Kuai wrote:
>> Changes in v3:
>> - fix a clerical error in patch 2
>>
>> Chagnes in v2:
>> - add comment in patch 2
>> - remove patch 4, since the problem do not exist.
>>
>> Yu Kuai (3):
>> block, bfq: cleanup bfq_bfqq_to_bfqg()
>> block, bfq: avoid moving bfqq to it's parent bfqg
>> block, bfq: don't move oom_bfqq
>>
>> block/bfq-cgroup.c | 16 +++++++++++++++-
>> block/bfq-iosched.c | 4 ++--
>> block/bfq-iosched.h | 1 -
>> block/bfq-wf2q.c | 15 ---------------
>> 4 files changed, 17 insertions(+), 19 deletions(-)
>
> I'm not even looking at this until you tell me that:
>
> a) you've actually compiled this one. which, btw, I can't believe
> needs mentioning, particularly when you had enough time to keep
> pinging about this patchset.
>
> b) it's actually be run. last one was clearly not.
>
Hi,
I compiled and tested the patchset locally in a different version,
v4.19 specifically. However, after I decide to send them to mainline,
I made such clerical mistake and forgot to check the patches.
My sincerely apologize again...
Kuai
next prev parent reply other threads:[~2022-01-29 2:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-29 1:59 Yu Kuai
2022-01-29 1:51 ` Jens Axboe
2022-01-29 2:05 ` yukuai (C) [this message]
2022-02-10 11:46 ` yukuai (C)
2022-02-18 8:30 ` yukuai (C)
2022-01-29 1:59 ` [PATCH v3 1/3] block, bfq: cleanup bfq_bfqq_to_bfqg() Yu Kuai
2022-01-29 1:59 ` [PATCH v3 2/3] block, bfq: avoid moving bfqq to it's parent bfqg Yu Kuai
2022-02-08 3:53 ` yukuai (C)
2022-02-08 16:07 ` Paolo Valente
2022-01-29 1:59 ` [PATCH v3 3/3] block, bfq: don't move oom_bfqq Yu Kuai
2022-02-18 13:13 ` [PATCH v3 0/3] block, bfq: minor cleanup and fix Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ed6bf05-4c31-eef1-1736-65915e55eb8e@huawei.com \
--to=yukuai3@huawei.com \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paolo.valente@linaro.org \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®