From: Robin Murphy <robin.murphy@arm.com>
To: Sudeep Holla <sudeep.holla@arm.com>,
Jeffy Chen <jeffy.chen@rock-chips.com>
Cc: linux-kernel@vger.kernel.org,
Brian Norris <briannorris@chromium.org>,
Marc Zyngier <marc.zyngier@arm.com>,
Douglas Anderson <dianders@chromium.org>,
Heiko Stuebner <heiko@sntech.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH v1] arch_topology: Adjust initial CPU capacities with current freq
Date: Fri, 10 Jan 2020 11:54:48 +0000 [thread overview]
Message-ID: <9edb57be-97bc-f0bd-3edd-854dfc8c780f@arm.com> (raw)
In-Reply-To: <20200110113711.GB39451@bogus>
On 2020-01-10 11:37 am, Sudeep Holla wrote:
> On Thu, Jan 09, 2020 at 03:52:14PM +0800, Jeffy Chen wrote:
>> The CPU freqs are not supposed to change before cpufreq policies
>> properly registered, meaning that they should be used to calculate the
>> initial CPU capacities.
>>
>> Doing this helps choosing the best CPU during early boot, especially
>> for the initramfs decompressing.
>>
>> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
>
> [...]
>
>> @@ -146,10 +153,15 @@ bool __init topology_parse_cpu_capacity(struct device_node *cpu_node, int cpu)
>> return false;
>> }
>> }
>> - capacity_scale = max(cpu_capacity, capacity_scale);
>> raw_capacity[cpu] = cpu_capacity;
>> pr_debug("cpu_capacity: %pOF cpu_capacity=%u (raw)\n",
>> cpu_node, raw_capacity[cpu]);
>> +
>> + cpu_clk = of_clk_get(cpu_node, 0);
>> + if (!PTR_ERR_OR_ZERO(cpu_clk))
>> + per_cpu(max_freq, cpu) = clk_get_rate(cpu_clk) / 1000;
>> +
>> + clk_put(cpu_clk);
>
> I don't like to assume DVFS to be supplied only using 'clk'. So NACK!
> We have other non-clk mechanism for CPU DVFS and this needs to simply
> use cpufreq APIs to get frequency value if required.
...but in this case, as soon as cpufreq is ready the problem is gone
anyway, because it sees the big cluster's clock rate is way out-of-spec
and bumps it up to a sane OPP.
It really is unfortunate that so many RK3399 images out there are using
the broken firmware combination that manages to miss out the boot-time
PLL setup altogether.
Robin.
next prev parent reply other threads:[~2020-01-10 11:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 7:52 Jeffy Chen
2020-01-10 11:37 ` Sudeep Holla
2020-01-10 11:54 ` Robin Murphy [this message]
2020-01-10 12:01 ` Dietmar Eggemann
2020-01-10 12:28 ` Robin Murphy
2020-01-11 2:51 ` JeffyChen
2020-01-11 15:12 ` Robin Murphy
2020-01-13 3:59 ` JeffyChen
2020-01-10 14:03 ` kbuild test robot
2020-01-10 14:45 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9edb57be-97bc-f0bd-3edd-854dfc8c780f@arm.com \
--to=robin.murphy@arm.com \
--cc=briannorris@chromium.org \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=jeffy.chen@rock-chips.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=rafael@kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®