From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C02B5C433F5 for ; Mon, 30 May 2022 02:35:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232272AbiE3CfS (ORCPT ); Sun, 29 May 2022 22:35:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230488AbiE3CfQ (ORCPT ); Sun, 29 May 2022 22:35:16 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9662272E17; Sun, 29 May 2022 19:35:15 -0700 (PDT) Received: from dggpeml500020.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4LBKGS6xxyzbbYT; Mon, 30 May 2022 10:33:36 +0800 (CST) Received: from [10.174.177.174] (10.174.177.174) by dggpeml500020.china.huawei.com (7.185.36.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 30 May 2022 10:35:13 +0800 Message-ID: <9ee160e1-a0e7-1d7f-040f-1bcaa581ecd1@huawei.com> Date: Mon, 30 May 2022 10:35:13 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v3 3/3] ext4: support flex_bg in ext4_mb_normalize_request To: Ritesh Harjani CC: , , , , , , , , , Baokun Li References: <20220528110017.354175-1-libaokun1@huawei.com> <20220528110017.354175-4-libaokun1@huawei.com> <20220528150906.om746qfxoxu7svzx@riteshh-domain> From: Baokun Li In-Reply-To: <20220528150906.om746qfxoxu7svzx@riteshh-domain> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.174] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpeml500020.china.huawei.com (7.185.36.88) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2022/5/28 23:09, Ritesh Harjani 写道: > On 22/05/28 07:00PM, Baokun Li wrote: >> In ext4_mb_normalize_request, the size of the allocation request is >> limited to no more than EXT4_BLOCKS_PER_GROUP. Ritesh mentions that this >> does not take into account the case of flex_bg groups. So we should add >> support for flex_bg to make the physical blocks of large files contiguous. > My only concern here was that what if we are at the flex group end boundary and > decide to take the size as of flex group size. How are we detecting that case. > > But, I haven't yet looked at this patch of yours (as I am on travel for next few days), > but if this requires further discussion, we can work on this seperately and let > the other two patches go in as those are part of the bug fixes which you > identified (just my thoughts). > > -ritesh > . All right, work on this separately. Have a nice trip! -- With Best Regards, Baokun Li