From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f172.google.com (mail-dy1-f172.google.com [74.125.82.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD08D3AB287 for ; Wed, 1 Apr 2026 14:50:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775055013; cv=none; b=KQSnO2iG2sa5Zok0xZPyKTpIPt8Qgj138mfnbRwYoVP3zF7Jsn7XxsvIhzT6c6L4AxXUCg752qTP6+WW+599WnzPjH97qKpOlXjv+HAy8cPVdtsjShuHgMoQcWSElzjanafFEB/cfGGSrmH5Nnd+cdvMneFcXq6ZUimT07yUqSU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775055013; c=relaxed/simple; bh=HyPefaPN9C+LsoX1kV04qKd4yLFbTg3iu9tvgw1X/n8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uOt7+6PyTCEQrzLbMS1kO0w16T/tAL+l6925LbCbuYogvMbLx06lVyQlsvNreQK/NPCdBjKEsJy4tj7LFAa7qqTL/SAAhW12RZ/ySesz9OE9H+FQsgvj4qGPGd3SF7e6ac5/IiAYNHiwZORTn1Q3d9taiVGwCrF4mf4vWosyg9Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gVIw037C; arc=none smtp.client-ip=74.125.82.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gVIw037C" Received: by mail-dy1-f172.google.com with SMTP id 5a478bee46e88-2c54c68db4dso6461659eec.0 for ; Wed, 01 Apr 2026 07:50:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775055008; x=1775659808; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=adTovVGQXWP2DRbhzwnz90rChnI+nzeVyP76C0UUFdA=; b=gVIw037CWAeMiuJgPyz6XEljtnG5Y6nvkTkZdjj3HYaybBTd4wOmS3Scem1e0AvluJ HhN//KJcP9UQZrxTRg48gT1wEUtfgtln/y0zkjX2CAbWhVYsPe0p/FOgX7wTBD6YzfBg FeMoe4sjIb5qabHDBeTCNWQic4NhtmBAXTDcsrfdIBN6w9WvReYhebCvqV2ECPJTCHRL J8lTUhKBCZOJBuutOTT9GboPTMeR5FUcCdLU/xovwGG32/xuK7gycZuAx1qGj76BDfYB Vjm9nH5fi6CQJo0QUNA14xz56uQluUAm0fkEyb9vc2n8bymatv/dcTILvy5f3akwB+4q aTUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775055008; x=1775659808; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=adTovVGQXWP2DRbhzwnz90rChnI+nzeVyP76C0UUFdA=; b=nhJUqbBTeXwBbyGQrFx0WM9Qs+nZPCwpPaNsKWSJa5WlhqaunZdksbxB527B5Wfm/i nfefCJweIY7HrPALDES5dBFE8aoZjJnPfJoTrLfwkDA+tlGNnXQGoyvjrPc7rerPDoiA 9wmj+68VYsC/mbLBjBBwIC3reBJ7cMuroyszxcuizmesfs0KpAqyG0HvN5C40RWJ89XJ R4AkweuJQC9TG7s5xjEJTawNXB9s+yIbpaPSXpJuIk0CED83e14Gr1pMyk+J1AY7Fd6e q+IIEBR+bEk4dU877hUW6nJRc1lGEsjw4liiYHUX2oeGIXvOeCWSucHBfY5XdUdnziiD 0gzw== X-Forwarded-Encrypted: i=1; AJvYcCVDW5KYjpg00EkIP1lC2kKFNdaVaTPt26YqR1yZC8aJrdIjGI1sop7TBv/vQtsQJkGxExzkbl5bx7TVDZI=@vger.kernel.org X-Gm-Message-State: AOJu0Yyhp2hO9h7jiRmfTpqcgxOZoIzEeuel01HDiRj02JuY6LO6XIur 2UmfNhYKbmnnDLgUrZAtrjriGY21H6AXPyaWlB6efRv6Idch+zlNmd8+ X-Gm-Gg: ATEYQzzRbZY3khtF3Q+ZBGWWtc5K1l2zDxDXGBDjptqdR1EMWN5Bo7HPEVx7hrCT6o1 G3Y+ZzcYGct+ACjLiJSpX5iy62PING6Ohag1VBT5AvjClzlRMoc+4SHP4EGXD0qOEcOeamV+v+c OXbD6Q6b0LezyV/SFAzUCemYYN2t0I15wVbZQNMWz0hHW0PjxvbWOj3SPwysVNSpOrEubF/VnFb vEiLtodprBjrZoO10ahtLzIonXEPSONpxIzkNMgKCPlK+ZbpHTiqgeYAwxydpP6OzyXXL0ZJsem a4PPzPx9Fe4CFyJ3EIeP1GT7UnZS8rmYUnNxbST4ebuJfmBjwgZqXADoPospapaAns70nzrEo/K Wlejw9CxThDnJIAzSo3aC0D5Sk1b/3U+h8bRuihXVyW+Bks8fuDiYjoYbOKWDTIYRLkykbQQCVy m2HIpCG8gAp8T0UQhCM9rHlYTmMumtUDmKQGFJlYTly1Mog42pOXeFA98J6lf3JIC2JhMLWC1v X-Received: by 2002:a05:7300:2213:b0:2c0:becb:7640 with SMTP id 5a478bee46e88-2c931276dd6mr2288123eec.12.1775055008283; Wed, 01 Apr 2026 07:50:08 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c3c68b272esm12622956eec.15.2026.04.01.07.50.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Apr 2026 07:50:07 -0700 (PDT) Sender: Guenter Roeck Message-ID: <9ee56bb2-6f46-49de-bf01-b687bc32393e@roeck-us.net> Date: Wed, 1 Apr 2026 07:50:06 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 0/2] Add support for Texas Instruments INA4230 power monitor To: Rob Herring , Alexey Charkov Cc: Krzysztof Kozlowski , Conor Dooley , linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski References: <20260330-ina4230-v5-0-eeb322d95b3a@flipper.net> <67a5d1c1-a9c5-47fb-a0ec-5b69a991b01e@roeck-us.net> <20260331155246.GA1299761-robh@kernel.org> <20872ef8-f68c-4916-a05f-404fd49fff00@roeck-us.net> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAmgrMyQFCSbODQkACgkQyx8mb86fmYGcWRAA oRwrk7V8fULqnGGpBIjp7pvR187Yzx+lhMGUHuM5H56TFEqeVwCMLWB2x1YRolYbY4MEFlQg VUFcfeW0OknSr1s6wtrtQm0gdkolM8OcCL9ptTHOg1mmXa4YpW8QJiL0AVtbpE9BroeWGl9v 2TGILPm9mVp+GmMQgkNeCS7Jonq5f5pDUGumAMguWzMFEg+Imt9wr2YA7aGen7KPSqJeQPpj onPKhu7O/KJKkuC50ylxizHzmGx+IUSmOZxN950pZUFvVZH9CwhAAl+NYUtcF5ry/uSYG2U7 DCvpzqOryJRemKN63qt1bjF6cltsXwxjKOw6CvdjJYA3n6xCWLuJ6yk6CAy1Ukh545NhgBAs rGGVkl6TUBi0ixL3EF3RWLa9IMDcHN32r7OBhw6vbul8HqyTFZWY2ksTvlTl+qG3zV6AJuzT WdXmbcKN+TdhO5XlxVlbZoCm7ViBj1+PvIFQZCnLAhqSd/DJlhaq8fFXx1dCUPgQDcD+wo65 qulV/NijfU8bzFfEPgYP/3LP+BSAyFs33y/mdP8kbMxSCjnLEhimQMrSSo/To1Gxp5C97fw5 3m1CaMILGKCmfI1B8iA8zd8ib7t1Rg0qCwcAnvsM36SkrID32GfFbv873bNskJCHAISK3Xkz qo7IYZmjk/IJGbsiGzxUhvicwkgKE9r7a1rOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAmgrMyQFCSbODQkACgkQyx8mb86fmYHlgg/9 H5JeDmB4jsreE9Bn621wZk7NMzxy9STxiVKSh8Mq4pb+IDu1RU2iLyetCY1TiJlcxnE362kj njrfAdqyPteHM+LU59NtEbGwrfcXdQoh4XdMuPA5ADetPLma3YiRa3VsVkLwpnR7ilgwQw6u dycEaOxQ7LUXCs0JaGVVP25Z2hMkHBwx6BlW6EZLNgzGI2rswSZ7SKcsBd1IRHVf0miwIFYy j/UEfAFNW+tbtKPNn3xZTLs3quQN7GdYLh+J0XxITpBZaFOpwEKV+VS36pSLnNl0T5wm0E/y scPJ0OVY7ly5Vm1nnoH4licaU5Y1nSkFR/j2douI5P7Cj687WuNMC6CcFd6j72kRfxklOqXw zvy+2NEcXyziiLXp84130yxAKXfluax9sZhhrhKT6VrD45S6N3HxJpXQ/RY/EX35neH2/F7B RgSloce2+zWfpELyS1qRkCUTt1tlGV2p+y2BPfXzrHn2vxvbhEn1QpQ6t+85FKN8YEhJEygJ F0WaMvQMNrk9UAUziVcUkLU52NS9SXqpVg8vgrO0JKx97IXFPcNh0DWsSj/0Y8HO/RDkGXYn FDMj7fZSPKyPQPmEHg+W/KzxSSfdgWIHF2QaQ0b2q1wOSec4Rti52ohmNSY+KNIW/zODhugJ np3900V20aS7eD9K8GTU0TGC1pyz6IVJwIE= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 4/1/26 07:03, Rob Herring wrote: > On Tue, Mar 31, 2026 at 11:46 AM Alexey Charkov wrote: >> >> On Tue, Mar 31, 2026 at 8:10 PM Guenter Roeck wrote: >>> >>> On 3/31/26 08:52, Rob Herring wrote: >>>> On Mon, Mar 30, 2026 at 09:07:32AM -0700, Guenter Roeck wrote: >>>>> On 3/30/26 08:14, Alexey Charkov wrote: >>>>>> TI INA4230 is a 4-channel power monitor with I2C interface, similar in >>>>>> operation to INA3221 (3-channel) and INA219 (single-channel) but with >>>>>> a different register layout, different alerting mechanism and slightly >>>>>> different support for directly reading calculated current/power/energy >>>>>> values (pre-multiplied by the device itself and needing only to be scaled >>>>>> by the driver depending on its selected LSB unit values). >>>>>> >>>>>> In this initial implementation, the driver supports reading voltage, >>>>>> current, power and energy values, but does not yet support alerts, which >>>>>> can be added separately if needed. Also the overflows during hardware >>>>>> calculations are not yet handled, nor is the support for the device's >>>>>> internal 32-bit energy counter reset. >>>>>> >>>>>> An example device tree using this binding and driver is available at [1] >>>>>> (not currently upstreamed, as the device in question is in engineering >>>>>> phase and not yet publicly available) >>>>>> >>>>>> [1] https://github.com/flipperdevices/flipper-linux-kernel/blob/flipper-devel/arch/arm64/boot/dts/rockchip/rk3576-flipper-one-rev-f0b0c1.dts >>>>>> >>>>>> Signed-off-by: Alexey Charkov >>>>>> --- >>>>>> Changes in v5: >>>>>> - Reworded per-channel subnodes description in the binding for clarity (Sashiko) >>>>>> - NB: Sashiko's suggestion to allow interrupts in the binding sounds premature, >>>>>> as the alerts mechanism is not implemented yet and there are no known users >>>>>> to test it. If anyone has hardware with the alert pins wired to an interrupt >>>>>> line - please shout and we can test/extend it together >>>>> >>>>> The bindings are supposed to be complete, even if not implemented, so I am not sure >>>>> if the DT maintainers will agree here. We'll see. >>>> >>>> Given ti,alert-polarity-active-high is added seems like the interrupt >>>> should be too. And the interrupt can specify the polarity, so is that >>>> property really needed? There's alway the possibility that you have some >>>> inverter on the board too and the interrupt polarity is not enough, but >>>> solve that problem when it actually exists. >>>> >>> >>> The alert pin can be attached to a board interrupt, or (more likely) it can >>> be attached to the I2C controller's alert pin. In the latter case there is >>> no interrupt property. >> >> Alright, I will add the interrupt property and keep the dedicated flag >> for alert polarity. >> >> Following the logic of binding completeness, should I add a flag for >> the single-shot mode too, even though I dropped that functionality >> from the driver in one of the prior iterations? > > I don't remember what that was exactly, but that sounds like a user > selection which would be some sysfs or other runtime control rather > than in DT. Unless the h/w design dictates what mode should be used. > I agree. I can not imagine that to be a hardware design constraint. Thanks, Guenter