From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E63BFC4332F for ; Thu, 3 Nov 2022 17:51:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231671AbiKCRv1 (ORCPT ); Thu, 3 Nov 2022 13:51:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230294AbiKCRvX (ORCPT ); Thu, 3 Nov 2022 13:51:23 -0400 Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 099D913DDA for ; Thu, 3 Nov 2022 10:51:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=dBDJOvb+8qPtY4K2bkSvyPDtDyYQq7/JUM/A8SfWrAQ=; b=l0+SGz9WMH+Sxs0T/TCM0HniZ4i1qzjI5HPbp0aA9QJ9QnwG+2qxbGAF YmuihIjsqrLX45RTs5/a8Lh+i1Qd9hDJnDXcKQFv5YkGBKwgBzdf9ByPG WCpgiYRy5wC9ixzfrwHWdK0ztsO6UmkhCq1wJTqUJw7Ay61cFiXyuvZv9 M=; Authentication-Results: mail2-relais-roc.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=julia.lawall@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="5.96,134,1665439200"; d="scan'208";a="72878765" Received: from dt-lawall.paris.inria.fr ([128.93.67.65]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2022 18:51:20 +0100 Date: Thu, 3 Nov 2022 18:51:20 +0100 (CET) From: Julia Lawall To: Tanju Brunostar cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev Subject: Re: [PATCH] staging: vt6655: change the function name s_vFillRTSHead In-Reply-To: Message-ID: <9eef21fa-c7bc-9fba-67ae-2a532ee6c3fa@inria.fr> References: <612f7cf-43db-a684-7a98-8469275b43fd@inria.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 3 Nov 2022, Tanju Brunostar wrote: > On Thu, Nov 3, 2022 at 5:04 PM Tanju Brunostar > wrote: > > > > On Thu, Nov 3, 2022 at 4:58 PM Julia Lawall wrote: > > > > > > > > > > > > On Thu, 3 Nov 2022, Tanju Brunostar wrote: > > > > > > > On Thu, Nov 3, 2022 at 1:38 PM Julia Lawall wrote: > > > > > > > > > > > > > > > > > > > > On Thu, 3 Nov 2022, Tanjuate Brunostar wrote: > > > > > > > > > > > Remove the use of Hungarian notation, which is not used in the Linux > > > > > > kernel. Reported by checkpatch > > > > > > > > > > > > Fix checkpatch error related to code line ends with a '(', by joining > > > > > > some lines and indenting correctly. This improves visibility > > > > > > > > > > I don't think it will be appreciated to do two things at once. > > > > > > > > > > > > > I sent it earlier as two patches but it seemed to break and fix the > > > > kernel which was not appreciated by one of the mentors > > > > > > OK, then it is a presentation problem. You have presented the changes as > > > unrelated. Rewrite the message to make clear what is being done. > > > > > > julia > > > > > Hi Julia, > I am having a hard time figuring out exactly how to write this, since > I made both changes in one patch and there is no way to send them in > separate patches. should I just report just one change and leave the > other? I would appreciate your help here Add indentation to the affected function headers to follow the Linux kernel coding style? julia > Thanks > > tanju > > > okay > > > > > > > > > > > > > > > > Signed-off-by: Tanjuate Brunostar > > > > > > --- > > > > > > drivers/staging/vt6655/rxtx.c | 48 ++++++++++++++++------------------- > > > > > > 1 file changed, 22 insertions(+), 26 deletions(-) > > > > > > > > > > > > diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c > > > > > > index 31ae99b3cb35..debc5d5daede 100644 > > > > > > --- a/drivers/staging/vt6655/rxtx.c > > > > > > +++ b/drivers/staging/vt6655/rxtx.c > > > > > > @@ -23,7 +23,7 @@ > > > > > > * s_uGetTxRsvTime- get frame reserved time > > > > > > * s_vFillCTSHead- fulfill CTS ctl header > > > > > > * s_vFillFragParameter- Set fragment ctl parameter. > > > > > > - * s_vFillRTSHead- fulfill RTS ctl header > > > > > > + * fill_rts_header- fulfill RTS ctl header > > > > > > * s_vFillTxKey- fulfill tx encrypt key > > > > > > * s_vSWencryption- Software encrypt header > > > > > > * vDMA0_tx_80211- tx 802.11 frame via dma0 > > > > > > @@ -85,15 +85,15 @@ static const unsigned short fb_opt1[2][5] = { > > > > > > #define DATADUR_A_F1 13 > > > > > > > > > > > > /*--------------------- Static Functions --------------------------*/ > > > > > > -static void s_vFillRTSHead(struct vnt_private *pDevice, > > > > > > - unsigned char byPktType, > > > > > > - void *pvRTS, > > > > > > - unsigned int cbFrameLength, > > > > > > - bool bNeedAck, > > > > > > - bool bDisCRC, > > > > > > - struct ieee80211_hdr *hdr, > > > > > > - unsigned short wCurrentRate, > > > > > > - unsigned char byFBOption); > > > > > > +static void fill_rts_header(struct vnt_private *pDevice, > > > > > > + unsigned char byPktType, > > > > > > + void *pvRTS, > > > > > > + unsigned int cbFrameLength, > > > > > > > > > > Strange spacing in the above parameter declaration. Maybe there is a tab > > > > > that should be a space? > > > > > > > > > > julia > > > > > > > > > > > > > I was also shocked when I noticed that. It seemed like a tab but when > > > > I removed the space, the two words were joined and when I added the > > > > space, it became this lage space once again. checkpatch does not > > > > complain about it though > > > > > > > > > > + bool bNeedAck, > > > > > > + bool bDisCRC, > > > > > > + struct ieee80211_hdr *hdr, > > > > > > + unsigned short wCurrentRate, > > > > > > + unsigned char byFBOption); > > > > > > > > > > > > static void s_vGenerateTxParameter(struct vnt_private *pDevice, > > > > > > unsigned char byPktType, > > > > > > @@ -555,19 +555,15 @@ s_uFillDataHead( > > > > > > return buf->duration; > > > > > > } > > > > > > > > > > > > -static > > > > > > -void > > > > > > -s_vFillRTSHead( > > > > > > - struct vnt_private *pDevice, > > > > > > - unsigned char byPktType, > > > > > > - void *pvRTS, > > > > > > - unsigned int cbFrameLength, > > > > > > - bool bNeedAck, > > > > > > - bool bDisCRC, > > > > > > - struct ieee80211_hdr *hdr, > > > > > > - unsigned short wCurrentRate, > > > > > > - unsigned char byFBOption > > > > > > -) > > > > > > +static void fill_rts_header(struct vnt_private *pDevice, > > > > > > + unsigned char byPktType, > > > > > > + void *pvRTS, > > > > > > + unsigned int cbFrameLength, > > > > > > + bool bNeedAck, > > > > > > + bool bDisCRC, > > > > > > + struct ieee80211_hdr *hdr, > > > > > > + unsigned short wCurrentRate, > > > > > > + unsigned char byFBOption) > > > > > > { > > > > > > unsigned int uRTSFrameLen = 20; > > > > > > > > > > > > @@ -912,7 +908,7 @@ s_vGenerateTxParameter( > > > > > > buf->rrv_time_a = vnt_rxtx_rsvtime_le16(pDevice, byPktType, cbFrameSize, wCurrentRate, bNeedACK); > > > > > > buf->rrv_time_b = vnt_rxtx_rsvtime_le16(pDevice, PK_TYPE_11B, cbFrameSize, pDevice->byTopCCKBasicRate, bNeedACK); > > > > > > > > > > > > - s_vFillRTSHead(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, bDisCRC, psEthHeader, wCurrentRate, byFBOption); > > > > > > + fill_rts_header(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, bDisCRC, psEthHeader, wCurrentRate, byFBOption); > > > > > > } else {/* RTS_needless, PCF mode */ > > > > > > struct vnt_rrv_time_cts *buf = pvRrvTime; > > > > > > > > > > > > @@ -931,7 +927,7 @@ s_vGenerateTxParameter( > > > > > > buf->rrv_time = vnt_rxtx_rsvtime_le16(pDevice, byPktType, cbFrameSize, wCurrentRate, bNeedACK); > > > > > > > > > > > > /* Fill RTS */ > > > > > > - s_vFillRTSHead(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, bDisCRC, psEthHeader, wCurrentRate, byFBOption); > > > > > > + fill_rts_header(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, bDisCRC, psEthHeader, wCurrentRate, byFBOption); > > > > > > } else if (!pvRTS) {/* RTS_needless, non PCF mode */ > > > > > > struct vnt_rrv_time_ab *buf = pvRrvTime; > > > > > > > > > > > > @@ -945,7 +941,7 @@ s_vGenerateTxParameter( > > > > > > buf->rrv_time = vnt_rxtx_rsvtime_le16(pDevice, PK_TYPE_11B, cbFrameSize, wCurrentRate, bNeedACK); > > > > > > > > > > > > /* Fill RTS */ > > > > > > - s_vFillRTSHead(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, bDisCRC, psEthHeader, wCurrentRate, byFBOption); > > > > > > + fill_rts_header(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, bDisCRC, psEthHeader, wCurrentRate, byFBOption); > > > > > > } else { /* RTS_needless, non PCF mode */ > > > > > > struct vnt_rrv_time_ab *buf = pvRrvTime; > > > > > > > > > > > > -- > > > > > > 2.34.1 > > > > > > > > > > > > > > > > > > > > > > > > > >