From: Krzysztof Kozlowski <krzk@kernel.org>
To: Guangshuo Li <lgs201920130244@gmail.com>,
Support Opensource <support.opensource@diasemi.com>,
Lee Jones <lee@kernel.org>,
Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
mfd@lists.linux.dev, linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org
Subject: Re: [PATCH] mfd: da9150: fix IRQ action memory leak on removal
Date: Tue, 27 Oct 2026 16:26:30 +0100 [thread overview]
Message-ID: <9ef05c62-1067-459f-8dab-2b0fbe70178d@kernel.org> (raw)
In-Reply-To: <20261027030803.118131-1-lgs201920130244@gmail.com>
On 27/10/2026 04:08, Guangshuo Li wrote:
> da9150_remove() currently removes the regmap IRQ chip before removing
> the MFD child devices. regmap_del_irq_chip() disposes the child IRQ
> mappings and removes their IRQ descriptors.
>
> The GPADC child registers an interrupt handler using
> devm_request_threaded_irq(). When the child device is subsequently
> removed, its device-managed cleanup calls free_irq(), which can no
> longer find the corresponding IRQ descriptor. As a result, the
> allocated struct irqaction is not freed, causing a memory leak.
> The associated IRQ thread also cannot be stopped normally.
>
> Remove the MFD child devices first so their interrupt handlers are
> released while the IRQ mappings are still valid. Then remove the
> regmap IRQ chip and its IRQ domain.
>
> This issue was found by our static analysis tool under development.
So you just keep ignoring and ignoring our feedback. It's just bot, so
little point to discuss with bot.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-10-27 15:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-27 3:08 Guangshuo Li
2026-10-27 15:26 ` Krzysztof Kozlowski [this message]
2026-10-27 16:21 ` Guangshuo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ef05c62-1067-459f-8dab-2b0fbe70178d@kernel.org \
--to=krzk@kernel.org \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=lee@kernel.org \
--cc=lgs201920130244@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mfd@lists.linux.dev \
--cc=stable@vger.kernel.org \
--cc=support.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®