mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Roger Quadros <rogerq@kernel.org>
To: Julien Panis <jpanis@baylibre.com>, Tony Lindgren <tony@atomide.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, vigneshr@ti.com, nm@ti.com
Subject: Re: [PATCH 0/3] Configure usb0 as peripheral on am335x boards
Date: Mon, 3 Jul 2023 16:44:14 +0300	[thread overview]
Message-ID: <9ef45899-c766-e839-522a-3b048f8106f7@kernel.org> (raw)
In-Reply-To: <babf5f20-ddf4-74bf-1788-f8e356acaa92@baylibre.com>



On 03/07/2023 14:56, Julien Panis wrote:
> On 6/30/23 21:40, Roger Quadros wrote:
>> Hi,
>>
>> On 30/06/2023 11:30, Julien Panis wrote:
>>> Hello Tony,
>>>
>>> On 6/30/23 09:20, Tony Lindgren wrote:
>>>> Hi,
>>>>
>>>> * Julien Panis <jpanis@baylibre.com> [230629 13:10]:
>>>>> This series configures usb0 dr_mode as 'peripheral' for am335x-evm,
>>>>> am335x-evmsk, and am335x-icev2. This USB port is mainly used for
>>>>> RNDIS and DFU.
>>>> Is this a mini-B connector? Just wondering if it was originally attempted
>>>> to be configured as OTG or how it ended up with a host configuration..
>>> It's a micro USB-AB connector.
>>> I don't know how it ended up with a host configuration, it looks like an oversight.
>>> Maybe Vignesh or Nishanth can confirm (?)
>> usb0 role should be "otg".
>> It is rightly so in Linux DT. am33xx.dtsi contains "otg" and all AM335x board files inherit from it.
>>
>> So I don't think setting it to "peripheral" in u-boot is the right thing to do.
> 
> This series is for kernel (not for u-boot).
> Why is it a problem to set usb0 as 'peripheral' in kernel for the 3 board dts ?
> 
> With usb0 not set as 'peripheral', the 3 boards (am335x-evm, evm-sk, icev2)
> do not boot with uboot 2023.04. This error is returned, with LOG_LEVEL=5:
>     No USB device found
>     USB ether init failed
>     initcall sequence 8ffdbba4 failed at call 808024d9 (err=-19)
>     ### ERROR ### Please RESET the board ###
> This error is also returned with usb0 as 'otg'.

This error is at u-boot correct? This will need further investigation.

Does it function correctly in Linux when kept as 'otg'?

-- 
cheers,
-roger

  reply	other threads:[~2023-07-03 13:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-29 13:09 Julien Panis
2023-06-29 13:09 ` [PATCH 1/3] ARM: dts: am335x-evm: Use usb0 as peripheral Julien Panis
2023-06-29 13:09 ` [PATCH 2/3] ARM: dts: am335x-evmsk: " Julien Panis
2023-06-29 13:09 ` [PATCH 3/3] ARM: dts: am335x-icev2: " Julien Panis
2023-06-30  7:20 ` [PATCH 0/3] Configure usb0 as peripheral on am335x boards Tony Lindgren
2023-06-30  8:30   ` Julien Panis
2023-06-30 19:40     ` Roger Quadros
2023-07-03 11:56       ` Julien Panis
2023-07-03 13:44         ` Roger Quadros [this message]
2023-07-03 14:14           ` Julien Panis
2023-07-03 15:27             ` Roger Quadros
2023-07-03 15:51               ` Julien Panis
2023-07-06  3:51                 ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9ef45899-c766-e839-522a-3b048f8106f7@kernel.org \
    --to=rogerq@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jpanis@baylibre.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=tony@atomide.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®