From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: srinivas.kandagatla@oss.qualcomm.com, broonie@kernel.org
Cc: perex@perex.cz, tiwai@suse.com, srini@kernel.org,
lgirdwood@gmail.com, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 2/4] ASoC: qcom: audioreach: add documentation for i2s interface type
Date: Mon, 18 Aug 2025 13:56:31 +0200 [thread overview]
Message-ID: <9f050ccd-0fc1-4fb2-94f5-36ed1f2f4f01@linaro.org> (raw)
In-Reply-To: <20250818112810.1207033-3-srinivas.kandagatla@oss.qualcomm.com>
On 18/08/2025 13:28, srinivas.kandagatla@oss.qualcomm.com wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
>
> Add documentation of possible values for I2S interface types,
> currently this is only documented for DMA module.
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
> ---
> include/uapi/sound/snd_ar_tokens.h | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/include/uapi/sound/snd_ar_tokens.h b/include/uapi/sound/snd_ar_tokens.h
> index bc0b1bede00c..3aa5f4928a2b 100644
> --- a/include/uapi/sound/snd_ar_tokens.h
> +++ b/include/uapi/sound/snd_ar_tokens.h
> @@ -118,6 +118,12 @@ enum ar_event_types {
> * LPAIF_WSA = 2,
> * LPAIF_VA = 3,
> * LPAIF_AXI = 4
> + * Possible values for MI2S
> + * I2S_INTF_TYPE_PRIMARY = 0,
> + * I2S_INTF_TYPE_SECOINDARY = 1,
Typo: SECONDARY
> + * I2S_INTF_TYPE_TERTINARY = 2,
And TERTIARY?
Although, they come from audioreach.h so, well, eh...
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-08-18 11:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-18 11:28 [PATCH 0/4] ASoC: qcom: audioreach: cleanup and statiic srinivas.kandagatla
2025-08-18 11:28 ` [PATCH 1/4] ASoC: qcom: audioreach: deprecate AR_TKN_U32_MODULE_[IN/OUT]_PORTS srinivas.kandagatla
2025-08-18 11:53 ` Krzysztof Kozlowski
2025-08-18 11:28 ` [PATCH 2/4] ASoC: qcom: audioreach: add documentation for i2s interface type srinivas.kandagatla
2025-08-18 11:56 ` Krzysztof Kozlowski [this message]
2025-08-18 12:02 ` Srinivas Kandagatla
2025-08-18 11:28 ` [PATCH 3/4] ASoC: qcom: audioreach: add support for static calibration srinivas.kandagatla
2025-08-18 11:57 ` Krzysztof Kozlowski
2025-08-18 11:28 ` [PATCH 4/4] ASoC: qcom: audioreach: add support for SMECNS module srinivas.kandagatla
2025-08-18 11:58 ` Krzysztof Kozlowski
2025-08-18 12:12 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f050ccd-0fc1-4fb2-94f5-36ed1f2f4f01@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=srini@kernel.org \
--cc=srinivas.kandagatla@oss.qualcomm.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®