mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Helge Deller <deller@gmx.de>
To: Vineet Gupta <vineet.gupta@linux.dev>,
	linux-s390@vger.kernel.org, Josh Triplett <josh@joshtriplett.org>,
	x86@kernel.org, linux-snps-arc@lists.infradead.org,
	linux-fsdevel@vger.kernel.org, linux-parisc@vger.kernel.org,
	linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org
Cc: Alexey Brodkin <abrodkin@synopsys.com>,
	Shahab Vahedi <Shahab.Vahedi@synopsys.com>
Subject: Re: [PATCH v3 4/4] arc: Use generic dump_stack_print_cmdline() implementation
Date: Mon, 10 Oct 2022 08:16:22 +0200	[thread overview]
Message-ID: <9f0b3333-bb28-c739-9bff-6fc50343b4f9@gmx.de> (raw)
In-Reply-To: <8da9812d-eb84-2a84-321e-ea2826ef8981@linux.dev>

On 10/10/22 07:18, Vineet Gupta wrote:
> On 8/8/22 06:09, Helge Deller wrote:
>> The process program name and command line is now shown in generic code
>> in dump_stack_print_info(), so drop the arc-specific implementation.
>>
>> Signed-off-by: Helge Deller <deller@gmx.de>
>
> But that info printing was added back in 2018 by e36df28f532f882.
> I don't think arc is using show_regs_print_info -> dump_stack_print_info yet.
> Or is there a different code path now which calls here ?

Right.
See patches #1 and #2 of this series which added this
info to dump_stack_print_info().


>> ---
>>   arch/arc/kernel/troubleshoot.c | 24 ------------------------
>>   1 file changed, 24 deletions(-)
>>
>> diff --git a/arch/arc/kernel/troubleshoot.c b/arch/arc/kernel/troubleshoot.c
>> index 7654c2e42dc0..9807e590ee55 100644
>> --- a/arch/arc/kernel/troubleshoot.c
>> +++ b/arch/arc/kernel/troubleshoot.c
>> @@ -51,29 +51,6 @@ static void print_regs_callee(struct callee_regs *regs)
>>           regs->r24, regs->r25);
>>   }
>>
>> -static void print_task_path_n_nm(struct task_struct *tsk)
>> -{
>> -    char *path_nm = NULL;
>> -    struct mm_struct *mm;
>> -    struct file *exe_file;
>> -    char buf[ARC_PATH_MAX];
>> -
>> -    mm = get_task_mm(tsk);
>> -    if (!mm)
>> -        goto done;
>> -
>> -    exe_file = get_mm_exe_file(mm);
>> -    mmput(mm);
>> -
>> -    if (exe_file) {
>> -        path_nm = file_path(exe_file, buf, ARC_PATH_MAX-1);
>> -        fput(exe_file);
>> -    }
>> -
>> -done:
>> -    pr_info("Path: %s\n", !IS_ERR(path_nm) ? path_nm : "?");
>> -}
>> -
>>   static void show_faulting_vma(unsigned long address)
>>   {
>>       struct vm_area_struct *vma;
>> @@ -176,7 +153,6 @@ void show_regs(struct pt_regs *regs)
>>        */
>>       preempt_enable();
>
> Maybe we remove preempt* as well now (perhaps as a follow up patch)
> since that was added by f731a8e89f8c78 "ARC: show_regs: lockdep:
> re-enable preemption" where show_regs -> print_task_path_n_nm ->
> mmput was triggering lockdep splat which is supposedly removed.

The patch series was dropped from Andrew's queue, because the kernel
test robot showed some issues:
https://lore.kernel.org/lkml/Yu59QdVpPgnXUnQC@xsang-OptiPlex-9020/
Maybe adding preempt_enable() in my patches would fix that -
sadly I haven't had time to follow up on this yet ...

Helge

>
>>
>> -    print_task_path_n_nm(tsk);
>>       show_regs_print_info(KERN_INFO);
>>
>>       show_ecr_verbose(regs);


      reply	other threads:[~2022-10-10  6:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-08 13:09 [PATCH v3 0/4] Dump command line of faulting process to syslog Helge Deller
2022-08-08 13:09 ` [PATCH v3 1/4] proc: Add get_task_cmdline_kernel() function Helge Deller
2022-08-08 13:09 ` [PATCH v3 2/4] lib/dump_stack: Add dump_stack_print_cmdline() and wire up in dump_stack_print_info() Helge Deller
2022-08-08 13:09 ` [PATCH v3 3/4] x86/fault: Dump command line of faulting process to syslog Helge Deller
2022-08-08 13:09 ` [PATCH v3 4/4] arc: Use generic dump_stack_print_cmdline() implementation Helge Deller
2022-10-10  5:18   ` Vineet Gupta
2022-10-10  6:16     ` Helge Deller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9f0b3333-bb28-c739-9bff-6fc50343b4f9@gmx.de \
    --to=deller@gmx.de \
    --cc=Shahab.Vahedi@synopsys.com \
    --cc=abrodkin@synopsys.com \
    --cc=josh@joshtriplett.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linux-snps-arc@lists.infradead.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=vineet.gupta@linux.dev \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®