From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4EECB2E7386 for ; Tue, 4 Aug 2026 03:49:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785815357; cv=none; b=ojUdVlBI0T/mOsbvVsceR68UXZ/u60BBKpVxGNNhJPoBoUQq7EGmSVAluMg9CuJgLjE5Gkeebd8FwtCEz1ItRXdKaP9q3THCBox/IFXPF8vs7qxbHzokJZOMAMR3DuXTdgMvCFtJecvHiGZ/XGVt3PHaXpzNvt37FdQnXIDdBzw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785815357; c=relaxed/simple; bh=uRldD9+3oyDXVJuPrrx5fy1JmUONml1QdQ/guV8X7qc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IW0Tjklwmtakyhf1BTY+N+OK3ewE7f/2MiGh1NBgfi5A+M/wYDG5x2OftGWcaGK+baJtoRpk53vkLHaRi8IWL3aKLMQURpvpJTkGe91VmRQnLUsKNtjcpn/BSglEDVvioySEo3GNo5gqVE1VtIoDwfJ8dxfgfjSGgNdtFxz5tuU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=VSazBtjs; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=WZ132u8i; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="VSazBtjs"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WZ132u8i" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67417PRK1670054 for ; Tue, 4 Aug 2026 03:49:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= XheG/6rV2f0cZ6qhmU4lso6FOAuMcYX8VwnAe6UhMAM=; b=VSazBtjs/4QVpwCD ZNTPOi2fm0tlMTcXDdhZ5F+VdTLCnv52Ty3cbs+EmVYThOKDEukk4Jdl+JdMWSBO /QWvgEUEvY/1l7/1hAV5mUN4/FihARS7JGd+JQ2XMB09oZUf/rDIbVxblvLB3oP7 syffj2GT9FMqJzBYDlyXS9YxR0N+/skJ8/w7xHKGQrljNGN71K79EmC5uic8dYk6 95LhwUfg4AXRIqxDjg0hW8PuVyJqL54uYAfTZJR5imxRJF9ujXs9fBP0XRshK62/ ieleElmM0OWmHtY8RGBGovqQ7U9O2eoY5XCC56GPqdomL4CIjVPDis8tvFw8447L xFZDSQ== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ftx7m2m7s-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 04 Aug 2026 03:49:15 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2cceabd70f5so125498985ad.1 for ; Mon, 03 Aug 2026 20:49:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785815350; x=1786420150; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=XheG/6rV2f0cZ6qhmU4lso6FOAuMcYX8VwnAe6UhMAM=; b=WZ132u8irFeN30Pbvke90AP/dCzubJgcPLrC8yxheCuuhxCiO2iE/cRcMkxNSt4c/Y hCuTIPXndHnC1gDrv/Fxjm3YdTabsiWTGVpYBy4pnjb/fOGl12CEUE5XTPNppqAI8sTo Kab2oyDwjE7vtA1SA2N43KD4kdc1HPk0/yDyrbPv7XaYeArKh9S53dk8SsB/zCodFFDN Nhkn0dxD0ZKWgNdsrRrVqicEyXG7Os3XMttr8jgN/LJ259WeQn4PWw4I6WzeTBb9LrSl WMVP/HklKaXCnrEi9uRNNMTsacw/57F2Xl3HcB1x6zLVFEtxaWJj1NBHAAobeo/uu2N7 j+UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785815350; x=1786420150; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=XheG/6rV2f0cZ6qhmU4lso6FOAuMcYX8VwnAe6UhMAM=; b=hprMGd2rUQ/aTBCoExbOlQdj/jn/hrw2MY9rGfaeR8spWHZA5uc5CEckpxaz1QZZ6X UIi0hNgkbnf1kTFfEeqjScfBKySHpecEBgOU67ByHQqfg2Guds8AfSVP/VXkvCiEVcQE jZfvP65wNVh6NccwB/57lj90bgzzbhnXU5oMpgnu5Fiu88w9GDM9vm/IY/BR6g18ogeX QxxzXUVWCWMqVGdR/5a7jhPeOt8ARnn41cyWn5axksyXG+aJMghyMbf6k76ZN4pia9v0 7MQLfVxM5l4DjeuGrQ2GCNf7lLMmtEI+DN87/6/7rv7qbzUqKDgQyPqxgeqV+DMBL39T 4iSw== X-Forwarded-Encrypted: i=1; AHgh+RpHWmlRaAvkve6s410bGY6lvKoAufeQ5azoKLLGyjJs9QFvYxQcLeWifVOaTqRl2j1pXIB35eI9adFlnrM=@vger.kernel.org X-Gm-Message-State: AOJu0YwVb0b1NpAuhj3V15WX2K6CvOjH2RlVKhDnWxzoLXsNb/6GKax3 zPUkpnBSVQB+yij8I3cOnubs2XSZXTmT7R/xa3je8lniiQKLT9CG/lYDuymWe/SUaRkmzWUw/Yu bquLj8RZX2UBENqwYvnsxfNVm2ad+w5swGrvkcqC9Xcb+ksnz/coeLyliqtBxH0p0GQ== X-Gm-Gg: AR+sD11+vQH2duN3IAwnz6anQ/V/VcAWSYTtUiBfKK/lNU3NdOXJfk9KZ9X2EU247UQ QOPJ3hStFcX6XmwrrEo5kKP/ulMtMqc7++so7k+vi5o3ltDP/Fn1tVET6qwME82ERQ9iQx/zth+ Npj+h8Q305JvKRoPjbZkxeLEz46h/07g3GKy4LTUcpHGihF0fEmECga6Sr9No98ZhI3Czx9R8Hu TAxy6Bn8+FYfLfgbjougmKAYrUwzRUj1xLIgndb1+tOcrYkqb0XUCuDg1qEoyXrl+gI+WeyR/GC 1Qj7GpWqt0a5HuS4TNkrpK24rvJa7GYuyY5c1ws4wBJXL13i507kK7hfCmlI80yoabBkr40zKfM JD8bH7PwNS7AnwwVHBOr6CCp5HUhH0YHChA== X-Received: by 2002:a17:902:ebc2:b0:2ca:d91d:d3a7 with SMTP id d9443c01a7336-2d0521a56ecmr131899185ad.10.1785815349727; Mon, 03 Aug 2026 20:49:09 -0700 (PDT) X-Received: by 2002:a17:902:ebc2:b0:2ca:d91d:d3a7 with SMTP id d9443c01a7336-2d0521a56ecmr131898905ad.10.1785815349304; Mon, 03 Aug 2026 20:49:09 -0700 (PDT) Received: from [192.168.1.86] ([206.83.118.41]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d04ae60139sm46681795ad.29.2026.08.03.20.49.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Aug 2026 20:49:08 -0700 (PDT) Message-ID: <9f11db59-5245-4bd5-afbb-485500d37675@oss.qualcomm.com> Date: Tue, 4 Aug 2026 13:49:03 +1000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] tee: qcomtee: fix kernel-doc warnings To: Babanpreet Singh , Jens Wiklander Cc: Sumit Garg , linux-arm-msm@vger.kernel.org, op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org References: <20260802003956.7-1-bbnpreetsingh@gmail.com> Content-Language: en-US From: Amirreza Zarrabi In-Reply-To: <20260802003956.7-1-bbnpreetsingh@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODA0MDAyNiBTYWx0ZWRfX3rlOFGU3qsbq HLjjHNoVwX5IvKtfTFNkeELX74QsNx4HSATxf62h3y5QdFekMR+yULOM0/DAk+wJKtff8AiJb0Q pnBxwxDoE4eFd9PkPgOR7H5+iXmmTvV1bjxkULEHACfTYEn/unV3DMNkt5HJ3H5ybbNqrk+4DeA d1oTqbheqgLHpcseGsPrgXSpiOxyx8/gk3VKiQIgeIQ3AbjdY3t7UMcEdZ/A4oqtl39cBq4tu0y Xd2K8HXMyDKmpR47uTdOyEgqPC3yO83f2h422kWa3QGLtyOtUsHsgo97j9HVO47jQ9n/dNN5082 2ffdue0bBfLAg5rijq4FtHpVmYPNFKE4MxgqHzxT8Gstl++iF/i9/Hy9dhGFontplrgQDwn856Y 4QOCCFNRDAx3U0iUXxXZK4WaNHpb2Ye9MxyybnpF5pLJ57OHtWbCEcEmZCQTViI9uu82YmRnGKF FDbIYNAkWDsEt3DPh/g== X-Authority-Analysis: v=2.4 cv=TIt1jVla c=1 sm=1 tr=0 ts=6a71613b cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=P7rZ2Udeej982rJtnmwBRA==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=pGLkceISAAAA:8 a=wsK6t3w6FQtueOB5nkoA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-ORIG-GUID: POqbBjQbuedAEsSKRTuFASABgYtI3oWX X-Proofpoint-Spam-Info: AW1haW4tMjYwODA0MDAyNiBTYWx0ZWRfXzdW1Fh2lh+o/ uocHLTa4mq6JERb6Wj/1FuGm6E/79VndmQVbdiYZD+6nJOOEocdE7F79ZdDCuX7n9BCsHtbPuO6 b5m/en7sugxXY0ArCUAqT0drglV284Y= X-Proofpoint-GUID: POqbBjQbuedAEsSKRTuFASABgYtI3oWX X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-04_01,2026-08-03_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 phishscore=0 bulkscore=0 malwarescore=0 priorityscore=1501 spamscore=0 suspectscore=0 impostorscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608040026 Hi Babanpreet, Thanks. Reviewed-by: Amirreza Zarrabi Amir On 8/2/2026 10:39 AM, Babanpreet Singh wrote: > Fix kernel-doc issues present since the driver was added in commit > d6e290837e50 ("tee: add Qualcomm TEE driver"): > > - async_release() documents its second parameter as @msg, but the > parameter is named async_msg (msg is a local variable); > - struct qcomtee_msg_object_invoke documents member @ctx, but the > member is named cxt; > - enum qcomtee_arg_type leaves QCOMTEE_ARG_TYPE_NR undescribed. > > The cxt spelling is part of the QTEE message format and is used > throughout the driver; struct qcomtee_msg_callback in the same header > already documents it as @cxt, so the comment is corrected rather than > the member. > > No functional changes. > > Assisted-by: Claude:claude-opus-5 [kernel-doc] > Signed-off-by: Babanpreet Singh > --- > drivers/tee/qcomtee/async.c | 4 ++-- > drivers/tee/qcomtee/qcomtee_msg.h | 2 +- > drivers/tee/qcomtee/qcomtee_object.h | 1 + > 3 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/tee/qcomtee/async.c b/drivers/tee/qcomtee/async.c > index 31bff4309e672..5849e51612033 100644 > --- a/drivers/tee/qcomtee/async.c > +++ b/drivers/tee/qcomtee/async.c > @@ -97,10 +97,10 @@ static void qcomtee_get_async_buffer(struct qcomtee_object_invoke_ctx *oic, > /** > * async_release() - Process QTEE async release requests. > * @oic: context used for the current invocation. > - * @msg: async message for object release. > + * @async_msg: async message for object release. > * @size: size of the async buffer available. > * > - * Return: Size of the outbound buffer used when processing @msg. > + * Return: Size of the outbound buffer used when processing @async_msg. > */ > static size_t async_release(struct qcomtee_object_invoke_ctx *oic, > struct qcomtee_async_msg_hdr *async_msg, > diff --git a/drivers/tee/qcomtee/qcomtee_msg.h b/drivers/tee/qcomtee/qcomtee_msg.h > index 878f70178a5b6..5d7b21fdd3688 100644 > --- a/drivers/tee/qcomtee/qcomtee_msg.h > +++ b/drivers/tee/qcomtee/qcomtee_msg.h > @@ -112,7 +112,7 @@ union qcomtee_msg_arg { > > /** > * struct qcomtee_msg_object_invoke - Direct object invocation message. > - * @ctx: object ID hosted in QTEE. > + * @cxt: object ID hosted in QTEE. > * @op: operation for the object. > * @counts: number of different types of arguments in @args. > * @args: array of arguments. > diff --git a/drivers/tee/qcomtee/qcomtee_object.h b/drivers/tee/qcomtee/qcomtee_object.h > index 8b4401ecad48c..d5de02dcef3b9 100644 > --- a/drivers/tee/qcomtee/qcomtee_object.h > +++ b/drivers/tee/qcomtee/qcomtee_object.h > @@ -74,6 +74,7 @@ enum qcomtee_object_type { > * @QCOMTEE_ARG_TYPE_OO: output object (OO). > * @QCOMTEE_ARG_TYPE_IB: input buffer (IB). > * @QCOMTEE_ARG_TYPE_IO: input object (IO). > + * @QCOMTEE_ARG_TYPE_NR: number of argument types. > * > * Use the invalid type to specify the end of the argument array. > */