From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751061AbdKSRVY (ORCPT ); Sun, 19 Nov 2017 12:21:24 -0500 Received: from smtp.math.uni-bielefeld.de ([129.70.45.10]:56699 "EHLO smtp.math.uni-bielefeld.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750946AbdKSRVX (ORCPT ); Sun, 19 Nov 2017 12:21:23 -0500 Subject: Re: [PATCH] ARM: exynos: add machine description for ODROID-XU3/4 To: Dongjin Kim Cc: Russell King , Kukjin Kim , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20171118203544.19431-1-tobetter@gmail.com> From: Tobias Jakobi Message-ID: <9f1311f1-2986-21f1-7016-29efc7b2a543@math.uni-bielefeld.de> Date: Sun, 19 Nov 2017 18:21:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:51.0) Gecko/20100101 Firefox/51.0 SeaMonkey/2.48 MIME-Version: 1.0 In-Reply-To: <20171118203544.19431-1-tobetter@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I don't think this approach scales at all. DietPi can just read the devicetree through sysfs and retrieve the compatible and/or model of the base node. - Tobias Dongjin Kim wrote: > This patch is to add the machine descriptions for ODROID-XU3/4 boards > in order to present the hardware name at /proc/cputinfo rather than > "SAMSUNG EXYNOS (Flattened Device Tree)". An embedded open source project, > such as DietPi, reads the hardware name to run different features. > > $ cat /proc/cpuinfo | grep Hardware > Hardware : ODROID-XU4 > > Signed-off-by: Dongjin Kim > --- > arch/arm/mach-exynos/exynos.c | 28 ++++++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > > diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c > index c404c15ad07f..6197dbf9f48b 100644 > --- a/arch/arm/mach-exynos/exynos.c > +++ b/arch/arm/mach-exynos/exynos.c > @@ -241,3 +241,31 @@ DT_MACHINE_START(EXYNOS_DT, "SAMSUNG EXYNOS (Flattened Device Tree)") > .dt_compat = exynos_dt_compat, > .dt_fixup = exynos_dt_fixup, > MACHINE_END > + > +#define ODROID_MACHINE_START(name, compat) \ > + DT_MACHINE_START(EXYNOS5422_ODROID_##name, "ODROID-"#name) \ > + .l2c_aux_val = 0x3c400001, \ > + .l2c_aux_mask = 0xc20fffff, \ > + .smp = smp_ops(exynos_smp_ops), \ > + .map_io = exynos_init_io, \ > + .init_early = exynos_firmware_init, \ > + .init_irq = exynos_init_irq, \ > + .init_machine = exynos_dt_machine_init, \ > + .init_late = exynos_init_late, \ > + .dt_compat = compat, \ > + .dt_fixup = exynos_dt_fixup, \ > + MACHINE_END > + > +static char const *const exynos5422_odroidxu3_dt_compat[] __initconst = { > + "hardkernel,odroid-xu3", > + "hardkernel,odroid-xu3-lite", > + NULL, > +}; > + > +static char const *const exynos5422_odroidxu4_dt_compat[] __initconst = { > + "hardkernel,odroid-xu4", > + NULL, > +}; > + > +ODROID_MACHINE_START(XU3, exynos5422_odroidxu3_dt_compat) > +ODROID_MACHINE_START(XU4, exynos5422_odroidxu4_dt_compat) >