From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751415AbdKUPho (ORCPT <rfc822;w@1wt.eu>);
        Tue, 21 Nov 2017 10:37:44 -0500
Received: from mail.savoirfairelinux.com ([208.88.110.44]:43188 "EHLO
        mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751316AbdKUPhl (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 21 Nov 2017 10:37:41 -0500
Subject: Re: [PATCH 2/2] ARM: dts: TS-7970: add basic device tree
To: Fabio Estevam <festevam@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
        kernel@savoirfairelinux.com,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        Fabio Estevam <fabio.estevam@nxp.com>,
        Sascha Hauer <kernel@pengutronix.de>, Shawn Guo <shawnguo@kernel.org>,
        Russell King - ARM Linux <linux@armlinux.org.uk>,
        Mark Rutland <mark.rutland@arm.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>, kris@embeddedarm.com,
        Mark Featherston <mark@embeddedarm.com>,
        Mark Brown <broonie@kernel.org>
References: <20171120211557.27946-1-sebastien.bourdelin@savoirfairelinux.com>
 <20171120211557.27946-2-sebastien.bourdelin@savoirfairelinux.com>
 <CAOMZO5AFEqk6FcfzJGO6VH0LpF7uFnkmiMYds9y=jajx8ygdZQ@mail.gmail.com>
From: Sebastien Bourdelin <sebastien.bourdelin@savoirfairelinux.com>
Message-ID: <9f24aabd-bf1f-c48f-b997-b0c80e44ca81@savoirfairelinux.com>
Date: Tue, 21 Nov 2017 10:37:39 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <CAOMZO5AFEqk6FcfzJGO6VH0LpF7uFnkmiMYds9y=jajx8ygdZQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: fr-classic
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Fabio,

On 11/20/2017 06:37 PM, Fabio Estevam wrote:
> Hi Sebastien,
> 
> On Mon, Nov 20, 2017 at 7:15 PM, Sebastien Bourdelin
> <sebastien.bourdelin@savoirfairelinux.com> wrote:
> 
>> +&ecspi2 {
>> +       cs-gpios = <
>> +               &gpio5 31 GPIO_ACTIVE_HIGH
>> +               &gpio7 12 GPIO_ACTIVE_HIGH
>> +               &gpio5 18 GPIO_ACTIVE_HIGH
>> +       >;
>> +       pinctrl-names = "default";
>> +       pinctrl-0 = <&pinctrl_ecspi2>;
>> +       status = "okay";
>> +
>> +       spidevfpga: spi@1 {
>> +               compatible = "spidev";
>> +               reg = <1>;
>> +               spi-max-frequency = <1000000>;
> 
> According to drivers/spi/spidev.c:
> 
> /*
> * spidev should never be referenced in DT without a specific
> * compatible string, it is a Linux implementation thing
> * rather than a description of the hardware.
> */
> 

Thanks, you are right!
Just to point it, this warning has been introduced in
956b200a846e324322f6211034c734c65a38e550 in date of march 2015, and it
seems some devices trees whom had been introduced after still use the
"spidev" string only.