From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2DF822B8A9 for ; Mon, 10 Mar 2025 14:19:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741616360; cv=none; b=fbthZo7VE1wbBje0maTIgi7Ekn3psBNWIi9fou2+zNGQ+RhzN8UL1KrJDReCqQ6Hqs2uvh96KXX4CDWu3hdqtDpvdIen8qhrekCpIIDxXwgwrlWKE0DMNTEI0Q/NT0YvwGwZeYtoV2hP882IozB36KG2FJksauwW+kBryPdbjKo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741616360; c=relaxed/simple; bh=Kw4X0RI3xQvRk9ucYIdDfRHJh2hsR5AMw3p+dcYDCzU=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=M38i35kPlgiqbvx0Q7GZt//j0/2JL3Je9vdM5nDvy55UE5LkThfV7CaYSplhBYD3ptQd/0124rxXPGEnfva0FCGRMjsRp2tFNsE5EMI+5+x4FhQDPQPNItKo/HJffJO9CZcA+l1MG9w3WorCLeAkYJAb587reptlQ0DXBIQQvsE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ReZPmDvB; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ReZPmDvB" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 52A9p5tc002709 for ; Mon, 10 Mar 2025 14:19:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= r+Wq5zJA6gmbv2FgerKyZATG7S66Z12P3Ud/hZNivrE=; b=ReZPmDvBr1fmD+qp h4I9JZpX4Ynm+eDHnNilzqcFR07uU3wlimmeei8NkzQKx/w+G311bYD4+9tOps1J ic0IOmd3emrnfOLkrdvcazAhUVJov/B1BsPB6DHA1DcRbgjriK0T0iZeZ8DEFSIR EutrBCSL1M5mYY++oG1UCrFdsRyu3h8ZKoAXL4TZUuFRgRTVzMEXqKCHOyYTQQFb krA1Spt+dmg2Swbq5xhgSTFM38yUiffqpLY1BoaYKzmtRWGhqJZFPMYdCNQV9asU agMHG2R8UpECK92ID35ij+oFJBd5/6H+NONoEwVfa01Mnh40ECcLcVtAl+L69XWY YSBhJA== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 458f1jw1yc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 10 Mar 2025 14:19:17 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2240a7aceeaso78132935ad.0 for ; Mon, 10 Mar 2025 07:19:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741616356; x=1742221156; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=r+Wq5zJA6gmbv2FgerKyZATG7S66Z12P3Ud/hZNivrE=; b=V5Kyk7xCqp1F596mkRR7c9kIO9QCLR2ISo6jw+yKHfbHwIDqzSNIXHlD1DRL5wQZ5z 8YofdmLxpfDFoY3oPHLGRGHjFbJfSfkuarJJAtiAaBBbAgThj8BwnfbpqJ1TUQ1FDn8T vP5TrzdEFqf4318XrFwSt031lwbTu9dk5VH4M2yK3f7YevSsiXr/vR1KcwWQJfwb9wW+ lBP5EILVAonCrW1YSbQ96TrU0d5191DPSPlljs6v24gn1WjZYesuAxSNkB+DECKLXymX 6Mwf1Hu4cuFOFQzMlBZvQWb+P8UVGuyS6Xm+Gd8T8DMmFJshQLS8yibEiXRO88MtEivi 1uRw== X-Forwarded-Encrypted: i=1; AJvYcCW/2PFArJbwN5q/SLgnavIO8grZcI2N/fqZ23KhaeDAm4iyKcOwK5b88ePXfvjxteTU89YrtWyndUUjH64=@vger.kernel.org X-Gm-Message-State: AOJu0Yz9e0Eja6UUdmijNW/3t68U/RNxysLRZNMQkpgWvr7hKLU6DUSU DIhrVKyOf7DC1mCPTvZmADAlFEpbXp2f2ZuYYasE9km3fDXqSSstOUqLyXoTc2VMgqkgcST4k8Y KWZmH7kskbQ2EZqKcZKhjLBt5aPUHYGsmmLaEAA1aoPZ7ZxHK+TNQZwhYEI348Yw= X-Gm-Gg: ASbGncsOyZ6ShSVwG0GAFRkjVXnNTFN4rxfN9RSWPXaDZakPpFHSmADH8RKqiDaxQTv SJskz9nf5BEzx1JbR7j1cbeCZhyxGbZavGAsUV8vbbV8F4pipOG3cxucDVUA9pL28Ltz5oQ+smN /vJTYEcRA3EJ72aWwJcvbgYXFra35uQzzDgnMvGpxcJI1mbCiK2p3CWycz9XyNBR1AL7dqm/PcW P+LGXLrG5Irf4BFixyKkw4DeGuqb63g9CedycpM7l6arYa0N6ferFZax1YxgzpCJ5SQ7yEoei/j hk62nQjk5/DaXO7oqLcIq+1I4X2/86N8+BZehPJd488= X-Received: by 2002:a05:6a00:852:b0:736:51ab:7aed with SMTP id d2e1a72fcca58-736aaab8008mr16770604b3a.16.1741616355881; Mon, 10 Mar 2025 07:19:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFSpiN3WbZvFe9s6am2TScjvv9/DFmmZEYEiSM5uSmFppMupwiyNO+jb3RAjIUSnvXpQygleA== X-Received: by 2002:a05:6a00:852:b0:736:51ab:7aed with SMTP id d2e1a72fcca58-736aaab8008mr16770547b3a.16.1741616355386; Mon, 10 Mar 2025 07:19:15 -0700 (PDT) Received: from [10.216.60.76] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-736c05cb6e3sm4581999b3a.45.2025.03.10.07.19.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Mar 2025 07:19:15 -0700 (PDT) Message-ID: <9f24e85d-f762-4c29-a58f-ed7652f50919@oss.qualcomm.com> Date: Mon, 10 Mar 2025 19:49:03 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V5 1/5] dt-bindings: iio/adc: Move QCOM ADC bindings to iio/adc folder From: Jishnu Prakash To: Krzysztof Kozlowski , "Rob Herring (Arm)" Cc: jic23@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, agross@kernel.org, andersson@kernel.org, dmitry.baryshkov@linaro.org, konradybcio@kernel.org, daniel.lezcano@linaro.org, sboyd@kernel.org, amitk@kernel.org, thara.gopinath@gmail.com, lee@kernel.org, rafael@kernel.org, subbaraman.narayanamurthy@oss.qualcomm.com, david.collins@oss.qualcomm.com, anjelique.melendez@oss.qualcomm.com, quic_kamalw@quicinc.com, rui.zhang@intel.com, lukasz.luba@arm.com, lars@metafoo.de, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, cros-qcom-dts-watchers@chromium.org, quic_skakitap@quicinc.com, neil.armstrong@linaro.org References: <20250131183242.3653595-1-jishnu.prakash@oss.qualcomm.com> <20250131183242.3653595-2-jishnu.prakash@oss.qualcomm.com> <20250202-convivial-stingray-of-promotion-1123b8@krzk-bin> <690befae-335d-4d35-aa32-abd537dfc4ef@kernel.org> <08be051d-6c76-4513-84fd-3ebd0808f695@oss.qualcomm.com> Content-Language: en-US In-Reply-To: <08be051d-6c76-4513-84fd-3ebd0808f695@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=ctthk04i c=1 sm=1 tr=0 ts=67cef4e5 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=Vs1iUdzkB0EA:10 a=Z0xEvofwb1qho15bfkwA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-ORIG-GUID: cPOW3xbhtxwxHFoba9l_nxvDtnK0iZqM X-Proofpoint-GUID: cPOW3xbhtxwxHFoba9l_nxvDtnK0iZqM X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1093,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-10_05,2025-03-07_03,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 lowpriorityscore=0 phishscore=0 adultscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 spamscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502100000 definitions=main-2503100112 On 3/3/2025 7:26 PM, Jishnu Prakash wrote: > Hi Krzysztof, > > On 2/26/2025 2:41 PM, Krzysztof Kozlowski wrote: >> On 26/02/2025 09:51, Jishnu Prakash wrote: >>> Hi Krzysztof, >>> .... >>>>> Changes since v4: >>>>> - Updated some more devicetree files requiring this change. >>>> >>>> I don't get why this fails building and nothing here nor in cover letter >>>> helps me to understand that. >>>> >>> >>> I have tried checking multiple ways for anything missing in my build setup, but I'm not getting this error when building in my local workspace. But the error itself looks invalid to me. >> >> So probably false positive / automation issue. >> >> Maybe describe just in case in the changelog that you run full >> dt_binding_check and no errors were reported. >> > > I can do that, but do you mean I should just push this same patch again > with only that update in the changelog? > > I'm asking because I suspect this patch will get the same error again. I > remember that this patch 1 got the exact same invalid error (qcom,spmi-vadc.h missing) > in my V4 patch series. At that time, I thought this may be some rare corner > case error which might not always happen, but that seems wrong now. > > Please let me know, is it better to keep this single patch for the binding file > movement and reviewers can overlook the invalid error from the bot, or should I split > this patch, like I suggested in my previous mail ? > Hi Rob, For now, I'll send the same patch again (moving all QCOM ADC binding files in a single patch, with compilation fixes), with any required updates, in my next patch series. If the same invalid error is reported again (qcom,spmi-vadc.h missing), I hope you can consider ignoring it, if I confirm build and full dt_binding_check worked with no errors, in the changelog, as Krzysztof mentioned. If this does not sound good, please let me know if you prefer I should split the patch in one of these 2 ways, as I suggested in my earlier mail: 1. In first patch, move qcom,spmi-vadc.h alone, to "/include/dt-bindings/iio/adc" updating its path in all other affected files. In second patch, move the remaining dt-binding header files referencing qcom,spmi-vadc.h, with similar corrections in other affected files. or 2. In first patch, copy all the relevant dt-binding header files present in "/include/dt-bindings/iio/" folder to "/include/dt-bindings/iio/adc" folder. In second patch, update all other files (.c, .yaml, .dts/.dtsi) to use the newer ADC file paths and delete the header files in the older "/include/dt-bindings/iio/" path. Thanks, Jishnu > Thanks, > Jishnu > >> BTW, please wrap your emails. >> >> Best regards, >> Krzysztof >