From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF642C43381 for ; Tue, 12 Mar 2019 20:19:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 97AB22147C for ; Tue, 12 Mar 2019 20:19:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=akkea.ca header.i=@akkea.ca header.b="AZ8i4eI9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727313AbfCLUTC (ORCPT ); Tue, 12 Mar 2019 16:19:02 -0400 Received: from node.akkea.ca ([192.155.83.177]:51746 "EHLO node.akkea.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726939AbfCLUTA (ORCPT ); Tue, 12 Mar 2019 16:19:00 -0400 Received: by node.akkea.ca (Postfix, from userid 33) id C4BC44E204B; Tue, 12 Mar 2019 20:18:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akkea.ca; s=mail; t=1552421939; bh=CLsJUgY6072ng4H8Psr/at9acv3E5litlixfC+6CBfI=; h=To:Subject:Date:From:Cc:In-Reply-To:References; b=AZ8i4eI9xSR04MN6viCDJ/n7gdOpv03jJg/2+zXsm0rJWBzSi+wxSEsJfSF1nF3MW gpIXE/njG7Ly5uTnBT9Ut3HjxnTXlo+g/nT1PC/9G1EHeha54lkEtmgoO4pOegge6Y UZNY49i1mLMedGuVK0QlSjrxfx3hTaymEQOhc+ns= To: Andrey Smirnov Subject: Re: [PATCH] arm64: dts: fsl: imx8mq: enable the thermal management unit (TMU) X-PHP-Originating-Script: 1000:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 12 Mar 2019 13:18:59 -0700 From: Angus Ainslie Cc: Mark Rutland , Rob Herring , Shawn Guo , Fabio Estevam , Sascha Hauer , Lucas Stach , Abel Vesa , daniel.baluta@nxp.com, agx@sigxcpu.org, dl-linux-imx , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-kernel In-Reply-To: References: <20190311213124.29325-1-angus@akkea.ca> Message-ID: <9f25fb1a0acb35539dcd802502c49058@www.akkea.ca> X-Sender: angus@akkea.ca User-Agent: Roundcube Webmail/1.1.3 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andrey, On 2019-03-11 19:35, Andrey Smirnov wrote: > On Mon, Mar 11, 2019 at 2:35 PM Angus Ainslie (Purism) > wrote: >> >> These are the TMU nodes from the NXP vendor kernel >> > > Hey Angus, > > TMU block supports multiple thermal zones and vendor kernel doesn't > really account for that (see below). Latest version of the driver in > thermal tree now actually supports that feature (mulit-sensor), so I > think the code in DT should reflect that as well. I recently submitted > a series adding HWMON integration for TMU > (https://lore.kernel.org/lkml/20190222200508.26325-1-andrew.smirnov@gmail.com/T/#u) I tried applying those to linux-next. They don't apply very cleanly there so I gave up. > and this is my take on this patch: > > https://github.com/ndreys/linux/commit/09931e3d60af0a74377307b433db97da1be31570 > > All of the code there is up for grabs, if you feel like using it. > I followed that and I have a version that works with linux-next that does not include the GPU and VPU parts. I also tested a version with the GPU and VPU parts and it "works" but creates 2 useless paths in /sys/class/thermal . Should I wait for your changes to get into linux-next or resubmit a version that works with the current one ? Thanks Angus