From: Reinette Chatre <reinette.chatre@intel.com>
To: Ben Horgan <ben.horgan@arm.com>, <linux-kernel@vger.kernel.org>
Cc: <tony.luck@intel.com>, <Dave.Martin@arm.com>,
<james.morse@arm.com>, <babu.moger@amd.com>, <bp@alien8.de>
Subject: Re: [PATCH v3] fs/resctrl: Add CONFIG_RESCTRL_ASSIGN_FIXED Kconfig entry
Date: Wed, 4 Feb 2026 08:08:52 -0800 [thread overview]
Message-ID: <9f2759ae-58c0-437a-8439-5b75fa036da3@intel.com> (raw)
In-Reply-To: <20260204120248.656646-1-ben.horgan@arm.com>
Hi Ben,
On 2/4/26 4:02 AM, Ben Horgan wrote:
> Commit
>
> 3b497c3f4f04 ("fs/resctrl: Introduce the interface to display monitoring modes")
>
> introduced CONFIG_RESCTRL_ASSIGN_FIXED but left adding the Kconfig entry
> until it was necessary.
The changelog flow makes a big leap between its two paragraphs. I cannot tell why the
middle paragraph was dropped since it describes why the change is needed now to connect
with the opening context. Could you add a middle paragraph like below?
Add CONFIG_RESCTRL_ASSIGN_FIXED in order to support MPAM where the counter assignment
mode is indeed fixed.
>
> CONFIG_RESCTRL_ASSIGN_FIXED is a resctrl fs Kconfig option so handle
> attempts to modify counter assignment mode when it is enabled in resctrl fs
> rather than delegating to arch specific code.
>
> Signed-off-by: Ben Horgan <ben.horgan@arm.com>
> ---
Reinette
next prev parent reply other threads:[~2026-02-04 16:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-04 12:02 Ben Horgan
2026-02-04 16:08 ` Reinette Chatre [this message]
2026-02-04 16:12 ` Ben Horgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f2759ae-58c0-437a-8439-5b75fa036da3@intel.com \
--to=reinette.chatre@intel.com \
--cc=Dave.Martin@arm.com \
--cc=babu.moger@amd.com \
--cc=ben.horgan@arm.com \
--cc=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®