From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 004.mia.mailroute.net (004.mia.mailroute.net [199.89.3.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 701D21F09A5; Mon, 7 Jul 2025 15:40:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=199.89.3.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751902813; cv=none; b=FwZZZiL91+gtNT/uyR622UOYabQS5piM7SOPpAHbAQcWvZQoZ7Aik8anoMMgI/8tet8EFzaQiLiBToOmwEjwNSRMrcjOt6BqAVLPN/79obkUmUvYZx62/BZO5keh6lGPXPIosDmpEcDSxvxY625NR0Ism8D/VJLTVNd6osXT5ZQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751902813; c=relaxed/simple; bh=hNy9q8E+jaKYA95rrAmxOa1YboE2IejBQgnmMkL288c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uGDoI14tanaqxLHH0x9CiesHLzl3nA58OjFta5gFI4GXC3Wl1Nm9Gw2mIoCkfG/KF5xMMuIn/fTwBaazOOfZhWoMuD2Z4NW5qmKiBeb57nfnfRl5cbmfNzgIBkSvvEnJP8ZHTSfqNLwPiNv0tNQ50Na9uWM0dA4+b4FbQ/0VOWE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=acm.org; spf=pass smtp.mailfrom=acm.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b=thtA1SXU; arc=none smtp.client-ip=199.89.3.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=acm.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=acm.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b="thtA1SXU" Received: from localhost (localhost [127.0.0.1]) by 004.mia.mailroute.net (Postfix) with ESMTP id 4bbT2W6Yp2zm0ySb; Mon, 7 Jul 2025 15:40:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=acm.org; h= content-transfer-encoding:content-type:content-type:in-reply-to :from:from:content-language:references:subject:subject :user-agent:mime-version:date:date:message-id:received:received; s=mr01; t=1751902801; x=1754494802; bh=hNy9q8E+jaKYA95rrAmxOa1Y boE2IejBQgnmMkL288c=; b=thtA1SXUtKqdE6w0yDKP75OWI1o/e8/VAs2EmRQt ySYhzHcqBG5NI8K4z6949nonnkm/OnuZKh+UQDZnhOoXGP6V9utxiH5qMYVNqn6y 6gqV0hKbqRXFvm9pEwjK4R1Nk9Ka7ii+JZnyqLkkKIfxtmr+Aot+8HMzFTL0u19g IVnRM5Oxi+maxqVNc+n4CvwIZnCv92439lzc2dHqhxpUwJFpi+ef2XJgDMshHU/i n5J+GdiEmGf6W9HafRxNUwibr9SziBTLMwNrXO8JqM0b+Q0vcvlxqhTu/AiA0Xwc zr8z99TNQiZ9/lE/cVCXwvBQ8C/UEWKAFdmNHd/tHrhdfw== X-Virus-Scanned: by MailRoute Received: from 004.mia.mailroute.net ([127.0.0.1]) by localhost (004.mia [127.0.0.1]) (mroute_mailscanner, port 10029) with LMTP id 822Kd6-Eq7YK; Mon, 7 Jul 2025 15:40:01 +0000 (UTC) Received: from [100.66.154.22] (unknown [104.135.204.82]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bvanassche@acm.org) by 004.mia.mailroute.net (Postfix) with ESMTPSA id 4bbT2J2NTCzm0ySj; Mon, 7 Jul 2025 15:39:51 +0000 (UTC) Message-ID: <9f281874-21b7-4561-914a-52c8ef16b03a@acm.org> Date: Mon, 7 Jul 2025 08:39:50 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: =?UTF-8?B?UmU6IOWbnuimhjogW1BBVENIXSBzY3NpOiB1ZnM6IHByZXZlbnRpbmcg?= =?UTF-8?Q?bus_hang_crash_during_emergency_power_off?= To: =?UTF-8?B?Qm8gWWUgKOWPtuazoik=?= , Alim Akhtar , Avri Altman , "James E.J. Bottomley" , "Martin K. Petersen" , Matthias Brugger , AngeloGioacchino Del Regno Cc: =?UTF-8?B?WGl1anVhbiBUYW4gKOiwreengOWonyk=?= , =?UTF-8?B?UWlsaW4gVGFuICjosK3pupLpup8p?= , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-mediatek@lists.infradead.org" References: <20250519073814.167264-1-bo.ye@mediatek.com> Content-Language: en-US From: Bart Van Assche In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable On 7/7/25 12:49 AM, Bo Ye (=E5=8F=B6=E6=B3=A2) wrote: > Thank you for your feedback. > I believe ufshcd_wait_for_doorbell_clr() can handle both legacy single=20 > doorbell mode and MCQ [ ... ] Agreed. > Therefore, the current implementation should support both modes. > Please let me know if you have further concerns. The Fixes tag seems wrong to me. I think it should be changed into the following: Fixes: 19a198b67767 ("scsi: ufs: core: Set SDEV_OFFLINE when UFS is shut=20 down") I will add more comments as a reply to the original patch. Bart.