From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756788AbcHXOM6 (ORCPT ); Wed, 24 Aug 2016 10:12:58 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:8126 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753783AbcHXOM4 (ORCPT ); Wed, 24 Aug 2016 10:12:56 -0400 Subject: Re: [PATCH] nvme: Fix nvme_get/set_features() with a NULL result pointer To: Andy Lutomirski , Keith Busch References: CC: , Christoph Hellwig , , From: Jens Axboe Message-ID: <9f297b01-8f01-3d09-1de9-8be0d5ff007c@fb.com> Date: Wed, 24 Aug 2016 08:11:27 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [216.160.245.98] X-ClientProxiedBy: CY1PR0601CA0037.namprd06.prod.outlook.com (10.160.162.47) To MWHPR15MB1199.namprd15.prod.outlook.com (10.175.2.141) X-MS-Office365-Filtering-Correlation-Id: 3a9fba21-49be-4328-791e-08d3cc288c7b X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1199;2:KmvsaYY6VyXz/5EL07txkESNt3IvPwJaSDxCJ/aB5ZLLTaWPzz7ZQHXvNcUTW/fZawTTRF9AprKETuPi0T2A0HsFozPWEAjTriyaNKO3/5BsAnKIw+FWWGRt5uE8QIP2W1giZFib9QCGEsZAHYfT15nYpLedZXEapQBWanKWP3//HLhiJWC3FvZfwu6w/4oP;3:lv+sbmbCoVKuQ5w78npLR0s4K5ZkgN42CWZivt9dHpv0TMcmUm92u/Wb7EfcnjE8Wyi6+XSAvCEP9n/cmxznsI+Gcxj4UUjCDHkVybIcAgxKAZqDxct81ysgwt+JStgR;25:v61IHZNBK8W72mpAhJ9+48A7cVnR8lzRsmvvD6Gk5Rjwna8vePfOH3ca4s00GtSM7IVLSBAiaYZrpxFNrYoJLcYvmrdxy+HoZhfUrIT50BsfQG5p1cKE1/+UtB1YT8ZR4alOz0NERHda4M4QiRusYmxrExzkMm7epBfTKhmAXo7YDGUiMEW0cN2WmupmyAjcFVFDi+eI0JAugVGrAVMwlfbvozbLPpV/zZ0OguiicplijQuOJx2eGNQ4tG10gYB2hDOtqXfZfYgjRtAd1+H4GThYAGixbO1v6hWq/kVMCM59PQSQcnC/6CsJZul1GNFehtCxOXTJKxLsWjmhXPn5PQlf6PQA/105HCUM0PrvbHF8gSYshNIPtFYsSrZV/dTRTLDCYq+Axla3F7BBMgWK4nqwAAD1g56oDRgIVxhs01s= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:MWHPR15MB1199; X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1199;31:Fmf2rBPdGbyuPsSlUgCbUbpiwXjuqpBUrZO3rS9UsXFe2kC4UTg+H4CdIJCubLi5MCyLrEoLBX+1UHEWKRz+/U3M0OjpBA1D2/KRyAkOtyznDPdI46Iq9SW/z4pSj+lXL0ZlcgpDuoDTl25dD9Hkk6zv/uLDM8qPOrEjzSkWLrpe0CGSNMEycFavmfsiryG6c8zD2GXJzTHfJc60No8NUbgCD5pvL/UyH+hiZJWiYOY=;20:b2vvUYC+uc2UagrS4lgChQDhMD7IolTV9MgpriVgDYZeJ7+RDMnHnH/J/lDGqGig+hgXij46t5o2XDPaqX5kPmjiV+F8muPtnsCW8BAejMEn5Bwl2UaE2yzte7H+fkMiner1O/sG7Wbrw+iFk+L9w7MfI/ErrQoueLF9ySDucH0=;4:ZxhVuE08sKwLifOvvLDHs4a82Mxo1uHfPM/glUbCEVsD1yQXlXOOGdXU0r4xGnYjYFwXLtBoDiqMaP7TwkqwZZp8CbdtNmoDyho6cbqmo1vmnOnVLkkT3gOkLaAo6XNr83HP6tqMOCjDLPmvTavkXFEpXUYJAaXV9bckWe/b2Y4sa1F9Ix/72qFH6xTDqCQznLU8a5u0MJZ2zQsfjp2Xwc/6Gljo+wBCKKY5HMCs/PIrcyZb4+2pbHSdLO+/dYEMUPuOoRvzQNB/d7DIRFpB82p8Fe0TNcE3+BbUYAG0n4r9m0j1yI96FM928O16Zk89HhmcfHb5abXjS2TtSPQI6fv1/X3EiLcJYsY1y+RrWeba/N3qaVQ80v2yJKpU4DMTyDAYhqqRfNU1yuqeI4NMyw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046);SRVR:MWHPR15MB1199;BCL:0;PCL:0;RULEID:;SRVR:MWHPR15MB1199; X-Forefront-PRVS: 0044C17179 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(7916002)(199003)(189002)(377454003)(24454002)(7846002)(7736002)(106356001)(5660300001)(50466002)(117156001)(33646002)(305945005)(105586002)(42186005)(101416001)(68736007)(31686004)(230700001)(50986999)(65806001)(3846002)(23746002)(4001350100001)(31696002)(36756003)(92566002)(65956001)(86362001)(47776003)(8676002)(586003)(81156014)(81166006)(54356999)(6116002)(76176999)(77096005)(66066001)(83506001)(97736004)(2906002)(189998001)(5001770100001)(4326007)(64126003)(2950100001)(65826006);DIR:OUT;SFP:1102;SCL:1;SRVR:MWHPR15MB1199;H:[192.168.1.153];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;MWHPR15MB1199;23:tdBrN5edfP8izn5H/iSSmh2n/y5bc1qjn0Lv7?= =?Windows-1252?Q?bSmgzAe9pTn3mgEnKz6oruHa9EWF/H1rDX1bK7F7Yft/Qlk1bYm1GV5a?= =?Windows-1252?Q?z4hy/xXDlv+CY8cfASDy4C92xHzKNVS2taguOGZL0Y7tObZPthWem58r?= =?Windows-1252?Q?M3eTa5bmjYp+kyuwUc2Ale7mHUN8uFhiLJ4DetiA3BmrWSpnEdzwNZqi?= =?Windows-1252?Q?elfKIqbJ4ybhLNsvI/z7IdXbb90rARwJPEAest6AOMK5891Pvn+fZ3ef?= =?Windows-1252?Q?x4Brarr4ikFkjKe1bfzTzEyWEYHgLHzj0zyTC/9SP0u+5LzX890g/Y/Q?= =?Windows-1252?Q?/d9Fntxs2xjT6Wc6Tg8HtgrF38EEZI4y1ckaBH+wJphwFIiP1Q/8YRp6?= =?Windows-1252?Q?ujEpsw6gKBnkpLT9WNE8Aw968FG880OQ32SiNiTjlKioFUQFlKJjAS3D?= =?Windows-1252?Q?DlJwxN+KymYLBBy5rBoUzjhtXFAwPuuVjmw0pu9xdozhea8Rr9tqYC2L?= =?Windows-1252?Q?UNTO356o4jPyqxrouNR7ddnnRWeWhGuiqy6cXGGy7fWprmETaDg19JF/?= =?Windows-1252?Q?6Dnb269yMEiZPzQEHmYYIbKS+0hRYM2QfoVUt5vRT76LkOS1Uy4Y+1cA?= =?Windows-1252?Q?9jyyPUY75eMhCpKEcnkHJc6CKJT2cT+gFHddRweBtvhED8OKSNxV21r6?= =?Windows-1252?Q?V0114fzf5BnXsUo+mmKymv1qI3pCMT9+yGo7MhE+fd3Ne4Vw2cUYQ6OS?= =?Windows-1252?Q?KpzhQcJ53YdU4kDh/VTqKHR2ZTGUKh1kHMzOrr9oo9cXywoXQ8dqqvul?= =?Windows-1252?Q?pREpcOECO9biKkwExJJuKdzGK4NkO2Cs87CskO4iJRFQmfxbVNVnmnDy?= =?Windows-1252?Q?MLjo12tAjaKsbroc7/jTR8KDIXeyBz46I1eFaXabtwD46zryhjQwgKKL?= =?Windows-1252?Q?tcpreTGFnU432PHcpuJNJ4c/8wbKee+b4zxIoiXQuWMCki3cxdYjTUhk?= =?Windows-1252?Q?eB8qIg/vOaadfgjjVjujoC8ZVvLuuIf5fHFx1XMVVg1Q70IRvSTfUmYQ?= =?Windows-1252?Q?2LtVOaGOMrvf+/QXudYLdV6LDS9hmZuOrCTeLYBeoo7lXKunCkMob3Ci?= =?Windows-1252?Q?AWflQUS7Jq+nzbmlojNMul1+wjOc4qhAVaJHW5Il4sVFqV30UbxCnd3M?= =?Windows-1252?Q?FFmfu4xbF3GIaionGPWI0ILrQquSjFmLLiO3EdGvbS1chQ3Dc0Z8zIhg?= =?Windows-1252?Q?wLbPd+oesBMFHne/NapHAk6DvpRoY1fr9uBOXZOSq8BjNWmD/ar8ljye?= =?Windows-1252?Q?l790puoERWJi9rn9ryjrF0l0kheVzWQazHREVnEOaw68v3DAZacjkdEo?= =?Windows-1252?Q?XPlcfiMND1I?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1199;6:dsUhR/KvALmTUJvdxDkdsRQGRMewzY2HW7frccoqYWVEFDWLPsh4XAkd2SD4O95vS/n3kRf2E3AXv1jaC5VhO4yXlH9Lb/9DHUPi0RXcR4NRBXmM/7H6A6V1bbhnqXlzvcIzudGf269MKXjpiSNvzdzOQQIviySrBEQH4ixaSUk5AH0P2JBI8/u2e7VigeIF7FlDtE2kSZmoe7Laleqq557B+dwlLGZ2eLQU03AZiYNdTANUGcxr6ZAaXiBjl/Eda9rvslflNhSfRp2r/tVZtDg+Ngoxnxr2cYLcSW10WZU=;5:T/6vVeJNFT3NqB9WhR2F9AwOl11EZTVk88rE7SPp5UADo8/V/lQ7V1xiyo9O9PoVrfeC1iBmm+YsIeLz2nNSRfh7Chk8BEuD+NGOCer9b75VafNOmG5wHu9iQcJoFojSmn5csDXvOBbOnW1qlMN31w==;24:+W/wQvqeQSXYJefEwwPWBSovlF2hfi6ierQNfdt70laLRsJ/XtaTZlhOWHKeGFWGyaVa6Vak54SGReUgKQUxBBAlEc7IzbxDm6yx4u4L3kA=;7:f3KgOvgx2ZrhlodBeBd3qCPntq7cJ1hsEg2+dRgvEOrnTPA1A28vvrVmCZZFAxZbTsssnvx57wDWP3gzf7xUX3apDqN0VP6lv92jTKQrbD0pVXX6eRCYJApj0JW4Xc5yo51KAwCs7tKdgdeqErB0dYWkKHaSvXNZJ0WX8RfwnuhM4iwJ34uzMmUSU9O29hNV6sxq/s6Udj1XL5yKCuM8XUbzCrkjUJH9qXk6J3ikzZP2OxAyfqBctOVn4EJWOMTX SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1199;20:hbTvyiUNaRLqEzjUMFlcf5hhV2RQc+ZYUzzj8p/aIwsJ8jP09XYY1grIqg8cUU1K41mWMDmOH8XAVjE7dRznCDmEqx+GlRB/MHbcxqjo3TwY9nyxsNSvTaL9dxX5q9oUenQ7kg5MMIAXxpldo3B55lpFrELBvEHcS8mb1CftxoU= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Aug 2016 14:11:31.3282 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR15MB1199 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-08-24_07:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/24/2016 04:52 AM, Andy Lutomirski wrote: > nvme_set_features() callers seem to expect that passing NULL as the > result pointer is acceptable. Teach nvme_set_features() not to try to > write to the NULL address. > > For symmetry, make the same change to nvme_get_features(), despite the > fact that all current callers pass a valid result pointer. > > I assume that this bug hasn't been reported in practice because > the callers that pass NULL are all in the SCSI translation layer > and no one uses the relevant operations. Thanks, applied for 4.8. -- Jens Axboe