mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Romit Dasgupta" <romlinux@gmail.com>
To: "David Brownell" <david-b@pacbell.net>
Cc: greg@kroah.com, stern@rowland.harvard.edu,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Moving spinlock to struct usb_hcd
Date: Sat, 26 Jan 2008 21:06:36 +0530	[thread overview]
Message-ID: <9f29ca150801260736j205b67d2jf9b57d3ac05176a2@mail.gmail.com> (raw)
In-Reply-To: <200801260021.50786.david-b@pacbell.net>

>
>
> Looking at how this lock is used, contention doesn't look likely
> to be an issue.  It's never held for long ...
yes in the general case but in usb_hcd_flush_endpoint routine it seems
to be held for longer than other routines. I agree that
usb_hcd_flush_endpoint is an infrequently called routine. Normal
systems dont have too many HCs. My computer shows 1 EHCI and 3 OHCIs
so I guess when I connect high speed devices there are less chances of
contention. With more HC this lock might be contended for.
Nevertheless, the right place for the lock seems to be inside usb_hcd.
What do you think?

>
>
> Do you have any proof that contention is an actual problem?
> Because otherwise I see no benefit to such a change.
>
I will try to see what I can find with /proc/lock_stat.

Thanks,
-Romit

  reply	other threads:[~2008-01-26 15:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-26  6:30 Romit Dasgupta
2008-01-26  8:21 ` David Brownell
2008-01-26 15:36   ` Romit Dasgupta [this message]
2008-01-28  4:20     ` Romit Dasgupta
2008-01-28  4:24       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9f29ca150801260736j205b67d2jf9b57d3ac05176a2@mail.gmail.com \
    --to=romlinux@gmail.com \
    --cc=david-b@pacbell.net \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®