From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752511AbdG1QyL (ORCPT ); Fri, 28 Jul 2017 12:54:11 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:19391 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752134AbdG1QyK (ORCPT ); Fri, 28 Jul 2017 12:54:10 -0400 Subject: Re: [RESEND PATCH] soc: ti: ti_sci_pm_domains: Populate name for genpd To: Dave Gerlach Cc: Vignesh R , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20170728163333.704-1-d-gerlach@ti.com> <6f5e2270-af5f-faa3-0ec3-66948d911c87@ti.com> From: "santosh.shilimkar@oracle.com" Organization: Oracle Corporation Message-ID: <9f2a3c84-0c79-fe15-01ee-d8302bf079f8@oracle.com> Date: Fri, 28 Jul 2017 09:53:35 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <6f5e2270-af5f-faa3-0ec3-66948d911c87@ti.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/28/17 9:35 AM, Dave Gerlach wrote: > Hi, > On 07/28/2017 11:33 AM, Dave Gerlach wrote: >> Commit b6a1d093f96b ("PM / Domains: Extend generic power domain >> debugfs") now creates a debugfs directory for each genpd based on the >> name of the genpd. Currently no name is given to the genpd created by >> ti_sci_pm_domains driver so because of this we see a NULL pointer >> dereferences when it is accessed on boot when the debugfs entry creation >> is attempted. >> >> Give the genpd a name before registering it to avoid this. >> >> Fixes: 52835d59fc6c ("soc: ti: Add ti_sci_pm_domains driver") >> Signed-off-by: Dave Gerlach >> --- > > Sorry for the noise, last patch had wrong email for Santosh and this one > corrects it. keystone-k2g-evm is crashing on linux-next at boot due to patch > mentioned in the change log, this patch fixes the ti_sci_pm_domains driver to > avoid this. I will also soon send a patch to address what I think is an issue in > the pm domain framework itself to avoid this crash from ever happening. > Applied. Should show up in next soon !! Regards, Santosh