From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C98F81E1E0B for ; Wed, 19 Nov 2025 03:44:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763523868; cv=none; b=gysU9gG8ORpVU8C337uNK529ty2T98yTEc8WZOpGARgC8+V0NJ23/IETqVw9uAFHHza3LaN63+bDcSoJ7b4pfxEeyi/V1ZsR7G8Nhh7H6j1kT8udq1MT/hgcYH6A8gzenDRjxnpl3iYE1xV7+Zxj1+KqkBNP/fwTEqeK1ZQSR+E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763523868; c=relaxed/simple; bh=z92rclzfZjPpwfYi567BVsPQsNnWEk4kPiZF/MvGZaU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uOwEnuiGNQ/B7j4bdjGFUpeLJBNaN4cBjxL/iob+fhGCOgrvrqxo/hAoBFTnMr1NaoQdRPJICrdFeV60IUbZXgjLa6DkHHTNIk9gaQTC4IaSGU/6Km43RcY/bbpt6AIhexUFuCZxFYSi/JkU6MP6qXfUuSDj3DMqdvyWmz4h1gw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=PnrLUsIF; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=KvuqPEtR; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="PnrLUsIF"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="KvuqPEtR" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763523865; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=prLgl6MqKaOVE5KSjEpfN7vkyzgDDcx68opWuG8BQBs=; b=PnrLUsIFAk5QmMhVGkXF4lQEey6jKttlSgpK4F3OF5v8Kydv0uLR65LuKy2LDWqWTI3H1a EUyLwTmahluq6HQa7C4lM4Ph4drzU9HCYiZar/DTT6kCcZP/MCChIDL8RBuri1cwXZPIx/ 5XLNzn3B4wVK0bEqiXDTtcPtTPMpVUs= Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-16-psAG46hJOAu6ZcERx3KTSQ-1; Tue, 18 Nov 2025 22:44:24 -0500 X-MC-Unique: psAG46hJOAu6ZcERx3KTSQ-1 X-Mimecast-MFC-AGG-ID: psAG46hJOAu6ZcERx3KTSQ_1763523863 Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-34377900dbcso12293400a91.2 for ; Tue, 18 Nov 2025 19:44:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1763523863; x=1764128663; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=prLgl6MqKaOVE5KSjEpfN7vkyzgDDcx68opWuG8BQBs=; b=KvuqPEtR+2g/ALqdAGHQ2caWerLVcd4lBp8Fhw77PCND1fMc5rNpsIH+2OwCa73UIT izVg2XCUTsulLDcTvjyZo3JP7rM4+B8IWplr/eNK7G3rmYluxK3Qgip6TP0K3WFW1A55 rUKhyE50Xmy0pNcCFXbJg5vqotpoXg9aEx3HwGBtS3qShYSNqZNYg6wITteMkSM2BkdY jbWCh4dwxZXbNMe1XMtoJ736JvEsnI4QBccFoVMbdaRyxmMbJwUF5b6fEc3FD+woozYc 2udf4+Kidw/BMU5w8/mLqUbrqUuC0yi9aUy7RlHrxQaK60ekUSKHbc47ZuOi3zbldwsj hfWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763523863; x=1764128663; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=prLgl6MqKaOVE5KSjEpfN7vkyzgDDcx68opWuG8BQBs=; b=m7Z9NEzoxQPPfqdWcqYYXIIt7jpO7dYasSyACXqM/IMhX3ZBCHE7j3XmwweejjBz4W x2wxP06dyWaUqzxANrbDQuNVmceRZ37ZZs7qEnqJm/NXH1jM3IY2p+L47Z/02/x8bdhi OQl5XH7ys6MJoHVuLg3JygShoUskrcmlW0f9hhe2kEiNV/xBkJZY3U/FEhN9iym1UxQH lZlDwf2Llu6BTtyOtZSyxCmXNwGF0OxPfxHVny2k1an+ijFgUJ9P5hot7SKkIo8PS7Ol JP6suErwlOhMC9DE16APtN4aJCH33H/NoG7qh/U/4areW8JE6GrVAvHaPwI0RpoJ54rj NUAw== X-Forwarded-Encrypted: i=1; AJvYcCW/fxoahKFkflRIfPAGp4jsHEqfODU1/c5GGejErSPD6KhTzHN2EYkGHkdeXQA40OeWbpolWQvKCM2Kw14=@vger.kernel.org X-Gm-Message-State: AOJu0YwowsWYxhM/50+/EkIt2+6NbcZvb3ZUbuqNTyhGOkDplg9YSwuL imueOXiunWCgTu1IjoZlxfusUItlHqcxMETmwsOX+qhB07g6/m1ZiHODqbok6jX6m5Ofan9UyWC fTIMccnQwCIP7VHvhPKuLqDNpE5u8eZ/PXgt8q3hlT876jYUQ27M1RH055Zi/dYFYtQ== X-Gm-Gg: ASbGncvdSg9jrsRQF2xPL1wU0x2E6Re8g7BLLuHv/uxg1CEgyoPl5sgTDkTN+L9eB3r WaO1YHWBXgIqdtghF/EfDxG11NOrOF7l9NMs29IWPE+SMziCHYDGqe5j5/eXGnDOOr5GUkZJL++ T+CcZjBb3E5ROUSiwg26Sw0JCL1ZgT73vyHSaSu8ELDSEbK83Mub5RejPrSE+L6+eu3HkFSIeAz 3itv8I9G3buSW0xtaUTQEx/4xKCmj0HBGKFvio3uygJUaIOsGtBFYoQbkgJ8hMWtuLuOXjesktu U+leCHNtLC5U3Su3eBEdjBk+X1C8mo2yavnNSJSGnaknRs4YGQzm9bvyqBZ8IdKBvIvK4/1+/is 6jAh0vZPxuEfioFwzOwdYGZWxjm65+yiiAPDHiyT5eUZKG/IxSg== X-Received: by 2002:a17:90b:43:b0:340:a961:80c5 with SMTP id 98e67ed59e1d1-343fa74ce0bmr20253216a91.32.1763523863002; Tue, 18 Nov 2025 19:44:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IFCPaF0H+Jz3OKZzZRR2B4LB6Uwpn49QE/z8bW2XWb72TbpGcG24DOc2ShElNamBlge7D3fiQ== X-Received: by 2002:a17:90b:43:b0:340:a961:80c5 with SMTP id 98e67ed59e1d1-343fa74ce0bmr20253190a91.32.1763523862641; Tue, 18 Nov 2025 19:44:22 -0800 (PST) Received: from [192.168.68.51] (n175-34-62-5.mrk21.qld.optusnet.com.au. [175.34.62.5]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-345bc111e72sm952775a91.15.2025.11.18.19.44.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Nov 2025 19:44:21 -0800 (PST) Message-ID: <9f2e9fdb-0101-48c4-83cc-66b291299498@redhat.com> Date: Wed, 19 Nov 2025 13:44:03 +1000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 03/34] ACPI / PPTT: Add acpi_pptt_cache_v1_full to use pptt cache as one structure To: Ben Horgan , james.morse@arm.com Cc: amitsinght@marvell.com, baisheng.gao@unisoc.com, baolin.wang@linux.alibaba.com, bobo.shaobowang@huawei.com, carl@os.amperecomputing.com, catalin.marinas@arm.com, dakr@kernel.org, dave.martin@arm.com, david@redhat.com, dfustini@baylibre.com, fenghuay@nvidia.com, gregkh@linuxfoundation.org, guohanjun@huawei.com, jeremy.linton@arm.com, jonathan.cameron@huawei.com, kobak@nvidia.com, lcherian@marvell.com, lenb@kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, lpieralisi@kernel.org, peternewman@google.com, quic_jiles@quicinc.com, rafael@kernel.org, robh@kernel.org, rohit.mathew@arm.com, scott@os.amperecomputing.com, sdonthineni@nvidia.com, sudeep.holla@arm.com, tan.shaopeng@fujitsu.com, will@kernel.org, xhao@linux.alibaba.com References: <20251117170014.4113754-1-ben.horgan@arm.com> <20251117170014.4113754-4-ben.horgan@arm.com> Content-Language: en-US From: Gavin Shan In-Reply-To: <20251117170014.4113754-4-ben.horgan@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/18/25 2:59 AM, Ben Horgan wrote: > In actbl2.h, acpi_pptt_cache describes the fields in the original > Cache Type Structure. In PPTT table version 3 a new field was added at the > end, cache_id. This is described in acpi_pptt_cache_v1 but rather than > including all v1 fields it just includes this one. > > In lieu of this being fixed in acpica, introduce acpi_pptt_cache_v1_full to > contain all the fields of the Cache Type Structure . Update the existing > code to use this new struct. This simplifies the code and removes a > non-standard use of ACPI_ADD_PTR. > > Signed-off-by: Ben Horgan > --- > I have opened a pull request to acpica to update acpi_pptt_cache_v1 to > include all fields. https://github.com/acpica/acpica/pull/1059 > > Change since v4: > Use fields directly in acpi_pptt_cache_v1_full > Delay the casting > > Changes since v3: > New patch > --- > drivers/acpi/pptt.c | 47 +++++++++++++++++++++++++++++++++++---------- > 1 file changed, 37 insertions(+), 10 deletions(-) > With '__packed' added as pointed by Fenghua, LKTM. Reviewed-by: Gavin Shan