From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19A8DC433ED for ; Sat, 8 May 2021 16:59:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DF44B61090 for ; Sat, 8 May 2021 16:59:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229619AbhEHRAc (ORCPT ); Sat, 8 May 2021 13:00:32 -0400 Received: from smtp08.smtpout.orange.fr ([80.12.242.130]:17310 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229558AbhEHRAb (ORCPT ); Sat, 8 May 2021 13:00:31 -0400 Received: from [192.168.1.18] ([86.243.172.93]) by mwinf5d16 with ME id 2GzR2500221Fzsu03GzRHm; Sat, 08 May 2021 18:59:28 +0200 X-ME-Helo: [192.168.1.18] X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Sat, 08 May 2021 18:59:28 +0200 X-ME-IP: 86.243.172.93 Subject: Re: [PATCH] rtc: max77686: Remove some dead code To: Edmundo Carmona Antoranz Cc: cw00.choi@samsung.com, krzysztof.kozlowski@canonical.com, b.zolnierkie@samsung.com, a.zummo@towertech.it, alexandre.belloni@bootlin.com, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: From: Christophe JAILLET Message-ID: <9f34ebcd-0c17-cd7f-eb08-52c6c3dc7b03@wanadoo.fr> Date: Sat, 8 May 2021 18:59:25 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 08/05/2021 à 16:38, Edmundo Carmona Antoranz a écrit : > On Fri, May 7, 2021 at 11:43 PM Christophe JAILLET > wrote: >> if (IS_ERR(info->rtc_dev)) { >> ret = PTR_ERR(info->rtc_dev); >> dev_err(&pdev->dev, "Failed to register RTC device: %d\n", ret); > > Following the recent conversations, I think it might make sense to do > dev_err(&pdev->dev, "Failed to register RTC device: %pe\n", info->rtc_dev); > > Is that right? > Yes, it is right, but it should be done in another patch. Would you like to give it a try? CJ