From: Joe Perches <joe@perches.com>
To: Antonio Borneo <borneo.antonio@gmail.com>,
Andy Whitcroft <apw@canonical.com>,
Dwaipayan Ray <dwaipayanray1@gmail.com>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: exclude gerrit's Change-Id line from commit description
Date: Tue, 12 Dec 2023 11:02:39 -0800 [thread overview]
Message-ID: <9f361dcd86507486fb2a1a1540957f4ad4919af0.camel@perches.com> (raw)
In-Reply-To: <CAAj6DX0SpA0jFtKT0Pu02BuXsF5_=UG0N4H8iyB9Rf-gqK50dA@mail.gmail.com>
On Tue, 2023-12-12 at 10:53 +0100, Antonio Borneo wrote:
> On Mon, Apr 10, 2023, 12:03 Antonio Borneo <borneo.antonio@gmail.com> wrote:
> > Checkpatch rejects patches that have empty commit description and
> > logs them with:
> > WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
> > But if the patch has a gerrit's Change-Id line placed before the
> > line Signed-off-by, then checkpatch considers the Change-Id line
> > as a valid commit description text.
> >
> > Use the Change-Id tag as a marker of the end of the commit message,
> > thus not counting its line as part of the commit description.
> >
> > This patch is not relevant for the Linux kernel development process
So don't expect me to pick it up for the linux kernel.
You are of course welcome to branch and include it in
your process.
prev parent reply other threads:[~2023-12-12 19:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-10 10:02 Antonio Borneo
2023-12-12 9:53 ` Antonio Borneo
2023-12-12 19:02 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f361dcd86507486fb2a1a1540957f4ad4919af0.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=borneo.antonio@gmail.com \
--cc=dwaipayanray1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®