From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E49A041B358 for ; Wed, 8 Jul 2026 14:05:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.125.188.122 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783519510; cv=none; b=rJXqc73Jl6AkavsyCtek/wRFQaEGF4Vb1igxwiqQ3oqmltWYnrgYfmvN40+1PxSQa3NGV07BycYSTMEh8SZjW8PbF8dV0zL9fQG/mzmGA1+wI1vmFof20BSr+xH+2on0WeMZHHYcxNcHmqP+Dfax6UtIXtjekLid/XaDIUYSNRs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783519510; c=relaxed/simple; bh=iyLPP8243aiHzNrJYpf9xTthzZ+w9qrqGZqyfvhH8zM=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=hj9DcZt/+Vsjsr3WL3sFZ58PsdRPxG/M3zfKf0yV1AzxZZ5m0jb77h/4kJVEAJH3Ua7HIA5quIJkU2gisAJi/+MB2th/UVHJ//cpD6f7Ch3JfdrDeArFSoUd1IPXrgayGc9BbrXQi0HIBqkhy1nHdu28072SyqebJmWZYq+Spl8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=canonical.com; spf=pass smtp.mailfrom=canonical.com; dkim=pass (4096-bit key) header.d=canonical.com header.i=@canonical.com header.b=ey5e5qj5; arc=none smtp.client-ip=185.125.188.122 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=canonical.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=canonical.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (4096-bit key) header.d=canonical.com header.i=@canonical.com header.b="ey5e5qj5" Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 62CEF3F5D9 for ; Wed, 8 Jul 2026 14:05:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20251003; t=1783519507; bh=ljrZQ/jSIAbiWPJR1OVwdq7B6Ha9nD8fvWtgiIGymkA=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=ey5e5qj5bcLflOUkFbflXjm1waIryecE49czN+QnoehddnKVk5niuDfYFZf3qfdoM Fp0Mtz9/zYmWWkJNKA182F9AdqgwLK2UvSYoHGgTnRzqFvl/T4nkx0uBW353S31bfv NFZDoRCC6jn46oHVckI61qXlbVtcCyI+WPVkOZ2bvRw/dqJXZV9RwPx5RAPJktcNzJ Ct317CUTS+17zVZ+wYjAt1JubjMwz7lJW4YYqg4h7vz4ANX4D+lobVTR6RYmb1FVcn E9S7/sNeqc9MZo3RafnUS7uW3u58XFiw7YyTalCW/39eF5icpqCXk+7M5d2OK5MaGP uuvmXBAYGOKYCDIBKYKz7+YhLDnpNeE72ySowBM9rTqXWg1+NEFDU31RXuEACGC2nP fFjO+d4UGu4FSch1yDtsJx1CU+hBsSmiJUs7NAj2STuN2dxaPi0R+abhq8kNe1bLsB RY0x1zwHLYb8nF40dsIDY39EP8qNcubfmORalb0QQ2yGSbrahYLz9RIGxkuC64UMEA 20B1DREQm7XHxW8Wk/5pc+6Ir+WWby1fdRlUFjbcsR/EWQcHL3p2BtC0/TBy6yad+V NIHZh3c2pkXsHiZKPnj0PV1EaeCqZvizefdAtIBkYrVSgJ7yC0YFCrJ0fS7vRALTi1 dzlaQYrE1ydfz6Ki8vEa8kc0= Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-c88e0d11a3fso719291a12.0 for ; Wed, 08 Jul 2026 07:05:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783519506; x=1784124306; h=mime-version:user-agent:content-transfer-encoding:content-type :organization:references:in-reply-to:date:cc:to:from:subject :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ljrZQ/jSIAbiWPJR1OVwdq7B6Ha9nD8fvWtgiIGymkA=; b=AZKmql3vQI/ntQbIjp1RNRRcq2FPBKBKANvWXAJNKESuUFH3vwSrW2JJa33/w3e/Xk kA3A1xTMS6FMPeiDGUjImJVKeBs8XpA0axenuPMTvdsTuwGw+tPHZkRcrQar5LbZRaVl VdHJnxw53ZTbFtVaW+rhed+cFn/d9W16eznET+R3dFjNdTTDN2YMKukL8WeWQpI0S2oW dUSJWPaUL5/9+ejWPw3k2GxLGHR6+omd/wS3+ESFgDi701dQ3OJa7PD0dBfVpolD+ZIJ fWaMI2wOipVGz0fXMDPaCa4iCJZpe37DaNBBxX1nhja1JyIPlbHPtn3RTKtAPHjRf4v8 g4hA== X-Forwarded-Encrypted: i=1; AHgh+Ro4B3koOe4GdPrOQS50RovaS2ZcAbp4VvRV1l1Wqz7ZVa2Doeuzh+HaH7fQJV6WzDb4ofnRZWeZ1/Jtexw=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2qQJS7yCqUCg4p7zl9QXNURPBquJipXSRb4gOgjRaUmknQr4i fSd3Vvs414mBb24cBmhoku1LDiydy6oRsZOxzIAOh47DBJ7G8DSubtrmuEwf+yxCfj07Kn3xLn8 T7q6ntv177VgyvWQmXBaTgUw4SW5AI9f4v56fSSKUSIvoYNpegwAyu0d8VjNxpkqMuGeLtbf69F pZyM1qOa+a9+aFbYTq X-Gm-Gg: AfdE7cliLbIeulgyf3OqkJGNhOZtyqjKWz5CeSt96cwJagbDgjb7VfB11TIthJMvNbv YJr5Uube7HCrn+TW4OriCAKTKkSBS092LXk5v6zofXj+b2NH6dh9LlkQ5ZZ+0uP1+hR6XI9G3Lk AbFe+xyEXdFxua8w5cxJ5R725/BnLX/sR4Yosv7pNcudzpfW/EOpNyNI/ssFtROxtamn15LwGgH fe+MpMMsqUNatTf8Wr+uWsg0qLcZ83UoASrBbJhmgX/CZ/7shBJQTdowjEDgAw08RzdlzPjlC6P fj4K1l/BmJM5WUGSjc6hsdUFfDiZhBUi1O0mRtzqNpuq4HQOE+z8g44M3knDZ3ycFk1sNQ1B+F5 4gsjrpvjkL0MJJSiqJc7E/o8m1wXhxNrsJJyu/AaaSdhZK9cPiVP+9IhI X-Received: by 2002:a05:6a20:3c8d:b0:3c0:9c19:b277 with SMTP id adf61e73a8af0-3c0bcc9d22fmr3874595637.69.1783519505913; Wed, 08 Jul 2026 07:05:05 -0700 (PDT) X-Received: by 2002:a05:6a20:3c8d:b0:3c0:9c19:b277 with SMTP id adf61e73a8af0-3c0bcc9d22fmr3874561637.69.1783519505539; Wed, 08 Jul 2026 07:05:05 -0700 (PDT) Received: from [192.168.0.106] ([138.36.35.75]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3118ee6091dsm11179003eec.14.2026.07.08.07.05.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 07:05:04 -0700 (PDT) Message-ID: <9f37884fc0922254c3d3708794cf1272f4fabdfc.camel@canonical.com> Subject: Re: [PATCH] apparmor: use SEND_SIG_NOINFO instead of NULL in aa_audit() From: Georgia Garcia To: Oleg Nesterov , Bradley Morgan Cc: apparmor@lists.ubuntu.com, jmorris@namei.org, john.johansen@canonical.com, linux-kernel@vger.kernel.org, paul@paul-moore.com, serge@hallyn.com Date: Wed, 08 Jul 2026 11:05:00 -0300 In-Reply-To: References: <65E9B858-C580-41A3-9B39-B383ED5F0ACF@grrlz.net> Organization: Canonical Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.3-0ubuntu1.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Sun, 2026-07-05 at 20:48 +0200, Oleg Nesterov wrote: > On 07/05, Bradley Morgan wrote: > >=20 > > > SEND_SIG_NOINFO is defined as ((struct kernel_siginfo *) 0), so passi= ng > > > NULL works, but: > > >=20 > > > - this works "by accident" and looks as if the caller doesn't underst= and > > > the signal sending API. > > >=20 > > > - more importantly, this hides the usage of SEND_SIG_NOINFO from grep= , > > > and this is really bad. > > - also drop the now redundant (void) >=20 > Yes, but the "void" cast was never necessary, I guess. >=20 > and just in case... To me the usage of SEND_SIG_NOINFO here doesn't look = right with > or without this change. Perhaps I am wrong, but please lets not discuss t= his right > now, this connects to other cleanups I have in mind. >=20 Yes, I agree. Perhaps SEND_SIG_PRIV would be more appropriate here. > The purpose of this change is to make aa_audit() grep-friendly wrt SEND_S= IG_NOINFO. > And because send_sig_info(NULL) looks "just wrong" to me, no matter what. >=20 > > Reviewed-by: Bradley Morgan >=20 > Thanks, >=20 > > Also, feel free to CC me in signal patches, so I can review, from you > > or from others. >=20 > OK, will do. >=20 > Oleg. >=20