From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B34E83803CC for ; Thu, 22 Jan 2026 19:26:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=198.175.65.18 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769110014; cv=fail; b=huYXnnXdVqIhmtmHqqlF0C6aWfGzs1T0s59P8PwHebV9JqWIoMr/DmEEJjK33yKhYF0ONNpNMXLvlvP4EqhPBpHV1YQjWRRoep9HGlsyNDxjHezIv8qLGVL8gFrWIpbhdlRgopTAH1HY+iEy2DvtO5jWCLIXkNxJ4cdI5Sx5SqE= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769110014; c=relaxed/simple; bh=LqRU1mXt1jTXAs7aZeDE+tT7jaQyZY4QJ6GyUR7NuZ8=; h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To: Content-Type:MIME-Version; b=O0RmX/1Md69NYSE1G+I1d9hpc/PqWWV9d0DQslhXW7P6UHY9fP5RFBtTKvddH9ERP5/ZMJaEMPOmU1shJS6ScAP67F/fTEfVIjrUCyVDgPZaVXe9hMaisvos9fbthL5mp6/4dKauOXhldZcB2QclFO5FktImWm1+EC7ypV3OCj8= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=ad8gebHd; arc=fail smtp.client-ip=198.175.65.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ad8gebHd" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1769110000; x=1800646000; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=LqRU1mXt1jTXAs7aZeDE+tT7jaQyZY4QJ6GyUR7NuZ8=; b=ad8gebHdSFoB1ol9sRjXaxi4AqHv5njntNg0H4FaIUoM97V1ZUhobZMS XiXe30iJ1OQopxgNr3llzSRRw182V+k6hdNXmMai1ohSF+sO+k4ySu0pw d3WmwvVDbyktaK6BgyTaqybI/0nNq4boxx+Cz/Ih89Jrkhrn/PfhNtfeo sLJAy/t3laNj2uWA7pyOKDKY8HVsj10YcMws23LUqbmDtcIkEOttT1qNo B4G99fBwGoRLhrCdL19k3pVuveyRYR5skM7WGq1Vhe/Swz98lrkFyyk5L GQana3AaA7GzupS2fvI2DgHvkDmbNR9NIIamzPRxjpiGsxwzEjM3umdkm g==; X-CSE-ConnectionGUID: bnCosTRFSSK88XTz/FS2TA== X-CSE-MsgGUID: Cgd4bZuRRZCAppiuriOGnQ== X-IronPort-AV: E=McAfee;i="6800,10657,11679"; a="70410618" X-IronPort-AV: E=Sophos;i="6.21,246,1763452800"; d="scan'208";a="70410618" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jan 2026 11:26:36 -0800 X-CSE-ConnectionGUID: eweKo/vETBSKnR740MgFTQ== X-CSE-MsgGUID: ou0oXPfrTS6Q4xzT4BvU2g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,246,1763452800"; d="scan'208";a="205935938" Received: from orsmsx902.amr.corp.intel.com ([10.22.229.24]) by orviesa006.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jan 2026 11:26:36 -0800 Received: from ORSMSX903.amr.corp.intel.com (10.22.229.25) by ORSMSX902.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.35; Thu, 22 Jan 2026 11:26:35 -0800 Received: from ORSEDG902.ED.cps.intel.com (10.7.248.12) by ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.35 via Frontend Transport; Thu, 22 Jan 2026 11:26:35 -0800 Received: from DM1PR04CU001.outbound.protection.outlook.com (52.101.61.1) by edgegateway.intel.com (134.134.137.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.35; Thu, 22 Jan 2026 11:26:35 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=LQ3C+K7ELsoDrxp+GGnWU3T7hRGbw2g5PbFx8LvTVkYs6wu2cBa/DoeroPRVsXdqwtxcs6ZwXdrpjRROj1St8B2wXt5xRC1mCGq+mxMPiKIB1cXgbS+nW3bDehhtZ6/M4Py4EWRh5qHtRkI1FZZGYLBtE0LBuSTY3MoPS8bwk6Rct1cUp0ofy2AdWji/licejF7i6MBBvJy2C+2e3JU2qAxw2f+EHM0jxGW5ZKfn4xk+VUtsGmJ7x6QyxkPeMiETkSr6acAS5UrG4lNGWjcbutqkuR5FADybQY5qR9Fu5Wf7du2jZQvobrmwGGjMJHBt6MAZE6zcHtvVOWsLSXPdeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jC/xasYYzZVu71AaVkTkZyJ4NRUPAThdEfRQgbWMM2Q=; b=Z+zD7z7Ove342wLwvEbWPxrsXIuCeLgZfrUkZ2I10H3bAlpmPhpF2BiGRFeQbjYI415i8YSrIWhL8VPxCxkGCFLez5vivUBuA13zVmZ5OrcsHp8LHCofG9lYwCMHqfVd2YzPF9W0HiToqkL2ZYvu4r3OsurPUqqtGMMMBalExJFhuyKovPZ7YOkYeMNHaSPsXeCwcRlDfcCl2BErRKQGs1iS44cN6YdqnfTsgUsMgZJefreNz+65UNBmFTddbgOv2yGKOIycPiQixLNOpX4Y68XTlOMjIkxTmFFVlDczgDCekcGgEX6To0rsAZiKxPL5hHBU9gJniVZ+6XhzPaMbJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7997.namprd11.prod.outlook.com (2603:10b6:8:125::14) by LV2PR11MB6072.namprd11.prod.outlook.com (2603:10b6:408:176::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9542.10; Thu, 22 Jan 2026 19:26:20 +0000 Received: from DS0PR11MB7997.namprd11.prod.outlook.com ([fe80::24fa:827f:6c5b:6246]) by DS0PR11MB7997.namprd11.prod.outlook.com ([fe80::24fa:827f:6c5b:6246%4]) with mapi id 15.20.9542.008; Thu, 22 Jan 2026 19:26:19 +0000 Message-ID: <9f397b71-54c7-4cf9-8c93-515f909404ae@intel.com> Date: Thu, 22 Jan 2026 11:26:17 -0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/6] x86/microcode: Refactor platform ID enumeration into a helper To: Dave Hansen , CC: Borislav Petkov , "H. Peter Anvin" , "Ingo Molnar" , Jon Kohler , Pawan Gupta , "Peter Zijlstra (Intel)" , Thomas Gleixner , Tony Luck , References: <20260119195047.86E3C696@davehans-spike.ostc.intel.com> <20260119195053.E0850F99@davehans-spike.ostc.intel.com> Content-Language: en-US From: Sohil Mehta In-Reply-To: <20260119195053.E0850F99@davehans-spike.ostc.intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SJ0PR13CA0070.namprd13.prod.outlook.com (2603:10b6:a03:2c4::15) To DS0PR11MB7997.namprd11.prod.outlook.com (2603:10b6:8:125::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7997:EE_|LV2PR11MB6072:EE_ X-MS-Office365-Filtering-Correlation-Id: 0d185e59-7006-439d-772f-08de59ec1ed0 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|7416014|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?SmRXNnhLdVRBOHhQazBjN0E3bHArVmhTRG1iNjBZdVo0ZVdHanp0UnlhTWY1?= =?utf-8?B?c1hzaWo3OG5yV0Z6cyt6VkhReGM4SkdXbWZobzBPTUhRcURQYWdtY3ZFY1lj?= =?utf-8?B?WGR0OXZlV0ExeXRMQUV3TWtnM1pCZ1VaTWYyVVU4aDNPZDg3bWZiSFNkSjIv?= =?utf-8?B?aVRsdXdac2lKNi82ZFFzMXFMZUhmOHg3NVphOW1pK3BMSTc2NlJtQ2d6dXBv?= =?utf-8?B?RUtCZVNoMjRGemRZTHNKQS90YVlxYngyR1VHWkNUY1V3TmlGWWhIUXlUQkYr?= =?utf-8?B?c3VmaDM3aWRPMFpmTkFxd0g0Y29KSnFpRnFoMVNqaWRRYllvS0VxZFVielFh?= =?utf-8?B?aTc3VTZVd0NpK1ZVOHJQeXg3VDVrZnJUVDlicktyZkRSRlRUdWxQTElYd0pO?= =?utf-8?B?MjlxdEdZUmQvNFRoRnlya0xmaWRHVWhnQkdSM3htQUgrVnUySE5IVytBR2sz?= =?utf-8?B?Yy9rVFNYTzVINVkxZm1Ndy8zTmJPY0h3Y1B0bXpjYVNseVFyeU0vaGd1a25E?= =?utf-8?B?S0phVUs5Q3Flb1l0UlRSLzU5RzdabUtnZndlVGNNWmN6RzhZQVM5RHNFcnkx?= =?utf-8?B?cjlBc3BEd25TdjJyTUY5SWlNTlo3ODIxSDkvdm9TSEdOUTVVZTBYRnY5NWxY?= =?utf-8?B?OFozajNwenJvZDNNMDI0cFlhQVpaQVZyUTVvMStlWndTQ0pYSFhwR3UxcERk?= =?utf-8?B?SE84WTk2UVFZbHRDRzN6bzgwTG9PbWZPcTcyOGk3OVFtU0xJYlVGbkRWTFQw?= =?utf-8?B?VTYwdWZvSVF0R3FZN2ttOUJsUlAvSkw2d05xWUorUjgxQ0t4UVNKWHpyckZO?= =?utf-8?B?djFFUjdhd0Q0ZW93L2pWUVNpVTJOeVhwSEczdGErbDZwRjhBM2ZRZTQ4ZGNU?= =?utf-8?B?Wkhod3ppTTdETEVhSHRRNXVKaEIxRXVqcHVRUmdhWWMxM2pLQ0ZqZTk4cno2?= =?utf-8?B?UGd3Yjc4Z0VPanBpa3ZaVUZ5cllEVmRJZmdTQkJvZlZCUkE5N1E3ckN0b1Ev?= =?utf-8?B?VWRqNlV2Z25lOFdJSzI2Y3I1WURIM1BSQXB6b25aRTZzak40K254bWkxVi9O?= =?utf-8?B?S29CaU91MzhCbHVkVG9HdzBBZkp0Z0pJYXVjd3JUTTlZRFlSUzJiRytQNzRw?= =?utf-8?B?TTlFS3NvM3luckdMMXdiY1dnN3lmMjBJZGxNSmJ3Q2NycGdYMEprT0t6Zld0?= =?utf-8?B?bVJsU3Z3eFVla3NKMUU4NWNqODNXcHpHK3VEakl6Z3JUQlI4elJrMXlRN1Br?= =?utf-8?B?eUVDbXp4L05ucGVISWFCOFNZOE9PMVM4bjRWbk9vdUJTdTFMOGZMYVBBNXYx?= =?utf-8?B?K3l3WWx6VGtzUE9TdmxjclhvbW9mT01NeWxiZnZYblJKYVcwTHpFekltNVp3?= =?utf-8?B?WHZpZWFIN0s3ZUJZMk0vWnVMWkNmS2JqNlMvSTFxdDkybVRXSDdFMSsrRjdw?= =?utf-8?B?UytSTjVhWUJVQmplQzhsSFVHQkplZmoxM1ZtOGg0VkhxZXJYeEtKTy9PVE1p?= =?utf-8?B?dUhnRCsycyt6djEyd1g5Q2JzdFRqcFk1c1FjOFc0UWNLQmhYV285RHU4ajRj?= =?utf-8?B?MVBvakF2NkVTbjV2VnYzcUEvTzUvcmovRkQwR3p6UCtOckdHYlh6MFlCRTRk?= =?utf-8?B?Mm12ZXNGZDFWQm9IczZRU1hRZTRmTU1IRmVQQzRkY0M2NC9xZ1NvSi9URGky?= =?utf-8?B?aG9lN05kdGJrc2hMbDFBbFZxRHJDRldyTGROdkVxSDZ0U05SYzhUb0RlUis3?= =?utf-8?B?aTZYN21ncmg4My9Bc041SHRra3o1K1Vqd0VjZG04ZnJ1eHBPWHo3dm5tSmxC?= =?utf-8?B?TkZISEZZQ0NSV0pPY2NWbWVOemR2TGJheHlmbmVvekpPOGtMd2YyLzhmVU4x?= =?utf-8?B?WERCNGRYUld1c3NZU2RGMzBBMHRYQmFrcCtWRFMwckIwSmE5THQ2MnVnZGds?= =?utf-8?B?VE1kc3ByNkxKekpSTzFWaWY5QXRpVzFNVlhiL3hBODN5Q2tKN0ovd3Zsd1dn?= =?utf-8?B?aXFtNWRLV0h0OG13NjFPaCtleVRkVDNFWmtvZk9jVnBsdTU0V01MMWhmRTJ2?= =?utf-8?B?dEhBVXlZWTdIUk5hL2JsUnpqRVFHbFI2d25RaW9yMmRmd2FUWlZ4bUptTmlS?= =?utf-8?Q?E+hQ=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR11MB7997.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(7416014)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YmRXVVVEeXlvOEVNM2VSeDdHZWFYeE1uT0VrMFRYZGZ4T2Joa2h4bmw3Y1Nt?= =?utf-8?B?VW41SGZQemE4aWwyN2JqTkxMYTR5SmdKcVdTUlN4TGowMmRzd0xqNDBZNzdQ?= =?utf-8?B?QXVtUThlTmVWdFRJenFraWJxNEh5c0tBSjEzcWMxT2pIZ1ZYVUZBMjNwVE5F?= =?utf-8?B?ZllYOE83NEViMTQzUklCdWtNank2QVhjRmpIcE9ZdlNWd3NuaTBSVTUrR1JU?= =?utf-8?B?cFR1SkNTZytGdDU2VjdHUk14VytvRGR6clNBLzlSL0dBcFFvdDVyNUR1QndW?= =?utf-8?B?QlJYTzdEbktzWDBaWlZDWkh5cmxXZEpwaXQvRVF5TFNUZ1pvTS9QVXgzeXhj?= =?utf-8?B?N2lxbWhvRVdYMDhCRUt2RlRHckRXNFJTR0VHdUZ0dTlFSU1pUWkwY3dCUW5i?= =?utf-8?B?Z0lmUDhIVGFJWU1UM0tVZzNaY2xnWk4xQjh6YVFheHdvdVIxS0kzYXczZDh3?= =?utf-8?B?WXQ5L2RyUDNFTlZLUk5ZT1pTRllnT245cnF5aW5Vcjg1VTU5c0RlMVVqOG1O?= =?utf-8?B?c2YrUHlkM3lkbFZxbjF2M3pLcnFUcDdVR0E3Z21XUEphSkRIRVdCMElBeXM5?= =?utf-8?B?MC9oQmRsd2hwUVRDeEhpNFlScHkxd1VlaCtJOVllcCt3enpxZ0xPNm1GOFUv?= =?utf-8?B?TmExTVJlTmdWOGFGKzVQbTk3dTVteXhSRmxyYWMvTmZzRERyaGlKRnlSWDA2?= =?utf-8?B?a2RodmJQR1I0K3IraFZBZFdDYUF1NEtqWjh4SzFPQUFKbmNybjF0c2Z2M1JO?= =?utf-8?B?c0dVL1BjdmRUaVpDVktCYUtyOFV0NklzRE5SbVY0a1dXUEpweWZZK1B4Q0hy?= =?utf-8?B?UjR0anBmNDErS1FwMnVQYjZkd1o2UDB4K2NkUGdQRGRUdGpJdXpMSERLdnJr?= =?utf-8?B?ZFRoQWE0Sko5TWxSZnRabUJrR0g2dVRWMVMvWlF4d3pVVTE0cjlPTGFkTWtG?= =?utf-8?B?N0QwY3llNkdkc0s4SzBBMkpKelJsSGRrZXJZNittVTU1bW9zNmdSY0xDM09R?= =?utf-8?B?ekxsZmhpamlNUGNEYTZNaFV5RmVQY3NMRmRQZ3h0Z3Ryb0FDLy9tMjFCSDd1?= =?utf-8?B?L3AwUmJ1cGhjVmFzclhEZzc0OEpUbUJ2NER2MkpSUzhuRXoyS3hFdTUzOGtl?= =?utf-8?B?YVdyNko5cU1pYjBCQVBqN0RwMUJKSU5WL05zS09jVWlUZVM3TlUyUXJjRnFE?= =?utf-8?B?K21JNlNzdFNKcEsxSVNiVEJrRk9ZbVBqZGw1QnZHbXZ2NHhYVTFYQUhyc2hZ?= =?utf-8?B?RHpYOWd6VjJKRUFUaHZVMFp4YlVYWWNzaUxwTnA5TmtOL05aMmhDRGJORjdR?= =?utf-8?B?dDNQaFNIenhTSVRIWjB6RWVPaldpQnFwLzFIZXY3eWZpdnY1WDhSWmUyMW4v?= =?utf-8?B?bDRselp3bmpGVnB4QUdjMWhCa3J4S1pGK0RWRGJncTJOcFJVSkw0OWZwc3RR?= =?utf-8?B?YkhBTXFhaXBPQy9sVmhPR1RFL1A3NGtsTlBJTXlEOThpUnhxUnppSmlCTmlQ?= =?utf-8?B?ekp5OFc1Z1VXaURVRDFwYzBIaml2aHZhYnpQNzVHaVpLK0NFTHJOLzQyN3A1?= =?utf-8?B?TGt2TU1NYmV6M205MDRMekloaGMwME90WVZhZUYvNmNwSytGRG5rb3BMbnIw?= =?utf-8?B?V0tHeTZZUUQwQnFuTmhzSGt3NDdDSjZFcHZRaGJnVFlUbCtreGFzT1ltQ1p4?= =?utf-8?B?bk9zMnNGVWE3ZXJCMmp5cit1QnFYNEt5aVBxRWlUM2kyNGNCaVlkSzE2RkxC?= =?utf-8?B?QitTVVJUL3pjZnZUQWdWS1VqY01CdURlWTkvVmtVVURlckluQzlZeXdsay9I?= =?utf-8?B?TVdaV09sYUJScHVwSDRBeTAvVFJyenlveUJYTFdVaWxhR2ZPM2cxRTExU3JB?= =?utf-8?B?ZU1Pcm1qNURabmpXdHp2bWFVbko1UVdmcG1vNTU0Rk9pak15L2V1ekI4RFov?= =?utf-8?B?YXFvZ0MyZU8yRzBaT1RZWWk1c3NtZXBVSG9wbjZOT01WcW0xVE8yQ2ZvVGhV?= =?utf-8?B?SXBWOStzR1JOdHA5R2M2ckFzeUtuc2grM1JsUWRtWXdUbE4yK0Raejg2by9r?= =?utf-8?B?MGE3dUNlem56cnoveGRTVExycmJMMUlXQmlmN2NkU09RNGhoZHcrQnJsNWxY?= =?utf-8?B?Y0FMUUMrKzFEdlhscUozenRNN3dHUlhzemVibS91Y0pnOVhsNkFDeFVXM1hQ?= =?utf-8?B?dWFBcGtDNS9KWG50bVh5cDVGKzk0eG1Ub3hTRmloS0JJbVlnNjUwMDFOK2Jj?= =?utf-8?B?ZXJnZGczQlJ3Q2xuTTFPMXlmSnZJcVI5OWNKaC96THpiK1V2SlVPdTRKWVBi?= =?utf-8?B?cmJBMWZiekV3b3I2UFhQbXRoNDFkNitESGNGTjdFVnNMSDZNZnBXUT09?= X-MS-Exchange-CrossTenant-Network-Message-Id: 0d185e59-7006-439d-772f-08de59ec1ed0 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7997.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jan 2026 19:26:19.9201 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hMP7tkRjiAfTQP7JZR9DBFOc6/8xExZoe7j5Vfg27pvhohcjYyV317XaoPtRu8pFbedlGl3OEFu/cUUiCgOWHg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR11MB6072 X-OriginatorOrg: intel.com On 1/19/2026 11:50 AM, Dave Hansen wrote: > +static inline u32 intel_get_platform_id(void) > +{ > + unsigned int val[2]; > + > + /* > + * This can be called early. Use CPUID directly to > + * generate the VFM value for this CPU. > + */ > + if (intel_cpuid_vfm() < INTEL_PENTIUM_III_DESCHUTES) > + return 0; > + > + /* get processor flags from MSR 0x17 */ > + native_rdmsr(MSR_IA32_PLATFORM_ID, val[0], val[1]); > + return 1 << ((val[1] >> 18) & 7); > +} Would it be better to use a *native_rdmsrq* and proper #defines instead of passing the two ints and operating on them using magic values? I understand the desire to keep this bugfix series as minimal as possible. But doing this now makes it easier to understand this helper and what it is returning exactly. That would avoid the confusion in patch 4 between x86_platform_id and platform_mask. If you prefer to leave the helper as-is, at a minimum, should we rename it to intel_get_platform_mask()? Also, the variable name in struct cpuinfo_x86 should then be x86_platform_mask. > #endif /* !CONFIG_CPU_SUP_INTEL */ > > bool microcode_nmi_handler(void); > diff -puN arch/x86/kernel/cpu/microcode/intel.c~refactor-get-processor-flags arch/x86/kernel/cpu/microcode/intel.c > --- a/arch/x86/kernel/cpu/microcode/intel.c~refactor-get-processor-flags 2026-01-19 11:38:08.780892582 -0800 > +++ b/arch/x86/kernel/cpu/microcode/intel.c 2026-01-19 11:38:08.783892696 -0800 > @@ -123,16 +123,8 @@ static inline unsigned int exttable_size > void intel_collect_cpu_info(struct cpu_signature *sig) > { > sig->sig = cpuid_eax(1); > - sig->pf = 0; > sig->rev = intel_get_microcode_revision(); > - > - if (IFM(x86_family(sig->sig), x86_model(sig->sig)) >= INTEL_PENTIUM_III_DESCHUTES) { > - unsigned int val[2]; > - > - /* get processor flags from MSR 0x17 */ > - native_rdmsr(MSR_IA32_PLATFORM_ID, val[0], val[1]); > - sig->pf = 1 << ((val[1] >> 18) & 7); > - } > + sig->pf = intel_get_platform_id(); > } > EXPORT_SYMBOL_GPL(intel_collect_cpu_info); > > _