Re: [PATCH v5 3/3] scsi: ufs: core: Add OP-TEE based RPMB driver for UFS devices

[Bean Huo <huobean@gmail.com>]

On Thu, 2025-10-23 at 15:53 +0200, Jens Wiklander wrote:
> > +       device_id = kasprintf(GFP_KERNEL, "%04X-%04X-%s-%s-%04X-%04X",
> > +                             dev_info->wmanufacturerid, dev_info-
> > >wspecversion,
> > +                             dev_info->model, serial_hex, device_version,
> > +                             manufacture_date);
> 
> 
> The device ID is part of the ABI with the secure world or the firmware
> we're serving. It might be worth adding a comment so the format isn't
> changed without understanding the consequences.
> 
> Cheers,
> Jens


Jens, 

I can add, do you have suggestion for this reminder message, for example:

/*
 * WARNING: This device ID format is part of the stable ABI between
 * the kernel and secure world (OP-TEE). Any changes to this format
 * must be coordinated with firmware updates to avoid breaking
 * communication with the secure world.
 */

or 

/* Device ID format is ABI with secure world - do not change without firmware
coordination */



or ?



Kind regards,
Bean