From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3624D31960E for ; Mon, 5 Jan 2026 11:12:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=210.118.77.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767611562; cv=none; b=e/5i2i+HtCfWO3+RCd8pBY7XhN/63Sq+EkbB9Fuo4Rx7jTUWI4TRicKWbsfdAANFH002WX2Y+piIw1kscd4rsVgf6riZS3NdcC0c4e76UxhL2ebreUw7Tg0uBQFbbiYbty4fwa9dhRklLn3bxhDo8XNfJWQ87FLUmCqVI621ExE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767611562; c=relaxed/simple; bh=mNewUV/Qm/qNRfLwU755Kzj4Y9Ati2vGuno1/0dYI40=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:From:In-Reply-To: Content-Type:References; b=CfvJJv2JUJI9uYxvTDP3kh3uo231osHe/efoc7qFQzJmQBd1OBKtGGIYqMovBE2Rv8LWbhiLfkGtSbbfrPLU8t+uOqcYUngET3XM05ljOMKWj/cod3rWTXXxoCox1/cHhxOswrol4GOQDTzrrK5tr/0tF3K/ApGWPQRMIU5IDDI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b=VR38Sw6p; arc=none smtp.client-ip=210.118.77.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="VR38Sw6p" Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20260105111238euoutp02a9c62d531f0ab10a9df0bb692c9369d3~H0Vjb2LHn1585415854euoutp02e for ; Mon, 5 Jan 2026 11:12:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20260105111238euoutp02a9c62d531f0ab10a9df0bb692c9369d3~H0Vjb2LHn1585415854euoutp02e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1767611558; bh=yA1n6l6IjZIIscNu9XWHxYEGswZKd9Ghbaim+fa1Ex4=; h=Date:Subject:To:Cc:From:In-Reply-To:References:From; b=VR38Sw6pGienk3rtUSiA3YhH/tvrzbmXtAdHwvbrDUwPCXDpVZbj1W2gc8R1ikUFK t1YH5UCfPpKpm77xLeJjNrQ6xb36TSsNw9BFr2ko5rhnJywwaS84OmW6VhX/Flbmdi 11fRZZpJ2luQLj45Wkwik8lKXMaAuyEEE1XYonbg= Received: from eusmtip2.samsung.com (unknown [203.254.199.222]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20260105111237eucas1p13c973db6e3ce59f5d118bb43278ee11b~H0VjCMJnf3267732677eucas1p1k; Mon, 5 Jan 2026 11:12:37 +0000 (GMT) Received: from [192.168.1.44] (unknown [106.210.136.40]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20260105111237eusmtip2dc2b37b9832a1d7167ae6abaeae52e23~H0Vie2HjC0892208922eusmtip2V; Mon, 5 Jan 2026 11:12:37 +0000 (GMT) Message-ID: <9f45c967-4bb0-4b42-9d5f-6bd338eba0db@samsung.com> Date: Mon, 5 Jan 2026 12:12:37 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] rust: pwm: Simplify to_result call sites and unsafe blocks To: Kari Argillander , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Miguel Ojeda , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich Cc: linux-pwm@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org Content-Language: en-US From: Michal Wilczynski In-Reply-To: <20260102-pwm-rust-v2-2-2702ce57d571@gmail.com> Content-Transfer-Encoding: 7bit X-CMS-MailID: 20260105111237eucas1p13c973db6e3ce59f5d118bb43278ee11b X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20260102075215eucas1p2919c420a042781059f32d0747cd86baf X-EPHeader: CA X-CMS-RootMailID: 20260102075215eucas1p2919c420a042781059f32d0747cd86baf References: <20260102-pwm-rust-v2-0-2702ce57d571@gmail.com> <20260102-pwm-rust-v2-2-2702ce57d571@gmail.com> On 1/2/26 08:51, Kari Argillander wrote: > Remove unnecessary temporary variables around to_result() calls and move > trailing semicolons outside unsafe blocks to improve readability and > produce cleaner rustfmt output. > > No functional change intended. > > Signed-off-by: Kari Argillander > --- > rust/kernel/pwm.rs | 47 ++++++++++++++--------------------------------- > 1 file changed, 14 insertions(+), 33 deletions(-) > Hi, the changes look fine to me, they are more idiomatic to Rust. Acked-by: Michal Wilczynski