From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762918AbdEVXod (ORCPT ); Mon, 22 May 2017 19:44:33 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:22572 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750987AbdEVXoc (ORCPT ); Mon, 22 May 2017 19:44:32 -0400 From: Qing Huang Subject: Re: [PATCH] ib/core: not to set page dirty bit if it's already set. To: Christoph Hellwig References: <20170518233353.14370-1-qing.huang@oracle.com> <20170519130541.GA8017@infradead.org> Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, dledford@redhat.com, sean.hefty@intel.com, artemyko@mellanox.com, linux-mm@kvack.org Message-ID: <9f4a4f90-a7b1-b1dc-6e7a-042f26254681@oracle.com> Date: Mon, 22 May 2017 16:43:57 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170519130541.GA8017@infradead.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/19/2017 6:05 AM, Christoph Hellwig wrote: > On Thu, May 18, 2017 at 04:33:53PM -0700, Qing Huang wrote: >> This change will optimize kernel memory deregistration operations. >> __ib_umem_release() used to call set_page_dirty_lock() against every >> writable page in its memory region. Its purpose is to keep data >> synced between CPU and DMA device when swapping happens after mem >> deregistration ops. Now we choose not to set page dirty bit if it's >> already set by kernel prior to calling __ib_umem_release(). This >> reduces memory deregistration time by half or even more when we ran >> application simulation test program. > As far as I can tell this code doesn't even need set_page_dirty_lock > and could just use set_page_dirty It seems that set_page_dirty_lock has been used here for more than 10 years. Don't know the original purpose. Maybe it was used to prevent races between setting dirty bits and swapping out pages? Perhaps we can call set_page_dirty before calling ib_dma_unmap_sg? >> Signed-off-by: Qing Huang >> --- >> drivers/infiniband/core/umem.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/infiniband/core/umem.c b/drivers/infiniband/core/umem.c >> index 3dbf811..21e60b1 100644 >> --- a/drivers/infiniband/core/umem.c >> +++ b/drivers/infiniband/core/umem.c >> @@ -58,7 +58,7 @@ static void __ib_umem_release(struct ib_device *dev, struct ib_umem *umem, int d >> for_each_sg(umem->sg_head.sgl, sg, umem->npages, i) { >> >> page = sg_page(sg); >> - if (umem->writable && dirty) >> + if (!PageDirty(page) && umem->writable && dirty) >> set_page_dirty_lock(page); >> put_page(page); >> } >> -- >> 2.9.3 >>